Armin Wolf
7756eb1ed1
hwmon: (gpio-fan) Fix array out of bounds access
...
[ Upstream commit f233d2be38dbbb22299192292983037f01ab363c ]
The driver does not check if the cooling state passed to
gpio_fan_set_cur_state() exceeds the maximum cooling state as
stored in fan_data->num_speeds. Since the cooling state is later
used as an array index in set_fan_speed(), an array out of bounds
access can occur.
This can be exploited by setting the state of the thermal cooling device
to arbitrary values, causing for example a kernel oops when unavailable
memory is accessed this way.
Example kernel oops:
[ 807.987276] Unable to handle kernel paging request at virtual address ffffff80d0588064
[ 807.987369] Mem abort info:
[ 807.987398] ESR = 0x96000005
[ 807.987428] EC = 0x25: DABT (current EL), IL = 32 bits
[ 807.987477] SET = 0, FnV = 0
[ 807.987507] EA = 0, S1PTW = 0
[ 807.987536] FSC = 0x05: level 1 translation fault
[ 807.987570] Data abort info:
[ 807.987763] ISV = 0, ISS = 0x00000005
[ 807.987801] CM = 0, WnR = 0
[ 807.987832] swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000001165000
[ 807.987872] [ffffff80d0588064] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000
[ 807.987961] Internal error: Oops: 96000005 [#1 ] PREEMPT SMP
[ 807.987992] Modules linked in: cmac algif_hash aes_arm64 algif_skcipher af_alg bnep hci_uart btbcm bluetooth ecdh_generic ecc 8021q garp stp llc snd_soc_hdmi_codec brcmfmac vc4 brcmutil cec drm_kms_helper snd_soc_core cfg80211 snd_compress bcm2835_codec(C) snd_pcm_dmaengine syscopyarea bcm2835_isp(C) bcm2835_v4l2(C) sysfillrect v4l2_mem2mem bcm2835_mmal_vchiq(C) raspberrypi_hwmon sysimgblt videobuf2_dma_contig videobuf2_vmalloc fb_sys_fops videobuf2_memops rfkill videobuf2_v4l2 videobuf2_common i2c_bcm2835 snd_bcm2835(C) videodev snd_pcm snd_timer snd mc vc_sm_cma(C) gpio_fan uio_pdrv_genirq uio drm fuse drm_panel_orientation_quirks backlight ip_tables x_tables ipv6
[ 807.988508] CPU: 0 PID: 1321 Comm: bash Tainted: G C 5.15.56-v8+ #1575
[ 807.988548] Hardware name: Raspberry Pi 3 Model B Rev 1.2 (DT)
[ 807.988574] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 807.988608] pc : set_fan_speed.part.5+0x34/0x80 [gpio_fan]
[ 807.988654] lr : gpio_fan_set_cur_state+0x34/0x50 [gpio_fan]
[ 807.988691] sp : ffffffc008cf3bd0
[ 807.988710] x29: ffffffc008cf3bd0 x28: ffffff80019edac0 x27: 0000000000000000
[ 807.988762] x26: 0000000000000000 x25: 0000000000000000 x24: ffffff800747c920
[ 807.988787] x23: 000000000000000a x22: ffffff800369f000 x21: 000000001999997c
[ 807.988854] x20: ffffff800369f2e8 x19: ffffff8002ae8080 x18: 0000000000000000
[ 807.988877] x17: 0000000000000000 x16: 0000000000000000 x15: 000000559e271b70
[ 807.988938] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000
[ 807.988960] x11: 0000000000000000 x10: ffffffc008cf3c20 x9 : ffffffcfb60c741c
[ 807.989018] x8 : 000000000000000a x7 : 00000000ffffffc9 x6 : 0000000000000009
[ 807.989040] x5 : 000000000000002a x4 : 0000000000000000 x3 : ffffff800369f2e8
[ 807.989062] x2 : 000000000000e780 x1 : 0000000000000001 x0 : ffffff80d0588060
[ 807.989084] Call trace:
[ 807.989091] set_fan_speed.part.5+0x34/0x80 [gpio_fan]
[ 807.989113] gpio_fan_set_cur_state+0x34/0x50 [gpio_fan]
[ 807.989199] cur_state_store+0x84/0xd0
[ 807.989221] dev_attr_store+0x20/0x38
[ 807.989262] sysfs_kf_write+0x4c/0x60
[ 807.989282] kernfs_fop_write_iter+0x130/0x1c0
[ 807.989298] new_sync_write+0x10c/0x190
[ 807.989315] vfs_write+0x254/0x378
[ 807.989362] ksys_write+0x70/0xf8
[ 807.989379] __arm64_sys_write+0x24/0x30
[ 807.989424] invoke_syscall+0x4c/0x110
[ 807.989442] el0_svc_common.constprop.3+0xfc/0x120
[ 807.989458] do_el0_svc+0x2c/0x90
[ 807.989473] el0_svc+0x24/0x60
[ 807.989544] el0t_64_sync_handler+0x90/0xb8
[ 807.989558] el0t_64_sync+0x1a0/0x1a4
[ 807.989579] Code: b9403801 f9402800 7100003f 8b35cc00 (b9400416)
[ 807.989627] ---[ end trace 8ded4c918658445b ]---
Fix this by checking the cooling state and return an error if it
exceeds the maximum cooling state.
Tested on a Raspberry Pi 3.
Fixes: b5cf88e46bad ("(gpio-fan): Add thermal control hooks")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20220830011101.178843-1-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-09-15 12:04:52 +02:00
..
2021-05-19 10:08:30 +02:00
2022-04-15 14:18:05 +02:00
2019-05-30 11:29:22 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:29:22 -07:00
2019-05-30 11:29:22 -07:00
2020-07-09 09:37:53 +02:00
2019-05-30 11:25:18 -07:00
2019-05-30 11:26:32 -07:00
2019-06-05 17:37:10 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-06-23 18:34:11 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:42 +02:00
2019-05-24 17:36:45 +02:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:25:18 -07:00
2019-05-30 11:25:18 -07:00
2019-06-19 17:09:55 +02:00
2020-03-12 13:00:30 +01:00
2022-05-12 12:23:44 +02:00
2020-01-29 16:45:24 +01:00
2019-05-24 17:36:45 +02:00
2020-09-09 19:12:20 +02:00
2019-09-03 12:47:17 -07:00
2019-09-03 12:47:17 -07:00
2019-05-24 17:36:45 +02:00
2020-07-29 10:18:37 +02:00
2019-06-23 18:33:01 -07:00
2019-07-31 13:25:27 -06:00
2019-08-31 08:04:57 -07:00
2020-05-20 08:20:26 +02:00
2019-05-30 11:26:32 -07:00
2022-02-16 12:52:53 +01:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:39 -07:00
2020-07-22 09:33:14 +02:00
2019-05-24 17:36:45 +02:00
2022-05-18 09:47:26 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:43 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:32 -07:00
2019-05-21 11:28:47 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2022-09-15 12:04:52 +02:00
2019-05-24 17:39:00 +02:00
2019-05-24 17:36:45 +02:00
2022-06-25 12:44:36 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:37 -07:00
2022-07-07 17:36:50 +02:00
2019-05-30 11:26:35 -07:00
2019-05-24 17:39:01 +02:00
2019-09-03 12:47:17 -07:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:17 +02:00
2020-12-30 11:51:17 +01:00
2019-05-30 11:26:37 -07:00
2020-05-02 08:48:59 +02:00
2019-09-03 12:47:17 -07:00
2020-06-22 09:31:19 +02:00
2022-05-18 09:47:25 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-06-05 17:37:04 +02:00
2019-09-04 11:06:47 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2021-05-26 12:05:18 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2022-02-01 17:24:38 +01:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:37 -07:00
2019-04-15 17:19:53 -07:00
2019-05-30 11:26:37 -07:00
2019-09-03 12:47:17 -07:00
2019-05-24 17:36:45 +02:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:26:37 -07:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-21 11:28:45 +02:00
2019-09-22 09:30:30 -07:00
2019-06-19 17:09:55 +02:00
2019-06-05 17:37:06 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-06-23 18:33:01 -07:00
2020-07-09 09:37:53 +02:00
2019-06-05 17:37:17 +02:00
2021-07-14 16:53:23 +02:00
2021-07-14 16:53:23 +02:00
2019-02-18 14:23:29 -08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2021-10-06 15:42:32 +02:00
2019-05-30 11:26:37 -07:00
2020-07-29 10:18:39 +02:00
2020-01-29 16:45:30 +01:00
2020-09-03 11:26:54 +02:00
2019-09-03 12:47:17 -07:00
2019-06-05 17:37:14 +02:00
2019-05-30 11:26:35 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:41 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2021-01-19 18:26:15 +01:00
2019-09-03 12:47:17 -07:00
2019-06-05 17:37:06 +02:00
2022-04-15 14:18:04 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-29 10:18:39 +02:00
2021-06-23 14:41:27 +02:00
2019-05-30 11:26:37 -07:00
2019-04-17 10:37:23 -07:00
2019-05-24 17:39:00 +02:00
2019-09-10 11:42:56 -07:00
2019-05-24 17:36:45 +02:00
2019-09-17 16:22:26 -07:00
2019-05-24 17:36:45 +02:00
2019-06-23 18:33:01 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:37 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:37 -07:00
2022-05-18 09:47:24 +02:00
2021-10-06 15:42:33 +02:00
2019-05-21 10:50:45 +02:00
2019-05-30 11:26:41 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:38 -07:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-06-05 17:30:30 +02:00
2019-05-24 17:36:45 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:32 -07:00
2019-09-03 12:47:17 -07:00
2021-10-06 15:42:31 +02:00
2021-10-06 15:42:30 +02:00
2021-10-06 15:42:30 +02:00
2019-06-05 17:30:30 +02:00
2019-06-05 17:30:30 +02:00
2019-06-05 17:30:30 +02:00
2019-05-21 11:28:45 +02:00