iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/ata
History
Kai-Heng Feng 383b7c50f5 ata: ahci: Match EM_MAX_SLOTS with SATA_PMP_MAX_PORTS 
commit 1e41e693f458eef2d5728207dbd327cd3b16580a upstream.

UBSAN complains about array-index-out-of-bounds:
[ 1.980703] kernel: UBSAN: array-index-out-of-bounds in /build/linux-9H675w/linux-5.15.0/drivers/ata/libahci.c:968:41
[ 1.980709] kernel: index 15 is out of range for type 'ahci_em_priv [8]'
[ 1.980713] kernel: CPU: 0 PID: 209 Comm: scsi_eh_8 Not tainted 5.15.0-25-generic #25-Ubuntu
[ 1.980716] kernel: Hardware name: System manufacturer System Product Name/P5Q3, BIOS 1102 06/11/2010
[ 1.980718] kernel: Call Trace:
[ 1.980721] kernel: <TASK>
[ 1.980723] kernel: show_stack+0x52/0x58
[ 1.980729] kernel: dump_stack_lvl+0x4a/0x5f
[ 1.980734] kernel: dump_stack+0x10/0x12
[ 1.980736] kernel: ubsan_epilogue+0x9/0x45
[ 1.980739] kernel: __ubsan_handle_out_of_bounds.cold+0x44/0x49
[ 1.980742] kernel: ahci_qc_issue+0x166/0x170 [libahci]
[ 1.980748] kernel: ata_qc_issue+0x135/0x240
[ 1.980752] kernel: ata_exec_internal_sg+0x2c4/0x580
[ 1.980754] kernel: ? vprintk_default+0x1d/0x20
[ 1.980759] kernel: ata_exec_internal+0x67/0xa0
[ 1.980762] kernel: sata_pmp_read+0x8d/0xc0
[ 1.980765] kernel: sata_pmp_read_gscr+0x3c/0x90
[ 1.980768] kernel: sata_pmp_attach+0x8b/0x310
[ 1.980771] kernel: ata_eh_revalidate_and_attach+0x28c/0x4b0
[ 1.980775] kernel: ata_eh_recover+0x6b6/0xb30
[ 1.980778] kernel: ? ahci_do_hardreset+0x180/0x180 [libahci]
[ 1.980783] kernel: ? ahci_stop_engine+0xb0/0xb0 [libahci]
[ 1.980787] kernel: ? ahci_do_softreset+0x290/0x290 [libahci]
[ 1.980792] kernel: ? trace_event_raw_event_ata_eh_link_autopsy_qc+0xe0/0xe0
[ 1.980795] kernel: sata_pmp_eh_recover.isra.0+0x214/0x560
[ 1.980799] kernel: sata_pmp_error_handler+0x23/0x40
[ 1.980802] kernel: ahci_error_handler+0x43/0x80 [libahci]
[ 1.980806] kernel: ata_scsi_port_error_handler+0x2b1/0x600
[ 1.980810] kernel: ata_scsi_error+0x9c/0xd0
[ 1.980813] kernel: scsi_error_handler+0xa1/0x180
[ 1.980817] kernel: ? scsi_unjam_host+0x1c0/0x1c0
[ 1.980820] kernel: kthread+0x12a/0x150
[ 1.980823] kernel: ? set_kthread_struct+0x50/0x50
[ 1.980826] kernel: ret_from_fork+0x22/0x30
[ 1.980831] kernel: </TASK>

This happens because sata_pmp_init_links() initialize link->pmp up to
SATA_PMP_MAX_PORTS while em_priv is declared as 8 elements array.

I can't find the maximum Enclosure Management ports specified in AHCI
spec v1.3.1, but "12.2.1 LED message type" states that "Port Multiplier
Information" can utilize 4 bits, which implies it can support up to 16
ports. Hence, use SATA_PMP_MAX_PORTS as EM_MAX_SLOTS to resolve the
issue.

BugLink: https://bugs.launchpad.net/bugs/1970074
Cc: stable@vger.kernel.org
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-10-29 10:20:34 +02:00
..
acard-ahci.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
ahci_brcm.c
ata: ahci_brcm: Add back regulators management
2021-03-04 10:26:23 +01:00
ahci_ceva.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
ahci_da850.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_dm816.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_imx.c
ata: ahci-imx: Fix MODULE_ALIAS
2022-10-29 10:20:34 +02:00
ahci_mtk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
ahci_mvebu.c
ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
2020-11-01 12:01:05 +01:00
ahci_octeon.c
Delete redundant return value check of platform_get_resource()
2017-03-06 15:40:59 -05:00
ahci_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_qoriq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
ahci_seattle.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
2019-06-19 17:09:07 +02:00
ahci_st.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
ahci_sunxi.c
ata: ahci_sunxi: Disable DIPM
2021-07-19 08:53:15 +02:00
ahci_tegra.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
ahci_xgene.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
ahci.c
ata: ahci: Add Green Sardine vendor ID as board_ahci_mobile
2021-12-08 09:01:10 +01:00
ahci.h
ata: ahci: Match EM_MAX_SLOTS with SATA_PMP_MAX_PORTS
2022-10-29 10:20:34 +02:00
ata_generic.c
…
ata_piix.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
Kconfig
ata: add Buddha PATA controller driver
2019-02-08 06:32:01 -07:00
libahci_platform.c
ata: libahci_platform: Sanity check the DT child nodes number
2022-10-26 13:22:56 +02:00
libahci.c
ata: ahci: Disable SXS for Hisilicon Kunpeng920
2021-05-11 14:04:10 +02:00
libata-acpi.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
libata-core.c
libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205
2022-10-05 10:37:42 +02:00
libata-eh.c
ata: libata-eh: Add missing command name
2022-08-25 11:18:18 +02:00
libata-pmp.c
libata: Return correct status in sata_pmp_eh_recover_pm() when ATA_DFLAG_DETACH is set
2020-04-17 10:50:22 +02:00
libata-scsi.c
libata: if T_LENGTH is zero, dma direction should be DMA_NONE
2021-12-22 09:29:39 +01:00
libata-sff.c
libata: fix ata_pio_sector for CONFIG_HIGHMEM
2021-08-12 13:21:04 +02:00
libata-trace.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
libata-transport.c
ata: libata-transport: fix {dma|pio|xfer}_mode sysfs files
2022-06-14 18:12:02 +02:00
libata-transport.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
libata-zpodd.c
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
2019-07-29 16:00:14 -06:00
libata.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
Makefile
ata: add Buddha PATA controller driver
2019-02-08 06:32:01 -07:00
pata_acpi.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ali.c
ata: Deprecate pci_get_bus_and_slot()
2018-01-11 17:23:23 -06:00
pata_amd.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_arasan_cf.c
pata_arasan_cf: fix IRQ check
2021-05-14 09:44:24 +02:00
pata_artop.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_atiixp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_atp867x.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_bk3710.c
pata_bk3710: clarify license version and use SPDX header
2018-03-01 13:59:03 -08:00
pata_buddha.c
ata/pata_buddha: Probe via modalias instead of initcall
2019-08-23 06:58:50 -06:00
pata_cmd64x.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_cmd640.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_cs5520.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_cs5530.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cs5535.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cs5536.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_cypress.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_efar.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ep93xx.c
pata_ep93xx: fix deferred probing
2021-07-14 16:53:21 +02:00
pata_falcon.c
pata_falcon: clarify license version and use SPDX header
2018-03-01 13:58:17 -08:00
pata_ftide010.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_gayle.c
ata: add Amiga Gayle PATA controller driver
2018-03-19 07:41:36 -07:00
pata_hpt3x2n.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_hpt3x3.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_hpt37x.c
ata: pata_hpt37x: fix PCI clock detection
2022-03-08 19:07:46 +01:00
pata_hpt366.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_icside.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_imx.c
Merge branch 'for-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2018-08-24 13:20:33 -07:00
pata_isapnp.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_it821x.c
pata_it821x: Delete an error message for a failed memory allocation in it821x_firmware_command()
2018-02-18 05:26:07 -08:00
pata_it8213.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ixp4xx_cf.c
pata_ipx4xx_cf: fix IRQ check
2021-05-14 09:44:24 +02:00
pata_jmicron.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_legacy.c
pata_legacy: fix a couple uninitialized variable bugs
2021-10-20 11:40:16 +02:00
pata_macio.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
pata_marvell.c
ata: pata_marvell: Check the 'bmdma_addr' beforing reading
2022-04-27 13:50:48 +02:00
pata_mpc52xx.c
pata_mpc52xx: Delete an error message for a failed memory allocation in mpc52xx_ata_probe()
2018-02-18 05:23:25 -08:00
pata_mpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_netcell.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_ninja32.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_ns87410.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_ns87415.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_octeon_cf.c
ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe
2022-06-14 18:11:57 +02:00
pata_of_platform.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_oldpiix.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_opti.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_optidma.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_palmld.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_pcmcia.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_pdc202xx_old.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_pdc2027x.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_piccolo.c
…
pata_platform.c
ata: pata_platform: Add IRQF_SHARED to IRQ flags
2019-02-08 06:42:55 -07:00
pata_pxa.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
pata_radisys.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_rb532_cf.c
pata_rb532_cf: fix deferred probing
2021-07-14 16:53:20 +02:00
pata_rdc.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
pata_rz1000.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_samsung_cf.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
pata_sc1200.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_sch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300
2019-06-05 17:37:00 +02:00
pata_serverworks.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_sil680.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
pata_sis.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_sl82c105.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pata_triflex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pata_via.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pdc_adma.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: Fix crash due to OOB write
2022-04-15 14:18:39 +02:00
sata_fsl.c
sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
2021-12-08 09:01:11 +01:00
sata_gemini.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
sata_gemini.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sata_highbank.c
sata_highbank: fix deferred probing
2021-07-14 16:53:20 +02:00
sata_inic162x.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_mv.c
ata: sata_mv: Fix the error handling of mv_chip_id()
2021-11-02 19:46:12 +01:00
sata_nv.c
ata: sata_nv: Fix retrieving of active qcs
2020-11-05 11:43:12 +01:00
sata_promise.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_promise.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_rcar.c
ata: sata_rcar: Fix DMA boundary mask
2020-11-01 12:01:06 +01:00
sata_sil24.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_sil.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_sis.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_svw.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_sx4.c
ata: make qc_prep return ata_completion_errors
2020-10-01 13:18:26 +02:00
sata_uli.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_via.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_vsc.c
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sis.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00