Uday Shankar
efdcd1e32c
scsi: core: Restrict legal sdev_state transitions via sysfs ...
[ Upstream commit 2331ce6126be8864b39490e705286b66e2344aac ]
Userspace can currently write to sysfs to transition sdev_state to RUNNING
or OFFLINE from any source state. This causes issues because proper
transitioning out of some states involves steps besides just changing
sdev_state, so allowing userspace to change sdev_state regardless of the
source state can result in inconsistencies; e.g. with ISCSI we can end up
with sdev_state == SDEV_RUNNING while the device queue is quiesced. Any
task attempting I/O on the device will then hang, and in more recent
kernels, iscsid will hang as well.
More detail about this bug is provided in my first attempt:
https://groups.google.com/g/open-iscsi/c/PNKca4HgPDs/m/CXaDkntOAQAJ
Link: https://lore.kernel.org/r/20220924000241.2967323-1-ushankar@purestorage.com
Signed-off-by: Uday Shankar <ushankar@purestorage.com>
Suggested-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-10 17:57:53 +01:00
2020-10-01 13:17:56 +02:00
2021-07-25 14:35:12 +02:00
2021-07-25 14:35:13 +02:00
2019-05-21 10:50:46 +02:00
2020-08-19 08:16:09 +02:00
2021-07-20 16:10:53 +02:00
2022-04-15 14:18:32 +02:00
2022-02-08 18:24:33 +01:00
2021-07-20 16:10:43 +02:00
2021-11-17 09:48:43 +01:00
2021-07-20 16:10:43 +02:00
2020-10-01 13:18:02 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:22:58 +01:00
2022-06-14 18:11:40 +02:00
2021-02-07 15:35:48 +01:00
2022-04-15 14:18:14 +02:00
2021-05-14 09:44:25 +02:00
2022-04-20 09:19:36 +02:00
2021-07-25 14:35:13 +02:00
2022-04-15 14:18:34 +02:00
2022-10-26 13:22:41 +02:00
2022-09-15 12:04:54 +02:00
2022-09-15 12:04:53 +02:00
2022-09-15 12:04:54 +02:00
2022-04-20 09:19:37 +02:00
2021-09-22 12:26:24 +02:00
2022-04-15 14:18:33 +02:00
2022-10-15 07:54:37 +02:00
2022-04-27 13:50:48 +02:00
2022-08-25 11:18:10 +02:00
2020-10-29 09:57:36 +01:00
2022-08-25 11:17:56 +02:00
2019-01-29 00:40:54 -05:00
2019-08-12 21:58:07 -04:00
2022-08-03 11:59:38 +02:00
2022-10-26 13:22:56 +02:00
2019-03-02 11:39:54 -08:00
2018-12-19 21:54:07 -05:00
2019-05-24 17:36:45 +02:00
2019-01-08 07:58:37 -05:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2021-11-26 10:47:15 +01:00
2022-04-15 14:18:34 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-05-21 10:50:45 +02:00
2021-09-22 12:26:37 +02:00
2021-06-03 08:59:11 +02:00
2019-05-21 10:50:45 +02:00
2019-10-09 23:39:35 -04:00
2022-06-14 18:11:46 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-07-11 15:17:41 -07:00
2019-06-20 15:21:33 -04:00
2019-07-30 12:18:24 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2019-06-18 19:46:22 -04:00
2021-07-14 16:53:41 +02:00
2019-05-21 10:50:45 +02:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:57:42 -05:00
2019-05-30 11:25:18 -07:00
2019-01-08 21:58:35 -05:00
2019-05-21 10:50:45 +02:00
2021-10-27 09:54:29 +02:00
2019-07-11 15:14:01 -07:00
2020-11-18 19:20:22 +01:00
2019-06-18 19:46:18 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-11 15:17:41 -07:00
2019-05-21 11:28:46 +02:00
2022-06-22 14:11:20 +02:00
2020-04-01 11:01:54 +02:00
2018-12-18 23:19:21 -05:00
2020-06-24 17:50:37 +02:00
2020-02-24 08:36:50 +01:00
2019-05-30 11:26:37 -07:00
2021-05-14 09:44:25 +02:00
2020-07-22 09:32:57 +02:00
2019-05-24 17:36:45 +02:00
2019-07-11 15:14:01 -07:00
2022-01-11 15:23:33 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-04 19:18:10 +01:00
2019-07-17 22:39:27 +09:00
2022-06-14 18:11:26 +02:00
2020-08-19 08:16:15 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2020-10-29 09:58:04 +01:00
2019-05-30 11:26:39 -07:00
2022-06-14 18:12:00 +02:00
2022-02-16 12:52:49 +01:00
2019-08-07 21:53:23 -04:00
2019-05-24 17:36:45 +02:00
2020-01-04 19:18:16 +01:00
2019-06-20 15:37:02 -04:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2022-06-22 14:11:20 +02:00
2019-05-30 11:26:35 -07:00
2019-06-20 15:21:33 -04:00
2019-05-30 11:26:38 -07:00
2019-08-16 11:33:56 -07:00
2019-08-16 11:33:56 -07:00
2019-03-19 17:11:37 -04:00
2018-12-18 23:19:21 -05:00
2019-08-07 21:32:53 -04:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2021-12-22 09:29:40 +01:00
2022-01-27 09:19:52 +01:00
2019-05-21 06:16:21 -04:00
2021-06-18 09:58:59 +02:00
2020-07-29 10:18:27 +02:00
2019-10-03 21:43:04 -04:00
2019-05-21 06:16:21 -04:00
2022-08-03 11:59:41 +02:00
2019-08-07 21:47:29 -04:00
2019-05-30 11:26:35 -07:00
2020-06-07 13:18:50 +02:00
2019-06-18 19:46:17 -04:00
2019-07-30 13:07:42 +02:00
2021-08-26 08:36:14 -04:00
2019-05-30 11:29:53 -07:00
2022-11-10 17:57:53 +01:00
2020-01-23 08:22:59 +01:00
2019-07-11 15:14:01 -07:00
2021-12-08 09:01:09 +01:00
2020-01-23 08:22:58 +01:00
2021-01-12 20:16:09 +01:00
2021-04-21 12:56:14 +02:00
2021-11-06 13:59:44 +01:00
2019-06-05 17:37:14 +02:00
2019-11-05 23:17:53 -05:00
2021-10-09 14:39:49 +02:00
2019-08-04 21:41:29 -06:00
2021-10-17 10:42:34 +02:00
2022-08-25 11:18:17 +02:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2021-05-14 09:44:25 +02:00
2022-01-27 09:19:48 +01:00
2022-01-27 09:19:48 +01:00
2021-04-07 14:47:39 +02:00
2022-10-15 07:54:39 +02:00
2022-09-05 10:27:44 +02:00
2020-01-04 19:18:10 +01:00
2021-05-14 09:44:25 +02:00
2019-05-21 10:50:45 +02:00
2021-10-17 10:42:34 +02:00
2022-01-05 12:37:46 +01:00
2022-06-22 14:11:20 +02:00
2019-08-07 21:35:59 -04:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2022-03-11 11:22:39 +01:00
2019-05-21 10:50:45 +02:00
2022-04-15 14:18:37 +02:00
2020-01-04 19:17:37 +01:00
efdcd1e32c