Tejun Heo
35963b3182
memcg: fix possible use-after-free in memcg_write_event_control() ...
commit 4a7ba45b1a435e7097ca0f79a847d0949d0eb088 upstream.
memcg_write_event_control() accesses the dentry->d_name of the specified
control fd to route the write call. As a cgroup interface file can't be
renamed, it's safe to access d_name as long as the specified file is a
regular cgroup file. Also, as these cgroup interface files can't be
removed before the directory, it's safe to access the parent too.
Prior to 347c4a874710 ("memcg: remove cgroup_event->cft"), there was a
call to __file_cft() which verified that the specified file is a regular
cgroupfs file before further accesses. The cftype pointer returned from
__file_cft() was no longer necessary and the commit inadvertently dropped
the file type check with it allowing any file to slip through. With the
invarients broken, the d_name and parent accesses can now race against
renames and removals of arbitrary files and cause use-after-free's.
Fix the bug by resurrecting the file type check in __file_cft(). Now that
cgroupfs is implemented through kernfs, checking the file operations needs
to go through a layer of indirection. Instead, let's check the superblock
and dentry type.
Link: https://lkml.kernel.org/r/Y5FRm/cfcKPGzWwl@slm.duckdns.org
Fixes: 347c4a874710 ("memcg: remove cgroup_event->cft")
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Jann Horn <jannh@google.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Shakeel Butt <shakeelb@google.com>
Cc: <stable@vger.kernel.org> [3.14+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-12-14 11:30:43 +01:00
2019-08-09 09:15:05 +02:00
2021-04-07 14:47:41 +02:00
2020-04-02 15:11:02 +02:00
2019-09-17 10:27:46 -07:00
2020-04-01 11:01:34 +02:00
2019-09-18 11:14:31 -07:00
2020-02-19 19:53:09 +01:00
2019-08-28 17:24:22 +02:00
2019-08-11 10:48:28 +02:00
2022-06-14 18:11:59 +02:00
2020-07-22 09:33:13 +02:00
2019-08-20 10:35:46 +01:00
2019-09-17 00:40:05 -05:00
2022-08-25 11:18:04 +02:00
2021-06-16 11:59:44 +02:00
2022-11-03 23:56:56 +09:00
2022-12-08 11:23:04 +01:00
2022-06-14 18:12:03 +02:00
2021-03-30 14:35:28 +02:00
2021-04-21 12:56:16 +02:00
2022-09-05 10:27:41 +02:00
2019-09-13 12:47:36 +02:00
2019-09-13 12:47:36 +02:00
2019-08-23 11:09:41 +02:00
2022-09-15 12:04:50 +02:00
2021-09-15 09:47:27 +02:00
2020-10-01 13:18:18 +02:00
2020-02-24 08:36:47 +01:00
2020-02-11 04:35:55 -08:00
2022-09-28 11:03:57 +02:00
2019-09-19 16:24:24 -07:00
2019-09-04 14:57:28 +05:30
2021-05-14 09:44:20 +02:00
2022-05-25 09:14:34 +02:00
2022-09-15 12:04:52 +02:00
2019-08-10 15:25:47 -07:00
2021-05-07 10:51:36 +02:00
2020-01-09 10:19:59 +01:00
2019-08-20 22:09:52 +02:00
2019-08-09 17:30:40 +02:00
2022-03-19 13:40:15 +01:00
2022-10-26 13:22:39 +02:00
2019-08-30 21:29:32 -04:00
2020-05-14 07:58:30 +02:00
2020-05-14 07:58:30 +02:00
2019-09-02 15:55:03 +01:00
2020-10-01 13:17:47 +02:00
2021-07-14 16:53:48 +02:00
2022-07-29 17:14:18 +02:00
2019-10-14 15:04:01 -07:00
2020-06-24 17:50:39 +02:00
2019-08-28 21:17:12 -06:00
2022-04-15 14:18:01 +02:00
2019-09-05 19:52:34 -06:00
2022-05-25 09:14:38 +02:00
2020-03-05 16:43:52 +01:00
2021-09-15 09:47:39 +02:00
2022-06-14 18:11:34 +02:00
2022-09-15 12:04:49 +02:00
2019-09-05 10:15:16 +02:00
2020-12-16 10:56:58 +01:00
2020-09-09 19:12:34 +02:00
2021-09-26 14:07:10 +02:00
2019-08-09 09:17:05 -07:00
2022-07-21 20:59:17 +02:00
2022-12-14 11:30:43 +01:00
2019-09-19 15:31:27 -07:00
2019-09-20 15:45:07 -07:00
2019-09-24 15:54:10 -07:00
2019-11-29 10:10:08 +01:00
2019-10-11 09:26:05 -07:00
2021-02-17 10:35:16 +01:00
2020-12-16 10:56:59 +01:00
2021-01-23 15:57:55 +01:00
2021-09-30 10:09:25 +02:00
2021-05-26 12:05:20 +02:00
2021-11-17 09:48:25 +01:00
2019-09-04 13:38:26 +02:00
2022-10-07 09:16:54 +02:00
2020-02-11 04:35:25 -08:00
2022-06-22 14:11:12 +02:00
2019-09-03 09:36:36 +02:00
2019-09-17 19:15:14 -07:00
2019-09-25 17:51:40 -07:00
2019-08-09 22:52:10 +10:00
2019-09-23 11:21:04 -07:00
2021-03-09 11:09:38 +01:00
2020-09-23 12:40:47 +02:00
2022-09-15 12:04:54 +02:00
2020-04-17 10:50:09 +02:00
2019-08-25 12:44:38 +09:00
2022-06-25 12:44:35 +02:00
2021-08-18 08:57:03 +02:00
2022-07-07 17:36:49 +02:00
2021-01-19 18:26:13 +01:00
2020-07-29 10:18:29 +02:00
2019-08-21 07:14:10 +09:00
2020-01-04 19:17:24 +01:00
2019-08-17 18:46:33 +01:00
2022-05-25 09:14:38 +02:00
2019-08-29 16:43:22 +02:00
2019-08-16 12:40:58 +01:00
2020-02-24 08:36:40 +01:00
2020-04-01 11:01:53 +02:00
2022-10-26 13:22:37 +02:00
2019-09-03 19:21:19 +02:00
2021-03-11 14:06:50 +01:00
2022-11-10 17:57:55 +01:00
2021-05-19 10:08:30 +02:00
2021-10-27 09:54:27 +02:00
2020-06-17 16:40:20 +02:00
2021-09-15 09:47:33 +02:00
2019-08-07 13:52:43 +01:00
2022-04-27 13:50:45 +02:00
2020-02-11 04:35:37 -08:00
2019-10-18 15:32:52 +02:00
2019-08-21 22:23:48 +10:00
2021-04-07 14:47:43 +02:00
2020-04-23 10:36:33 +02:00
2020-09-03 11:27:09 +02:00
2022-07-12 16:30:47 +02:00
2021-11-17 09:48:20 +01:00
2020-10-14 10:32:56 +02:00
2022-01-20 09:19:17 +01:00
2022-09-05 10:27:47 +02:00
2021-09-12 08:56:38 +02:00
2020-05-14 07:58:30 +02:00
2022-02-01 17:24:39 +01:00
2019-08-12 19:33:50 -07:00
2022-02-23 11:59:56 +01:00
2020-03-25 08:25:58 +01:00
2019-08-26 11:40:24 +02:00
2020-10-07 08:01:29 +02:00
2019-10-28 16:17:31 -07:00
2019-09-05 11:40:54 +02:00
2019-08-27 19:02:59 +02:00
2022-01-27 09:19:43 +01:00
2020-11-05 11:43:36 +01:00
2019-08-20 09:35:02 -03:00
2021-09-15 09:47:26 +02:00
2021-06-30 08:47:52 -04:00
2021-09-22 12:26:37 +02:00
2022-06-22 14:11:12 +02:00
2019-10-02 06:36:50 -07:00
2020-08-11 15:33:38 +02:00
2020-09-23 12:40:38 +02:00
2021-05-19 10:08:22 +02:00
2021-03-04 10:26:53 +01:00
2019-09-03 11:33:29 +02:00
2019-11-08 08:46:49 -08:00
2020-06-03 08:21:36 +02:00
2022-03-23 09:12:07 +01:00
2020-01-12 12:21:46 +01:00
2021-03-30 14:35:25 +02:00
2019-10-24 14:53:48 -07:00
2020-07-22 09:32:49 +02:00
2019-09-28 08:14:15 -07:00
2020-03-18 07:17:38 +01:00
2021-08-18 08:57:01 +02:00
2019-08-28 11:50:33 +02:00
2019-08-20 12:04:07 -07:00
2021-02-03 23:26:01 +01:00
2020-02-28 17:22:26 +01:00
2019-08-13 23:02:48 +03:00
2019-08-13 23:02:44 +03:00
2019-09-17 19:15:14 -07:00
2019-09-25 17:51:39 -07:00
2020-07-29 10:18:44 +02:00
2019-08-30 16:12:10 +02:00
2020-05-10 10:31:30 +02:00
2020-04-17 10:50:04 +02:00
2022-09-28 11:03:58 +02:00
2019-08-23 10:09:58 +02:00
2020-06-24 17:50:35 +02:00
2022-10-26 13:22:46 +02:00
2021-12-01 09:23:35 +01:00
2019-12-31 16:44:14 +01:00
2022-04-15 14:18:32 +02:00
2021-08-18 08:57:02 +02:00
2020-12-11 13:23:30 +01:00
2020-06-24 17:50:48 +02:00
2020-07-16 08:16:44 +02:00
2021-01-09 13:44:54 +01:00
2022-05-09 09:03:22 +02:00
2019-12-13 08:42:53 +01:00
2022-07-02 16:28:50 +02:00
2020-04-23 10:36:45 +02:00
2021-03-04 10:26:29 +01:00
2022-08-25 11:18:04 +02:00
2020-06-22 09:31:03 +02:00
2020-10-14 10:33:05 +02:00
2021-12-08 09:01:10 +01:00
2021-02-07 15:35:49 +01:00
2022-10-07 09:16:54 +02:00
2020-02-11 04:35:40 -08:00
2019-08-05 21:52:53 +02:00
2019-10-08 22:05:58 +02:00
2021-11-17 09:48:17 +01:00
2020-01-04 19:18:28 +01:00
2019-08-29 13:49:13 -07:00
2019-08-06 08:20:10 -06:00
2020-11-10 12:37:24 +01:00
2020-02-24 08:36:45 +01:00
2021-09-22 12:26:20 +02:00
2020-09-09 19:12:29 +02:00
2019-08-13 14:54:24 +08:00
2021-11-17 09:48:16 +01:00
2022-06-14 18:11:42 +02:00
2021-04-21 12:56:18 +02:00
2022-05-25 09:14:32 +02:00
2021-10-09 14:39:49 +02:00
2019-08-09 22:52:10 +10:00
2022-01-05 12:37:44 +01:00
2021-08-26 08:36:22 -04:00
2021-09-22 12:26:43 +02:00
2019-11-15 18:34:00 -08:00
2019-09-28 14:05:38 -07:00
2019-09-29 10:33:41 -07:00
2020-10-07 08:01:25 +02:00
2019-10-17 16:31:52 -07:00
2019-08-20 09:35:03 -03:00
2019-10-04 18:11:08 -07:00
2019-12-13 08:43:18 +01:00
2019-09-25 17:51:40 -07:00
2021-05-19 10:08:31 +02:00
2022-07-29 17:14:18 +02:00
2022-07-29 17:14:18 +02:00
2022-12-08 11:23:04 +01:00
2019-09-07 04:28:04 -03:00
2022-05-15 19:54:46 +02:00
2022-10-07 09:16:54 +02:00
2019-08-06 13:41:04 -04:00
2021-05-11 14:04:04 +02:00
2019-08-14 15:30:35 +02:00
2021-08-18 08:57:03 +02:00
2021-03-30 14:35:29 +02:00
2019-09-03 09:30:45 -04:00
2020-10-14 10:33:00 +02:00
2022-05-18 09:47:24 +02:00
2022-04-15 14:17:56 +02:00
2019-09-13 12:35:33 +02:00
2020-11-18 19:20:17 +01:00
2020-11-18 19:20:17 +01:00
2020-12-02 08:49:44 +01:00
2022-04-15 14:18:35 +02:00
2020-10-01 13:17:52 +02:00
2020-05-06 08:15:05 +02:00
2022-08-25 11:18:37 +02:00
2020-10-07 08:01:30 +02:00
2022-06-14 18:12:02 +02:00
2020-04-17 10:50:10 +02:00
2019-12-31 16:44:40 +01:00
2019-12-31 16:44:43 +01:00
2021-12-08 09:01:08 +01:00
2019-09-11 14:46:02 +01:00
2021-01-06 14:48:37 +01:00
2019-08-09 19:56:05 +02:00
2022-11-01 19:06:42 +01:00
2021-09-03 10:08:12 +02:00
2020-10-29 09:57:51 +01:00
2020-06-17 16:40:22 +02:00
2019-10-14 15:04:00 -07:00
2020-10-29 09:57:52 +01:00
2019-08-03 07:02:01 -07:00
2020-03-25 08:25:58 +01:00
2021-06-30 08:47:55 -04:00
2019-09-07 04:28:04 -03:00
2019-08-28 15:25:53 -05:00
2022-08-25 11:17:25 +02:00
2021-09-26 14:07:05 +02:00
2020-04-17 10:50:11 +02:00
2019-08-16 08:41:26 -05:00
2022-04-15 14:18:15 +02:00
2020-04-23 10:36:37 +02:00
2020-02-11 04:35:44 -08:00
2022-01-20 09:19:18 +01:00
2019-09-05 11:54:14 +02:00
2020-03-18 07:17:46 +01:00
2019-08-01 21:49:46 +02:00
2020-03-18 07:17:56 +01:00
2019-08-05 10:58:19 +02:00
2019-12-21 11:04:31 +01:00
2020-12-30 11:50:53 +01:00
2019-08-21 00:20:40 +02:00
2021-05-19 10:08:20 +02:00
2020-05-20 08:20:27 +02:00
2020-01-04 19:18:48 +01:00
2019-09-05 21:16:22 +02:00
2022-06-22 14:11:16 +02:00
2020-12-30 11:50:55 +01:00
2020-05-02 08:48:42 +02:00
2021-01-12 20:16:10 +01:00
2019-08-26 11:35:13 +02:00
2019-08-09 17:51:39 +01:00
2022-02-05 12:35:36 +01:00
2022-02-05 12:35:36 +01:00
2021-06-23 14:41:26 +02:00
2022-06-14 18:11:24 +02:00
2019-09-21 03:25:10 +02:00
2020-11-01 12:01:06 +01:00
2020-01-04 19:17:25 +01:00
2019-12-17 19:56:43 +01:00
2019-11-01 22:26:34 -04:00
2019-09-12 21:05:34 -04:00
2022-06-22 14:11:19 +02:00
2022-06-29 08:58:45 +02:00
2019-09-25 17:51:39 -07:00
2019-08-13 14:35:49 -07:00
2019-08-09 11:01:08 -07:00
2020-02-24 08:36:45 +01:00
2019-08-09 11:00:35 -07:00
2021-03-04 10:26:47 +01:00
2019-08-26 16:27:01 -07:00
2019-09-25 17:42:29 +02:00
2022-07-29 17:14:17 +02:00
2019-10-28 12:18:23 +01:00
2019-10-24 10:26:33 +02:00
2020-08-05 09:59:47 +02:00
2022-12-08 11:23:05 +01:00
2022-09-05 10:27:46 +02:00
2019-09-16 11:43:38 -05:00
2021-11-17 09:48:44 +01:00
2022-07-12 16:30:49 +02:00
2021-01-09 13:44:55 +01:00
2022-09-05 10:27:39 +02:00
2019-08-12 12:23:02 +01:00
2022-06-06 08:33:48 +02:00
2020-04-02 15:11:00 +02:00
2020-12-30 11:51:21 +01:00
2020-10-01 13:17:25 +02:00
2022-09-28 11:04:08 +02:00
2020-06-17 16:40:31 +02:00
2019-09-12 21:05:34 -04:00
2019-09-24 15:54:11 -07:00
2019-08-19 06:34:13 -05:00
2022-06-22 14:11:16 +02:00
2022-10-26 13:22:59 +02:00
2021-04-14 08:24:12 +02:00
2019-10-07 15:47:20 -07:00
2021-05-14 09:44:33 +02:00
2021-06-23 14:41:25 +02:00
2019-08-19 13:14:53 -03:00
2022-05-25 09:14:38 +02:00
2021-03-17 17:03:56 +01:00
2020-06-22 09:31:12 +02:00
2022-02-16 12:52:50 +01:00
2020-04-13 10:48:07 +02:00
2021-03-07 12:20:49 +01:00
2020-04-23 10:36:37 +02:00
2020-11-24 13:29:04 +01:00
2019-08-05 14:56:30 -07:00
2019-09-07 21:42:25 +02:00
2021-03-07 12:20:48 +01:00
2019-09-17 20:03:49 -06:00
2022-10-26 13:22:26 +02:00
2022-03-02 11:41:04 +01:00
2021-09-26 14:07:10 +02:00
2021-03-24 11:26:44 +01:00
2019-08-26 12:15:06 +03:00
2021-09-16 12:56:13 +02:00
2019-12-18 16:08:43 +01:00
2019-08-23 02:12:11 +02:00
2019-08-01 20:51:22 +02:00
2019-08-02 14:45:14 +10:00
2019-08-28 11:50:43 +02:00
2022-06-22 14:11:15 +02:00
2020-01-23 08:22:44 +01:00
2022-03-08 19:07:48 +01:00
2022-08-25 11:18:11 +02:00
2020-08-19 08:16:27 +02:00
2019-08-31 06:51:49 -04:00
2020-12-30 11:51:21 +01:00
2021-07-14 16:53:08 +02:00
2021-05-14 09:44:22 +02:00
2022-07-29 17:14:20 +02:00
2020-12-11 13:23:28 +01:00
2021-03-30 14:35:22 +02:00
2020-01-17 19:48:40 +01:00
2021-02-17 10:35:19 +01:00
2021-03-24 11:26:40 +01:00
2022-09-15 12:04:52 +02:00
2019-08-05 18:40:18 -04:00
2019-08-14 01:10:42 +09:00
2022-03-16 13:21:48 +01:00
2021-12-29 12:23:34 +01:00
2020-10-07 08:01:24 +02:00
2022-03-16 13:21:48 +01:00
2020-04-29 16:33:14 +02:00
2020-04-02 15:11:00 +02:00
2019-09-04 14:34:31 +02:00
2022-08-25 11:17:29 +02:00
2019-09-13 21:15:39 +10:00
2019-08-27 09:22:38 -06:00
2021-06-10 13:37:14 +02:00
2020-08-11 15:33:39 +02:00
2019-09-24 15:54:12 -07:00
2021-03-07 12:20:49 +01:00
35963b3182