Markus Weippert
bb55decee2
bcache: revert replacing IS_ERR_OR_NULL with IS_ERR ...
commit bb6cc253861bd5a7cf8439e2118659696df9619f upstream.
Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in
node allocations") replaced IS_ERR_OR_NULL by IS_ERR. This leads to a
NULL pointer dereference.
BUG: kernel NULL pointer dereference, address: 0000000000000080
Call Trace:
? __die_body.cold+0x1a/0x1f
? page_fault_oops+0xd2/0x2b0
? exc_page_fault+0x70/0x170
? asm_exc_page_fault+0x22/0x30
? btree_node_free+0xf/0x160 [bcache]
? up_write+0x32/0x60
btree_gc_coalesce+0x2aa/0x890 [bcache]
? bch_extent_bad+0x70/0x170 [bcache]
btree_gc_recurse+0x130/0x390 [bcache]
? btree_gc_mark_node+0x72/0x230 [bcache]
bch_btree_gc+0x5da/0x600 [bcache]
? cpuusage_read+0x10/0x10
? bch_btree_gc+0x600/0x600 [bcache]
bch_gc_thread+0x135/0x180 [bcache]
The relevant code starts with:
new_nodes[0] = NULL;
for (i = 0; i < nodes; i++) {
if (__bch_keylist_realloc(&keylist, bkey_u64s(&r[i].b->key)))
goto out_nocoalesce;
// ...
out_nocoalesce:
// ...
for (i = 0; i < nodes; i++)
if (!IS_ERR(new_nodes[i])) { // IS_ERR_OR_NULL before
028ddcac477b
btree_node_free(new_nodes[i]); // new_nodes[0] is NULL
rw_unlock(true, new_nodes[i]);
}
This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this.
Fixes: 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations")
Link: https://lore.kernel.org/all/3DF4A87A-2AC1-4893-AE5F-E921478419A9@suse.de/
Cc: stable@vger.kernel.org
Cc: Zheng Wang <zyytlz.wz@163.com>
Cc: Coly Li <colyli@suse.de>
Signed-off-by: Markus Weippert <markus@gekmihesg.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-12-08 08:44:26 +01:00
2023-12-08 08:44:26 +01:00
2022-01-27 09:19:46 +01:00
2020-03-25 08:25:48 +01:00
2021-03-09 11:09:37 +01:00
2023-01-18 11:41:46 +01:00
2023-08-11 11:53:53 +02:00
2023-03-11 16:43:58 +01:00
2020-04-17 10:50:24 +02:00
2020-04-17 10:50:23 +02:00
2023-05-17 11:35:56 +02:00
2021-03-04 10:26:51 +01:00
2023-04-05 11:16:41 +02:00
2023-12-08 08:44:25 +01:00
2019-08-21 11:27:17 -04:00
2022-06-29 08:58:45 +02:00
2019-05-16 15:55:48 -07:00
2023-05-17 11:35:56 +02:00
2019-07-15 11:03:01 -03:00
2023-08-30 16:27:22 +02:00
2023-06-09 10:29:01 +02:00
2023-06-09 10:29:01 +02:00
2019-08-15 15:57:39 -04:00
2019-07-11 20:04:37 -06:00
2019-07-09 14:13:33 -04:00
2022-06-29 08:58:45 +02:00
2020-09-09 19:12:35 +02:00
2019-08-26 11:05:32 -04:00
2023-08-11 11:53:49 +02:00
2021-05-11 14:04:18 +02:00
2019-03-05 14:48:50 -05:00
2023-06-09 10:29:01 +02:00
2021-06-03 08:59:02 +02:00
2023-04-05 11:16:41 +02:00
2023-04-05 11:16:41 +02:00
2019-03-05 14:48:51 -05:00
2023-06-09 10:29:01 +02:00
2019-04-25 15:38:52 -04:00
2023-01-18 11:41:47 +01:00
2019-12-21 11:05:01 +01:00
2023-04-05 11:16:40 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2018-12-18 09:02:26 -05:00
2023-12-08 08:44:26 +01:00
2021-04-21 12:56:15 +02:00
2023-12-08 08:44:26 +01:00
2021-06-16 11:59:37 +02:00
2019-08-23 10:13:14 -04:00
2023-12-08 08:44:26 +01:00
2022-08-25 11:18:14 +02:00
2020-06-24 17:50:31 +02:00
2020-06-24 17:50:31 +02:00
2020-07-09 09:37:57 +02:00
2019-12-17 19:56:12 +01:00
2023-04-05 11:16:41 +02:00
2021-03-11 14:06:49 +01:00
2021-01-27 11:47:42 +01:00
2019-09-12 09:32:31 -04:00
2023-09-23 10:59:45 +02:00
2020-12-30 11:51:45 +01:00
2019-05-24 17:27:13 +02:00
2019-12-17 19:56:14 +01:00
2019-12-17 19:56:14 +01:00
2023-07-27 08:37:41 +02:00
2019-12-17 19:56:14 +01:00
2023-07-27 08:37:37 +02:00
2023-07-27 08:37:37 +02:00
2019-06-15 01:37:35 -06:00
2023-09-23 11:00:06 +02:00
2019-06-05 17:36:37 +02:00
2019-03-12 10:15:18 -07:00
2019-06-05 17:36:37 +02:00
2023-06-09 10:29:01 +02:00
2019-09-13 13:14:43 -07:00
2023-07-27 08:37:41 +02:00
bb55decee2