iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv6
History
Eric Dumazet be1ab8bf05 ipv6: fix potential NULL deref in fib6_add() 
[ Upstream commit 75475bb51e78a3f54ad2f69380f2a1c985e85f2d ]

If fib6_find_prefix() returns NULL, we should silently fallback
using fib6_null_entry regardless of RT6_DEBUG value.

syzbot reported:

WARNING: CPU: 0 PID: 5477 at net/ipv6/ip6_fib.c:1516 fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Modules linked in:
CPU: 0 PID: 5477 Comm: syz-executor.0 Not tainted 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023
RIP: 0010:fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Code: 00 48 8b 54 24 68 e8 42 22 00 00 48 85 c0 74 14 49 89 c6 e8 d5 d3 c2 f7 eb 5d e8 ce d3 c2 f7 e9 ca 00 00 00 e8 c4 d3 c2 f7 90 <0f> 0b 90 48 b8 00 00 00 00 00 fc ff df 48 8b 4c 24 38 80 3c 01 00
RSP: 0018:ffffc90005067740 EFLAGS: 00010293
RAX: ffffffff89cba5bc RBX: ffffc90005067ab0 RCX: ffff88801a2e9dc0
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90005067980 R08: ffffffff89cbca85 R09: 1ffff110040d4b85
R10: dffffc0000000000 R11: ffffed10040d4b86 R12: 00000000ffffffff
R13: 1ffff110051c3904 R14: ffff8880206a5c00 R15: ffff888028e1c820
FS: 00007f763783c6c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f763783bff8 CR3: 000000007f74d000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__ip6_ins_rt net/ipv6/route.c:1303 [inline]
ip6_route_add+0x88/0x120 net/ipv6/route.c:3847
ipv6_route_ioctl+0x525/0x7b0 net/ipv6/route.c:4467
inet6_ioctl+0x21a/0x270 net/ipv6/af_inet6.c:575
sock_do_ioctl+0x152/0x460 net/socket.c:1220
sock_ioctl+0x615/0x8c0 net/socket.c:1339
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:871 [inline]
__se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82

Fixes: 7bbfe00e0252 ("ipv6: fix general protection fault in fib6_add()")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20231129160630.3509216-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-13 18:18:11 +01:00
..
ila
ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping()
2023-03-17 08:32:50 +01:00
netfilter
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
addrconf_core.c
net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
2019-12-18 16:08:42 +01:00
addrconf.c
net: ipv6/addrconf: avoid integer underflow in ipv6_create_tempaddr
2023-09-23 10:59:58 +02:00
addrlabel.c
ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network
2022-11-25 17:42:05 +01:00
af_inet6.c
dccp: Call inet6_destroy_sock() via sk->sk_destruct().
2023-04-26 11:24:05 +02:00
ah6.c
ah6: fix error return code in ah6_input()
2020-11-24 13:28:55 +01:00
anycast.c
ipv6: fix memory leaks on IPV6_ADDRFORM path
2020-08-11 15:33:39 +02:00
calipso.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2021-03-17 17:03:35 +01:00
datagram.c
ipv6: Fix datagram socket connection with DSCP.
2023-02-22 12:50:41 +01:00
esp6_offload.c
xfrm: Linearize the skb after offloading if needed.
2023-06-28 10:18:38 +02:00
esp6.c
net: ipv6: fix return value check in esp_remove_trailer
2023-10-25 11:53:21 +02:00
exthdrs_core.c
ipv6: Fix out-of-bounds access in ipv6_find_tlv()
2023-05-30 12:44:10 +01:00
exthdrs_offload.c
…
exthdrs.c
ipv6: fix out-of-bound access in ip6_parse_tlv()
2021-07-14 16:53:33 +02:00
fib6_notifier.c
…
fib6_rules.c
ipv6: fix memory leak in fib6_rule_suppress
2021-12-08 09:01:13 +01:00
fou6.c
…
icmp.c
icmp6: Fix null-ptr-deref of ip6_null_entry->rt6i_idev in icmp6_dev().
2023-07-27 08:37:31 +02:00
inet6_connection_sock.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 19:18:58 +01:00
inet6_hashtables.c
secure_seq: use the 64 bits of the siphash for port offset calculation
2022-06-06 08:33:49 +02:00
ip6_checksum.c
…
ip6_fib.c
ipv6: fix potential NULL deref in fib6_add()
2023-12-13 18:18:11 +01:00
ip6_flowlabel.c
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
ip6_gre.c
net:ipv6: check return value of pskb_trim()
2023-07-27 08:37:43 +02:00
ip6_icmp.c
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-03-04 10:26:53 +01:00
ip6_input.c
tcp/udp: Make early_demux back namespacified.
2022-11-10 17:57:55 +01:00
ip6_offload.c
gso: do not skip outer ip header in case of ipip and net_failover
2022-03-02 11:41:06 +01:00
ip6_offload.h
…
ip6_output.c
ipv6: avoid atomic fragment on GSO packets
2023-11-20 10:30:10 +01:00
ip6_tunnel.c
net: tunnels: annotate lockless accesses to dev->needed_headroom
2023-03-22 13:28:05 +01:00
ip6_udp_tunnel.c
…
ip6_vti.c
ip6_vti: fix slab-use-after-free in decode_session6
2023-08-30 16:27:16 +02:00
ip6mr.c
ip6mr: Fix skb_under_panic in ip6mr_cache_report()
2023-08-11 11:53:57 +02:00
ipcomp6.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
ipv6_sockglue.c
udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM).
2023-04-26 11:24:05 +02:00
Kconfig
net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC
2020-09-26 18:03:13 +02:00
Makefile
…
mcast_snoop.c
net: bridge: mcast: fix broken length + header check for MRDv6 Adv.
2021-05-14 09:44:32 +02:00
mcast.c
mld: fix panic in mld_newpack()
2021-06-03 08:59:14 +02:00
mip6.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
ndisc.c
ipv6: adjust ndisc_is_useropt() to also return true for PIO
2023-08-16 18:19:22 +02:00
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-11-18 19:20:17 +01:00
output_core.c
ipv6: use prandom_u32() for ID generation
2021-07-19 08:53:09 +02:00
ping.c
ping6: Fix send to link-local addresses with VRF.
2023-06-21 15:44:11 +02:00
proc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-06-07 11:00:14 -07:00
protocol.c
…
raw.c
ipv{4,6}/raw: fix output xfrm lookup wrt protocol
2023-06-05 08:17:33 +02:00
reassembly.c
ipv6: record frag_max_size in atomic fragments in input path
2021-06-03 08:59:15 +02:00
route.c
ipv6: Add lwtunnel encap size of all siblings in nexthop calculation
2023-03-11 16:44:11 +01:00
seg6_hmac.c
net: ipv6: unexport __init-annotated seg6_hmac_net_init()
2022-07-07 17:36:49 +02:00
seg6_iptunnel.c
seg6: fix skb checksum evaluation in SRH encapsulation/insertion
2022-07-21 20:59:23 +02:00
seg6_local.c
seg6: fix skb checksum in SRv6 End.B6 and End.B6.Encaps behaviors
2022-07-21 20:59:23 +02:00
seg6.c
ipv6: sr: fix out-of-bounds read when setting HMAC data.
2022-09-15 12:04:55 +02:00
sit.c
sit: update dev->needed_headroom in ipip6_tunnel_bind_dev()
2023-05-17 11:35:58 +02:00
syncookies.c
dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.
2023-11-20 10:30:15 +01:00
sysctl_net_ipv6.c
ipv6: Fix sysctl max for fib_multipath_hash_policy
2020-09-12 14:18:55 +02:00
tcp_ipv6.c
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
2023-04-26 11:24:05 +02:00
tcpv6_offload.c
…
tunnel6.c
…
udp_impl.h
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2023-04-26 11:24:05 +02:00
udp_offload.c
…
udp.c
udp6: fix udp6_ehashfn() typo
2023-07-27 08:37:31 +02:00
udplite.c
udplite: Fix NULL pointer dereference in __sk_mem_raise_allocated().
2023-05-30 12:44:09 +01:00
xfrm6_input.c
…
xfrm6_output.c
xfrm: fix tunnel model fragmentation behavior
2022-04-15 14:17:56 +02:00
xfrm6_policy.c
xfrm6: fix inet6_dev refcount underflow problem
2023-10-25 11:53:25 +02:00
xfrm6_protocol.c
…
xfrm6_state.c
xfrm: remove eth_proto value from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
xfrm6_tunnel.c
…