Jon Maxwell
584756c3d7
ipv6: remove max_size check inline with ipv4 ...
commit af6d10345ca76670c1b7c37799f0d5576ccef277 upstream.
In ip6_dst_gc() replace:
if (entries > gc_thresh)
With:
if (entries > ops->gc_thresh)
Sending Ipv6 packets in a loop via a raw socket triggers an issue where a
route is cloned by ip6_rt_cache_alloc() for each packet sent. This quickly
consumes the Ipv6 max_size threshold which defaults to 4096 resulting in
these warnings:
[1] 99.187805] dst_alloc: 7728 callbacks suppressed
[2] Route cache is full: consider increasing sysctl net.ipv6.route.max_size.
.
.
[300] Route cache is full: consider increasing sysctl net.ipv6.route.max_size.
When this happens the packet is dropped and sendto() gets a network is
unreachable error:
remaining pkt 200557 errno 101
remaining pkt 196462 errno 101
.
.
remaining pkt 126821 errno 101
Implement David Aherns suggestion to remove max_size check seeing that Ipv6
has a GC to manage memory usage. Ipv4 already does not check max_size.
Here are some memory comparisons for Ipv4 vs Ipv6 with the patch:
Test by running 5 instances of a program that sends UDP packets to a raw
socket 5000000 times. Compare Ipv4 and Ipv6 performance with a similar
program.
Ipv4:
Before test:
MemFree: 29427108 kB
Slab: 237612 kB
ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 2881 3990 192 42 2 : tunables 0 0 0
During test:
MemFree: 29417608 kB
Slab: 247712 kB
ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 44394 44394 192 42 2 : tunables 0 0 0
After test:
MemFree: 29422308 kB
Slab: 238104 kB
ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0
Ipv6 with patch:
Errno 101 errors are not observed anymore with the patch.
Before test:
MemFree: 29422308 kB
Slab: 238104 kB
ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0
During Test:
MemFree: 29431516 kB
Slab: 240940 kB
ip6_dst_cache 11980 12064 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0
After Test:
MemFree: 29441816 kB
Slab: 238132 kB
ip6_dst_cache 1902 2432 256 32 2 : tunables 0 0 0
xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0
ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0
Tested-by: Andrea Mayer <andrea.mayer@uniroma2.it>
Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20230112012532.311021-1-jmaxwell37@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Suraj Jitindar Singh <surajjs@amazon.com>
Cc: <stable@vger.kernel.org> # 5.4.x
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-15 18:25:29 +01:00
2019-05-30 11:29:21 -07:00
2023-10-25 11:53:25 +02:00
2021-06-10 13:37:09 +02:00
2023-11-28 16:50:23 +00:00
2024-01-15 18:25:29 +01:00
2023-07-27 08:37:07 +02:00
2019-06-05 17:37:07 +02:00
2023-03-11 16:44:11 +01:00
2022-05-18 09:47:25 +02:00
2021-03-04 10:26:53 +01:00
2023-12-20 15:41:13 +01:00
2019-05-30 11:26:41 -07:00
2020-09-09 19:12:23 +02:00
2019-02-28 08:24:23 -07:00
2019-06-05 17:37:05 +02:00
2022-04-15 14:18:33 +02:00
2022-04-20 09:19:39 +02:00
2019-06-19 17:09:55 +02:00
2022-02-23 11:59:58 +01:00
2023-06-14 10:59:58 +02:00
2019-07-04 12:30:48 -07:00
2023-08-30 16:27:24 +02:00
2019-08-17 23:18:54 +02:00
2022-09-05 10:27:42 +02:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2023-08-16 18:19:24 +02:00
2019-05-30 11:26:41 -07:00
2022-03-02 11:41:08 +01:00
2019-05-21 11:28:45 +02:00
2019-05-30 11:26:32 -07:00
2019-04-19 14:07:40 -07:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2019-11-09 19:38:36 -08:00
2020-05-27 17:46:24 +02:00
2019-09-16 21:32:57 +02:00
2022-02-16 12:52:51 +01:00
2024-01-15 18:25:29 +01:00
2023-06-21 15:44:12 +02:00
2022-07-12 16:30:45 +02:00
2019-06-19 17:09:55 +02:00
2019-04-22 21:50:53 -07:00
2021-12-08 09:01:13 +01:00
2022-04-20 09:19:34 +02:00
2019-12-18 16:08:47 +01:00
2023-11-20 10:30:15 +01:00
2019-11-08 09:11:49 +01:00
2019-10-23 20:13:22 -07:00
2023-12-13 18:18:17 +01:00
2019-03-22 12:09:31 -07:00
2018-12-10 15:53:04 -08:00
2019-07-01 10:58:23 -07:00
2019-10-25 16:24:32 -07:00
2021-03-04 10:26:53 +01:00
2019-02-22 12:56:24 -08:00
2022-10-26 13:22:59 +02:00
2023-12-20 15:41:13 +01:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-07-03 13:51:54 -07:00
2021-03-30 14:35:26 +02:00
2020-12-08 10:40:25 +01:00
2022-01-27 09:19:54 +01:00
2022-06-06 08:33:49 +02:00
2022-07-29 17:14:11 +02:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2019-05-30 11:26:32 -07:00
2022-02-01 17:24:38 +01:00
2021-08-12 13:20:57 +02:00
2023-05-30 12:44:05 +01:00
2021-12-08 09:01:12 +01:00
2023-09-23 10:59:59 +02:00
2020-08-19 08:16:10 +02:00
2023-06-05 08:17:33 +02:00
2022-01-27 09:19:54 +01:00
2021-12-01 09:23:33 +01:00
2023-08-11 11:53:47 +02:00
2020-02-11 04:35:48 -08:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2019-10-08 13:23:05 -07:00
2021-08-04 12:27:39 +02:00
2021-11-17 09:48:47 +01:00
2023-09-23 10:59:42 +02:00
2020-04-29 16:33:18 +02:00
2019-05-30 11:26:41 -07:00
2019-05-21 11:28:45 +02:00
2019-06-05 17:36:38 +02:00
2019-06-05 17:36:38 +02:00
2023-01-18 11:41:37 +01:00
2019-12-31 16:45:03 +01:00
2023-06-21 15:44:12 +02:00
2021-06-23 14:41:25 +02:00
2019-05-21 11:28:45 +02:00
2019-08-13 20:37:16 -07:00
2019-05-30 11:26:32 -07:00
2019-04-11 13:59:49 -07:00
2021-10-06 15:42:33 +02:00
2021-12-01 09:23:32 +01:00
2021-05-19 10:08:31 +02:00
2019-05-30 11:26:32 -07:00
2020-02-01 09:34:38 +00:00
2023-07-27 08:37:33 +02:00
2022-11-10 17:57:55 +01:00
2021-08-18 08:56:59 +02:00
2022-07-21 20:59:22 +02:00
2021-04-14 08:24:14 +02:00
2019-10-09 21:34:31 -07:00
2022-02-01 17:24:39 +01:00
2023-08-30 16:27:24 +02:00
2019-04-22 21:47:25 -07:00
2023-02-06 07:52:37 +01:00
2023-05-17 11:35:41 +02:00
2022-06-06 08:33:49 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-02-21 10:34:37 -08:00
2019-05-30 11:26:32 -07:00
2019-09-16 09:02:18 +02:00
2023-11-28 16:50:14 +00:00
2021-11-17 09:48:48 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2023-11-20 10:30:10 +01:00
2019-05-30 11:26:32 -07:00
2021-11-02 19:46:12 +01:00
2022-04-15 14:18:01 +02:00
2023-04-26 11:24:05 +02:00
2023-04-26 11:24:05 +02:00
2019-06-05 17:37:05 +02:00
2023-08-11 11:53:47 +02:00
2019-06-05 17:30:29 +02:00
2019-12-18 16:09:07 +01:00
2019-08-31 01:08:26 +02:00
2019-06-19 11:23:13 -04:00
2022-03-19 13:40:16 +01:00
584756c3d7