Vasiliy Kovalev
f8cbd17919
gtp: fix use-after-free and null-ptr-deref in gtp_genl_dump_pdp() ...
commit 136cfaca22567a03bbb3bf53a43d8cb5748b80ec upstream.
The gtp_net_ops pernet operations structure for the subsystem must be
registered before registering the generic netlink family.
Syzkaller hit 'general protection fault in gtp_genl_dump_pdp' bug:
general protection fault, probably for non-canonical address
0xdffffc0000000002: 0000 [#1 ] PREEMPT SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]
CPU: 1 PID: 5826 Comm: gtp Not tainted 6.8.0-rc3-std-def-alt1 #1
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-alt1 04/01/2014
RIP: 0010:gtp_genl_dump_pdp+0x1be/0x800 [gtp]
Code: c6 89 c6 e8 64 e9 86 df 58 45 85 f6 0f 85 4e 04 00 00 e8 c5 ee 86
df 48 8b 54 24 18 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80>
3c 02 00 0f 85 de 05 00 00 48 8b 44 24 18 4c 8b 30 4c 39 f0 74
RSP: 0018:ffff888014107220 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000002 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88800fcda588 R14: 0000000000000001 R15: 0000000000000000
FS: 00007f1be4eb05c0(0000) GS:ffff88806ce80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f1be4e766cf CR3: 000000000c33e000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
<TASK>
? show_regs+0x90/0xa0
? die_addr+0x50/0xd0
? exc_general_protection+0x148/0x220
? asm_exc_general_protection+0x22/0x30
? gtp_genl_dump_pdp+0x1be/0x800 [gtp]
? __alloc_skb+0x1dd/0x350
? __pfx___alloc_skb+0x10/0x10
genl_dumpit+0x11d/0x230
netlink_dump+0x5b9/0xce0
? lockdep_hardirqs_on_prepare+0x253/0x430
? __pfx_netlink_dump+0x10/0x10
? kasan_save_track+0x10/0x40
? __kasan_kmalloc+0x9b/0xa0
? genl_start+0x675/0x970
__netlink_dump_start+0x6fc/0x9f0
genl_family_rcv_msg_dumpit+0x1bb/0x2d0
? __pfx_genl_family_rcv_msg_dumpit+0x10/0x10
? genl_op_from_small+0x2a/0x440
? cap_capable+0x1d0/0x240
? __pfx_genl_start+0x10/0x10
? __pfx_genl_dumpit+0x10/0x10
? __pfx_genl_done+0x10/0x10
? security_capable+0x9d/0xe0
Cc: stable@vger.kernel.org
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
Link: https://lore.kernel.org/r/20240214162733.34214-1-kovalev@altlinux.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-03-01 13:13:36 +01:00
2023-12-13 18:18:12 +01:00
2024-02-23 08:25:05 +01:00
2022-07-07 17:36:49 +02:00
2023-11-20 10:30:09 +01:00
2024-01-25 14:34:32 -08:00
2024-02-23 08:25:15 +01:00
2023-01-18 11:41:13 +01:00
2024-02-23 08:24:51 +01:00
2023-01-18 11:41:35 +01:00
2022-05-09 09:03:27 +02:00
2023-12-13 18:18:12 +01:00
2023-11-08 11:23:35 +01:00
2023-11-28 16:50:16 +00:00
2022-08-25 11:17:49 +02:00
2024-01-25 14:34:32 -08:00
2022-12-14 11:30:48 +01:00
2024-02-23 08:25:07 +01:00
2022-04-20 09:19:37 +02:00
2023-12-20 15:41:25 +01:00
2024-01-15 18:25:27 +01:00
2022-05-25 09:14:35 +02:00
2024-02-23 08:25:04 +01:00
2024-02-23 08:24:59 +01:00
2024-02-23 08:25:11 +01:00
2022-08-25 11:18:24 +02:00
2024-03-01 13:13:36 +01:00
2023-01-18 11:40:49 +01:00
2023-11-20 10:30:10 +01:00
2023-11-28 16:50:17 +00:00
2022-04-15 14:18:34 +02:00
2023-04-05 11:16:44 +02:00
2023-01-18 11:41:16 +01:00
2022-08-03 11:59:39 +02:00
2023-08-11 11:53:59 +02:00
2023-10-10 21:46:41 +02:00
2023-10-25 11:53:21 +02:00
2023-09-23 10:59:58 +02:00
2024-02-23 08:25:03 +01:00
2023-09-23 10:59:38 +02:00
2022-12-14 11:30:45 +01:00
f8cbd17919