iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/cifs
History
Paulo Alcantara 508e2fdd97 smb: client: fix OOB in smbCalcSize() 
[ Upstream commit b35858b3786ddbb56e1c35138ba25d6adf8d0bef ]

Validate @smb->WordCount to avoid reading off the end of @smb and thus
causing the following KASAN splat:

  BUG: KASAN: slab-out-of-bounds in smbCalcSize+0x32/0x40 [cifs]
  Read of size 2 at addr ffff88801c024ec5 by task cifsd/1328

  CPU: 1 PID: 1328 Comm: cifsd Not tainted 6.7.0-rc5 #9
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS
  rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014
  Call Trace:
   <TASK>
   dump_stack_lvl+0x4a/0x80
   print_report+0xcf/0x650
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? __phys_addr+0x46/0x90
   kasan_report+0xd8/0x110
   ? smbCalcSize+0x32/0x40 [cifs]
   ? smbCalcSize+0x32/0x40 [cifs]
   kasan_check_range+0x105/0x1b0
   smbCalcSize+0x32/0x40 [cifs]
   checkSMB+0x162/0x370 [cifs]
   ? __pfx_checkSMB+0x10/0x10 [cifs]
   cifs_handle_standard+0xbc/0x2f0 [cifs]
   ? srso_alias_return_thunk+0x5/0xfbef5
   cifs_demultiplex_thread+0xed1/0x1360 [cifs]
   ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? lockdep_hardirqs_on_prepare+0x136/0x210
   ? __pfx_lock_release+0x10/0x10
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? mark_held_locks+0x1a/0x90
   ? lockdep_hardirqs_on_prepare+0x136/0x210
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? srso_alias_return_thunk+0x5/0xfbef5
   ? __kthread_parkme+0xce/0xf0
   ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
   kthread+0x18d/0x1d0
   ? kthread+0xdb/0x1d0
   ? __pfx_kthread+0x10/0x10
   ret_from_fork+0x34/0x60
   ? __pfx_kthread+0x10/0x10
   ret_from_fork_asm+0x1b/0x30
   </TASK>

This fixes CVE-2023-6606.

Reported-by: j51569436@gmail.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218218
Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-08 11:29:47 +01:00
..
asn1.c
cifs: remove bogus debug code
2020-10-29 09:57:28 +01:00
cache.c
…
cifs_debug.c
cifs: Don't display RDMA transport on reconnect
2019-12-21 11:04:43 +01:00
cifs_debug.h
cifs: add a debug macro that prints \\server\share for errors
2019-09-16 11:43:38 -05:00
cifs_dfs_ref.c
cifs: prevent NULL deref in cifs_compose_mount_options()
2021-07-25 14:35:13 +02:00
cifs_fs_sb.h
smb3: add mount option to allow RW caching of share accessed by only 1 client
2019-09-16 11:43:38 -05:00
cifs_ioctl.h
smb3: allow decryption keys to be dumped by admin for debugging
2019-09-21 06:02:26 -05:00
cifs_spnego.c
cifs: spnego: add ';' in HOST_KEY_LEN
2023-11-28 16:50:17 +00:00
cifs_spnego.h
…
cifs_unicode.c
CIFS: Fix a potencially linear read overflow
2021-09-15 09:47:36 +02:00
cifs_unicode.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
cifs_uniupr.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
cifsacl.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
cifsacl.h
smb3: missing ACL related flags
2019-09-26 16:37:43 -05:00
cifsencrypt.c
fs: cifs: switch to RC4 library interface
2019-06-20 14:19:55 +08:00
cifsfs.c
cifs: Fix non-availability of dedup breaking generic/304
2023-12-13 18:18:17 +01:00
cifsfs.h
cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL
2023-04-05 11:16:45 +02:00
cifsglob.h
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
cifspdu.h
…
cifsproto.h
smb3: fix problem with null cifs super block with previous patch
2023-04-20 12:07:32 +02:00
cifsroot.c
cifs: cifsroot: add more err checking
2019-09-16 11:43:39 -05:00
cifssmb.c
cifs: prevent infinite recursion in CIFSGetDFSRefer()
2023-04-05 11:16:45 +02:00
connect.c
cifs: handle empty list of targets in cifs_reconnect()
2023-06-14 10:59:59 +02:00
dfs_cache.c
cifs: Fix potential deadlock when updating vol in cifs_reconnect()
2023-06-28 10:18:37 +02:00
dfs_cache.h
…
dir.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
dns_resolve.c
keys: Pass the network namespace into request_key mechanism
2019-06-27 23:02:12 +01:00
dns_resolve.h
…
export.c
docs: fs: convert docs without extension to ReST
2019-07-31 13:31:05 -06:00
file.c
cifs: Release folio lock on fscache read hit.
2023-08-30 16:27:19 +02:00
fscache.c
…
fscache.h
…
inode.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
ioctl.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
Kconfig
various cifs/smb3 fixes (including for share deleted cases) and features including improved encrypted read performance, and various debugging improvements
2019-09-19 10:32:16 -07:00
link.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
Makefile
cifs: Add support for root file systems
2019-09-16 11:43:38 -05:00
misc.c
smb: client: fix OOB in smbCalcSize()
2024-01-08 11:29:47 +01:00
netmisc.c
fs: cifs: mute -Wunused-const-variable message
2019-10-06 22:04:35 -05:00
nterr.c
…
nterr.h
…
ntlmssp.h
…
readdir.c
…
rfc1002pdu.h
…
sess.c
cifs: fix wrong release in sess_alloc_buffer() failed path
2021-09-22 12:26:35 +02:00
smb1ops.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
smb2file.c
cifs: Adjust indentation in smb2_open_file
2020-01-17 19:48:27 +01:00
smb2glob.h
…
smb2inode.c
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
smb2maperror.c
smb3: improve handling of share deleted (and share recreated)
2019-09-16 11:43:38 -05:00
smb2misc.c
smb: client: fix NULL deref in asn1_ber_decoder()
2024-01-08 11:29:45 +01:00
smb2ops.c
smb: client: fix potential NULL deref in parse_dfs_referrals()
2023-12-13 18:18:17 +01:00
smb2pdu.c
cifs: do not include page data when checking signature
2023-01-24 07:18:00 +01:00
smb2pdu.h
ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
2024-01-08 11:29:42 +01:00
smb2proto.h
SMB3: Backup intent flag missing from some more ops
2023-03-17 08:32:50 +01:00
smb2status.h
…
smb2transport.c
CIFS: Fix task struct use-after-free on reconnect
2020-02-01 09:34:37 +00:00
smbdirect.c
smbdirect: missing rc checks while waiting for rdma events
2023-11-08 11:23:38 +01:00
smbdirect.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
smbencrypt.c
fs: cifs: move from the crypto cipher API to the new DES library interface
2019-08-22 14:57:34 +10:00
smberr.h
…
smbfsctl.h
smb3: Add missing reparse tags
2019-09-24 23:31:32 -05:00
trace.c
…
trace.h
smb3: add missing worker function for SMB3 change notify
2019-09-16 11:43:39 -05:00
transport.c
cifs: Move the in_send statistic to __smb_send_rqst()
2023-03-22 13:28:03 +01:00
winucase.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
xattr.c
CIFS: fix max ea value size
2019-09-23 23:28:59 -05:00