iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/ext4
History
Ritesh Harjani 8c472abaed ext4: check for non-zero journal inum in ext4_calculate_overhead 
commit f1eec3b0d0a849996ebee733b053efa71803dad5 upstream.

While calculating overhead for internal journal, also check
that j_inum shouldn't be 0. Otherwise we get below error with
xfstests generic/050 with external journal (XXX_LOGDEV config) enabled.

It could be simply reproduced with loop device with an external journal
and marking blockdev as RO before mounting.

[ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
CPU: 107 PID: 115347 Comm: mount Tainted: G             L   --------- -t - 4.18.0-167.el8.ppc64le #1
NIP:  c0000000006f6d44 LR: c0000000006f6d40 CTR: 0000000030041dd4
<...>
NIP [c0000000006f6d44] generic_make_request_checks+0x6b4/0x7d0
LR [c0000000006f6d40] generic_make_request_checks+0x6b0/0x7d0
<...>
Call Trace:
generic_make_request_checks+0x6b0/0x7d0 (unreliable)
generic_make_request+0x3c/0x420
submit_bio+0xd8/0x200
submit_bh_wbc+0x1e8/0x250
__sync_dirty_buffer+0xd0/0x210
ext4_commit_super+0x310/0x420 [ext4]
__ext4_error+0xa4/0x1e0 [ext4]
__ext4_iget+0x388/0xe10 [ext4]
ext4_get_journal_inode+0x40/0x150 [ext4]
ext4_calculate_overhead+0x5a8/0x610 [ext4]
ext4_fill_super+0x3188/0x3260 [ext4]
mount_bdev+0x778/0x8f0
ext4_mount+0x28/0x50 [ext4]
mount_fs+0x74/0x230
vfs_kern_mount.part.6+0x6c/0x250
do_mount+0x2fc/0x1280
sys_mount+0x158/0x180
system_call+0x5c/0x70
EXT4-fs (pmem1p2): no journal found
EXT4-fs (pmem1p2): can't get journal size
EXT4-fs (pmem1p2): mounted filesystem without journal. Opts: dax,norecovery

Fixes: 3c816ded78bb ("ext4: use journal inode to determine journal overhead")
Reported-by: Harish Sriram <harish@linux.ibm.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200316093038.25485-1-riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-02 08:49:01 +02:00
..
acl.c
ext4: compare old and new mode before setting update_mode flag
2018-12-10 00:22:38 -05:00
acl.h
ext4: fix up remaining files with SPDX cleanups
2017-12-17 22:00:59 -05:00
balloc.c
ext4: fix potential race between online resizing and write operations
2020-02-28 17:22:22 +01:00
bitmap.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
block_validity.c
ext4: add cond_resched() to ext4_protect_reserved_inode
2020-02-19 19:52:59 +01:00
dir.c
ext4: fix checksum errors with indexed dirs
2020-02-19 19:52:59 +01:00
ext4_extents.h
ext4: adjust reserved cluster count when removing extents
2018-10-01 14:25:08 -04:00
ext4_jbd2.c
ext4: shutdown should not prevent get_write_access
2018-02-18 22:07:36 -05:00
ext4_jbd2.h
ext4: use jbd2_inode dirty range scoping
2019-06-20 17:26:26 -04:00
ext4.h
ext4: fix race between writepages and enabling EXT4_EXTENTS_FL
2020-02-28 17:22:23 +01:00
extents_status.c
ext4: use percpu_counters for extent_status cache hits/misses
2019-08-28 11:19:23 -04:00
extents_status.h
ext4: use percpu_counters for extent_status cache hits/misses
2019-08-28 11:19:23 -04:00
extents.c
ext4: fix extent_status fragmentation for plain files
2020-04-29 16:32:55 +02:00
file.c
ext4: fix ext4_dax_read/write inode locking sequence for IOCB_NOWAIT
2020-02-24 08:36:24 +01:00
fsmap.c
ext4: fix miscellaneous sparse warnings
2019-05-12 04:49:47 -04:00
fsmap.h
ext4: fix up remaining files with SPDX cleanups
2017-12-17 22:00:59 -05:00
fsync.c
Revert "ext4: use ext4_write_inode() when fsyncing w/o a journal"
2019-01-31 23:41:11 -05:00
hash.c
ext4: fix kernel oops caused by spurious casefold flag
2019-09-03 01:43:17 -04:00
ialloc.c
ext4: increase wait time needed before reuse of deleted inode numbers
2020-05-02 08:48:59 +02:00
indirect.c
ext4: clean up kerneldoc warnigns when building with W=1
2019-06-19 16:30:03 -04:00
inline.c
ext4: set error return correctly when ext4_htree_store_dirent fails
2019-08-12 14:29:38 -04:00
inode.c
ext4: use matching invalidatepage in ext4_writepage
2020-05-02 08:48:58 +02:00
ioctl.c
Added new ext4 debugging ioctls to allow userspace to get information
2019-09-21 13:37:39 -07:00
Kconfig
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
Makefile
ext4: add basic fs-verity support
2019-08-12 19:33:50 -07:00
mballoc.c
ext4: convert BUG_ON's to WARN_ON's in mballoc.c
2020-05-02 08:48:59 +02:00
mballoc.h
ext4: fix up remaining files with SPDX cleanups
2017-12-17 22:00:59 -05:00
migrate.c
ext4: fix race between writepages and enabling EXT4_EXTENTS_FL
2020-02-28 17:22:23 +01:00
mmp.c
ext4: don't assume that mmp_nodename/bdevname have NUL
2020-02-19 19:52:58 +01:00
move_extent.c
ext4: use jbd2_inode dirty range scoping
2019-06-20 17:26:26 -04:00
namei.c
ext4: add cond_resched() to __ext4_find_entry()
2020-02-28 17:22:22 +01:00
page-io.c
ext4: fix deadlock allocating crypto bounce page from mempool
2020-02-11 04:35:32 -08:00
readpage.c
ext4: fix deadlock allocating bio_post_read_ctx from mempool
2020-02-24 08:36:29 +01:00
resize.c
ext4: fix potential race between s_flex_groups online resizing and access
2020-02-28 17:22:22 +01:00
super.c
ext4: check for non-zero journal inum in ext4_calculate_overhead
2020-05-02 08:49:01 +02:00
symlink.c
ext4: switch to fscrypt_get_symlink()
2018-01-11 22:10:40 -05:00
sysfs.c
ext4: add basic fs-verity support
2019-08-12 19:33:50 -07:00
truncate.h
ext4: handle layout changes to pinned DAX mappings
2018-07-29 17:00:22 -04:00
verity.c
ext4: add basic fs-verity support
2019-08-12 19:33:50 -07:00
xattr_security.c
ext4: use XATTR_CREATE in ext4_initxattrs()
2018-05-10 11:52:14 -04:00
xattr_trusted.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xattr_user.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xattr.c
ext4: ignore e_value_offs for xattrs with value-in-ea-inode
2019-04-10 00:37:36 -04:00
xattr.h
ext4: add extra checks to ext4_xattr_block_get()
2018-03-30 20:04:11 -04:00