linux

iv/linux

History

Xiyu Yang 870a45e0b5 apparmor: Fix aa_label refcnt leak in policy_update

commit c6b39f070722ea9963ffe756bfe94e89218c5e63 upstream.

policy_update() invokes begin_current_label_crit_section(), which
returns a reference of the updated aa_label object to "label" with
increased refcount.

When policy_update() returns, "label" becomes invalid, so the refcount
should be decreased to keep refcount balanced.

The reference counting issue happens in one exception handling path of
policy_update(). When aa_may_manage_policy() returns not NULL, the
refcnt increased by begin_current_label_crit_section() is not decreased,
causing a refcnt leak.

Fix this issue by jumping to "end_section" label when
aa_may_manage_policy() returns not NULL.

Fixes: 5ac8c355ae00 ("apparmor: allow introspecting the loaded policy pre internal transform")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-05-27 17:46:42 +02:00

apparmor

apparmor: Fix aa_label refcnt leak in policy_update

2020-05-27 17:46:42 +02:00

integrity

evm: Fix a small race in init_desc()

2020-05-27 17:46:17 +02:00

keys

KEYS: Avoid false positive ENOMEM error on key read

2020-04-29 16:33:11 +02:00

loadpin

proc/sysctl: add shared variables for range check