Michał Mirosław
eeb0cf8bb6
Bluetooth: hci_bcm: fix freeing not-requested IRQ
...
commit 81bd5d0c62437c02caac6b3f942fcda874063cb0 upstream.
When BT module can't be initialized, but it has an IRQ, unloading
the driver WARNs when trying to free not-yet-requested IRQ. Fix it by
noting whether the IRQ was requested.
WARNING: CPU: 2 PID: 214 at kernel/irq/devres.c:144 devm_free_irq+0x49/0x4ca
[...]
WARNING: CPU: 2 PID: 214 at kernel/irq/manage.c:1746 __free_irq+0x8b/0x27c
Trying to free already-free IRQ 264
Modules linked in: hci_uart(-) btbcm bluetooth ecdh_generic ecc libaes
CPU: 2 PID: 214 Comm: rmmod Tainted: G W 5.6.1mq-00044-ga5f9ea098318-dirty #928
[...]
[<b016aefb>] (devm_free_irq) from [<af8ba1ff>] (bcm_close+0x97/0x118 [hci_uart])
[<af8ba1ff>] (bcm_close [hci_uart]) from [<af8b736f>] (hci_uart_unregister_device+0x33/0x3c [hci_uart])
[<af8b736f>] (hci_uart_unregister_device [hci_uart]) from [<b035930b>] (serdev_drv_remove+0x13/0x20)
[<b035930b>] (serdev_drv_remove) from [<b037093b>] (device_release_driver_internal+0x97/0x118)
[<b037093b>] (device_release_driver_internal) from [<b0370a0b>] (driver_detach+0x2f/0x58)
[<b0370a0b>] (driver_detach) from [<b036f855>] (bus_remove_driver+0x41/0x94)
[<b036f855>] (bus_remove_driver) from [<af8ba8db>] (bcm_deinit+0x1b/0x740 [hci_uart])
[<af8ba8db>] (bcm_deinit [hci_uart]) from [<af8ba86f>] (hci_uart_exit+0x13/0x30 [hci_uart])
[<af8ba86f>] (hci_uart_exit [hci_uart]) from [<b01900bd>] (sys_delete_module+0x109/0x1d0)
[<b01900bd>] (sys_delete_module) from [<b0101001>] (ret_fast_syscall+0x1/0x5a)
[...]
Cc: stable@vger.kernel.org
Fixes: 6cc4396c8829 ("Bluetooth: hci_bcm: Add wake-up capability")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-22 09:31:18 +02:00
..
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2018-07-23 18:05:00 +02:00
2019-09-04 16:11:46 +02:00
2018-09-27 12:57:39 +02:00
2020-06-22 09:30:59 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2018-05-30 08:16:05 +02:00
2019-01-22 09:51:20 +01:00
2018-05-29 15:59:50 +02:00
2019-04-23 19:01:45 +02:00
2016-05-02 19:26:15 +02:00
2019-04-23 18:36:20 +02:00
2020-06-22 09:30:56 +02:00
2019-09-05 17:27:22 +02:00
2019-08-12 18:23:50 +02:00
2019-06-05 17:36:37 +02:00
2018-09-27 12:53:40 +02:00
2019-09-05 17:27:32 +02:00
2019-07-06 12:32:50 +02:00
2019-07-06 12:27:55 +02:00
2020-02-11 04:35:09 -08:00
2019-06-05 17:37:06 +02:00
2017-06-16 11:48:40 -04:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-07-31 13:17:33 -07:00
2020-06-22 09:31:18 +02:00
2019-11-29 10:09:39 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-07-31 13:17:33 -07:00
2019-07-31 13:17:33 -07:00
2019-11-29 10:09:43 +01:00
2019-07-31 13:17:33 -07:00
2019-05-30 11:26:37 -07:00
2019-09-15 14:17:27 +02:00
2019-05-30 11:26:37 -07:00
2019-07-31 13:17:33 -07:00
2019-05-30 11:26:35 -07:00
2019-07-06 21:44:25 +02:00
2019-04-23 18:09:07 +02:00