iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Eric Dumazet 8c9df6ced1 tipc: block BH before using dst_cache 
[ Upstream commit 1378817486d6860f6a927f573491afe65287abf1 ]

dst_cache_get() documents it must be used with BH disabled.

sysbot reported :

BUG: using smp_processor_id() in preemptible [00000000] code: /21697
caller is dst_cache_get+0x3a/0xb0 net/core/dst_cache.c:68
CPU: 0 PID: 21697 Comm:  Not tainted 5.7.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 check_preemption_disabled lib/smp_processor_id.c:47 [inline]
 debug_smp_processor_id.cold+0x88/0x9b lib/smp_processor_id.c:57
 dst_cache_get+0x3a/0xb0 net/core/dst_cache.c:68
 tipc_udp_xmit.isra.0+0xb9/0xad0 net/tipc/udp_media.c:164
 tipc_udp_send_msg+0x3e6/0x490 net/tipc/udp_media.c:244
 tipc_bearer_xmit_skb+0x1de/0x3f0 net/tipc/bearer.c:526
 tipc_enable_bearer+0xb2f/0xd60 net/tipc/bearer.c:331
 __tipc_nl_bearer_enable+0x2bf/0x390 net/tipc/bearer.c:995
 tipc_nl_bearer_enable+0x1e/0x30 net/tipc/bearer.c:1003
 genl_family_rcv_msg_doit net/netlink/genetlink.c:673 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:718 [inline]
 genl_rcv_msg+0x627/0xdf0 net/netlink/genetlink.c:735
 netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:746
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
 ___sys_sendmsg+0x100/0x170 net/socket.c:2416
 __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45ca29

Fixes: e9c1a793210f ("tipc: add dst_cache support for udp media")
Cc: Xin Long <lucien.xin@gmail.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-03 08:21:03 +02:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-11 21:40:04 -07:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
tipc: fix potential hanging after b/rcast changing
2020-01-23 08:22:44 +01:00
bcast.h
tipc: fix a null pointer deref
2019-03-21 09:56:55 -07:00
bearer.c
tipc: add loopback device tracking
2019-08-08 22:11:39 -07:00
bearer.h
tipc: add loopback device tracking
2019-08-08 22:11:39 -07:00
core.c
tipc: fix ordering of tipc module init and exit routine
2019-12-18 16:08:36 +01:00
core.h
tipc: add back tipc prefix to log messages
2019-11-14 18:03:03 -08:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
…
group.c
tipc: clean up skb list lock handling on send path
2019-08-18 14:01:07 -07:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
…
Kconfig
docs: kbuild: convert docs to ReST and rename to *.rst
2019-06-14 14:21:21 -06:00
link.c
tipc: reduce sensitive to retransmit failures
2020-01-26 10:01:00 +01:00
link.h
tipc: fix missing Name entries due to half-failover
2019-05-04 00:59:51 -04:00
Makefile
tipc: enable tracepoints in tipc
2018-12-19 11:49:24 -08:00
monitor.c
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
monitor.h
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
msg.c
tipc: fix unlimited bundling of small messages
2019-10-02 11:02:05 -04:00
msg.h
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-08-19 11:54:03 -07:00
name_distr.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-09-15 14:17:27 +02:00
name_distr.h
tipc: permit overlapping service ranges in name table
2018-03-31 22:19:52 -04:00
name_table.c
netlink: make nla_nest_start() add NLA_F_NESTED flag
2019-04-27 17:03:44 -04:00
name_table.h
tipc: eliminate message disordering during binding table update
2018-10-22 19:29:12 -07:00
net.c
tipc: update mon's self addr when node addr generated
2020-01-26 10:01:00 +01:00
net.h
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
netlink_compat.c
tipc: fix link name length check
2019-12-04 22:31:03 +01:00
netlink.c
tipc: add missing attribute validation for MTU property
2020-03-18 07:17:45 +01:00
netlink.h
…
node.c
tipc: clean up skb list lock handling on send path
2019-08-18 14:01:07 -07:00
node.h
tipc: optimize link synching mechanism
2019-07-25 15:55:47 -07:00
socket.c
tipc: fix wrong timeout input for tipc_wait_for_cond()
2020-01-26 10:01:00 +01:00
socket.h
tipc: add trace_events for tipc socket
2018-12-19 11:49:24 -08:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix modprobe tipc failed after switch order of device registration
2019-05-20 10:45:43 -07:00
sysctl.c
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
topsrv.c
tipc: fix partial topology connection closure
2020-05-14 07:58:22 +02:00
topsrv.h
tipc: rename tipc_server to tipc_topsrv
2018-02-16 15:26:34 -05:00
trace.c
tipc: remove unneeded semicolon in trace.c
2019-01-17 22:04:43 -08:00
trace.h
tipc: add trace_events for tipc bearer
2018-12-19 11:49:25 -08:00
udp_media.c
tipc: block BH before using dst_cache
2020-06-03 08:21:03 +02:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00