iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/edac
History
Borislav Petkov b11f2d6b80 EDAC/ghes: Check whether the driver is on the safe list correctly 
[ Upstream commit 251c54ea26fa6029b01a76161a37a12fde5124e4 ]

With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y, a system would try to probe,
unregister and probe again a driver.

When ghes_edac is attempted to be loaded on a system which is not on
the safe platforms list, ghes_edac_register() would return early. The
unregister counterpart ghes_edac_unregister() would still attempt to
unregister and exit early at the refcount test, leading to the refcount
underflow below.

In order to not do *anything* on the unregister path too, reuse the
force_load parameter and check it on that path too, before fumbling with
the refcount.

  ghes_edac: ghes_edac_register: entry
  ghes_edac: ghes_edac_register: return -ENODEV
  ------------[ cut here ]------------
  refcount_t: underflow; use-after-free.
  WARNING: CPU: 10 PID: 1 at lib/refcount.c:28 refcount_warn_saturate+0xb9/0x100
  Modules linked in:
  CPU: 10 PID: 1 Comm: swapper/0 Not tainted 5.9.0-rc4+ #12
  Hardware name: GIGABYTE MZ01-CE1-00/MZ01-CE1-00, BIOS F02 08/29/2018
  RIP: 0010:refcount_warn_saturate+0xb9/0x100
  Code: 82 e8 fb 8f 4d 00 90 0f 0b 90 90 c3 80 3d 55 4c f5 00 00 75 88 c6 05 4c 4c f5 00 01 90 48 c7 c7 d0 8a 10 82 e8 d8 8f 4d 00 90 <0f> 0b 90 90 c3 80 3d 30 4c f5 00 00 0f 85 61 ff ff ff c6 05 23 4c
  RSP: 0018:ffffc90000037d58 EFLAGS: 00010292
  RAX: 0000000000000026 RBX: ffff88840b8da000 RCX: 0000000000000000
  RDX: 0000000000000001 RSI: ffffffff8216b24f RDI: 00000000ffffffff
  RBP: ffff88840c662e00 R08: 0000000000000001 R09: 0000000000000001
  R10: 0000000000000001 R11: 0000000000000046 R12: 0000000000000000
  R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000
  FS:  0000000000000000(0000) GS:ffff88840ee80000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 0000000000000000 CR3: 0000800002211000 CR4: 00000000003506e0
  Call Trace:
   ghes_edac_unregister
   ghes_remove
   platform_drv_remove
   really_probe
   driver_probe_device
   device_driver_attach
   __driver_attach
   ? device_driver_attach
   ? device_driver_attach
   bus_for_each_dev
   bus_add_driver
   driver_register
   ? bert_init
   ghes_init
   do_one_initcall
   ? rcu_read_lock_sched_held
   kernel_init_freeable
   ? rest_init
   kernel_init
   ret_from_fork
   ...
  ghes_edac: ghes_edac_unregister: FALSE, refcount: -1073741824

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200911164950.GB19320@zn.tnic
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-10-01 13:18:14 +02:00
..
altera_edac.c
EDAC/altera: Use fast register IO for S10 IRQs
2019-12-17 19:55:51 +01:00
altera_edac.h
edac: altera: Move Stratix10 SDRAM ECC to peripheral
2019-07-25 14:28:42 -04:00
amd64_edac_dbg.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
amd64_edac_inj.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
amd64_edac.c
EDAC/amd64: Read back the scrub rate PCI register on F15h
2020-07-09 09:37:49 +02:00
amd64_edac.h
EDAC/amd64: Add AMD family 17h model 60h PCI IDs
2020-06-22 09:31:20 +02:00
amd76x_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
amd8111_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
amd8111_edac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
amd8131_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
amd8131_edac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
armada_xp_edac.c
ARM: 8891/1: EDAC: armada_xp: Add support for more SoCs
2019-08-29 07:58:01 +01:00
aspeed_edac.c
EDAC/aspeed: Remove set but not used variable 'np'
2019-06-20 11:44:36 -07:00
bluefield_edac.c
EDAC, mellanox: Add ECC support for BlueField DDR4
2019-08-08 12:57:01 -03:00
cell_edac.c
edac: rename edac_core.h to edac_mc.h
2016-12-15 08:54:51 -02:00
cpc925_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
debugfs.c
ARM: 8892/1: EDAC: Add missing debugfs_create_x32 wrapper
2019-08-29 07:58:01 +01:00
e7xxx_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
e752x_edac.c
EDAC: Fix indentation issues in several EDAC drivers
2018-11-10 16:56:16 +01:00
edac_device_sysfs.c
EDAC: Fix reference count leaks
2020-08-19 08:15:54 +02:00
edac_device.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
edac_device.h
edac: move documentation from edac_device to edac_core.h
2016-12-15 08:54:51 -02:00
edac_mc_sysfs.c
EDAC/mc: Fix use-after-free and memleaks during device removal
2020-02-19 19:53:03 +01:00
edac_mc.c
EDAC/mc: Fix use-after-free and memleaks during device removal
2020-02-19 19:53:03 +01:00
edac_mc.h
EDAC: Prefer 'unsigned int' to bare use of 'unsigned'
2019-09-03 19:21:19 +02:00
edac_module.c
treewide: Fix function prototypes for module_param_call()
2017-10-31 15:30:37 +01:00
edac_module.h
ARM: 8892/1: EDAC: Add missing debugfs_create_x32 wrapper
2019-08-29 07:58:01 +01:00
edac_pci_sysfs.c
EDAC: Fix reference count leaks
2020-08-19 08:15:54 +02:00
edac_pci.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
edac_pci.h
edac: move documentation from edac_pci*.c to edac_pci.h
2016-12-15 08:54:51 -02:00
fsl_ddr_edac.c
EDAC, fsl_ddr: Add LS1021A to the list of supported hardware
2018-12-19 11:57:45 +01:00
fsl_ddr_edac.h
EDAC, fsl_ddr: Add LS1021A to the list of supported hardware
2018-12-19 11:57:45 +01:00
ghes_edac.c
EDAC/ghes: Check whether the driver is on the safe list correctly
2020-10-01 13:18:14 +02:00
highbank_l2_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
highbank_mc_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
i7core_edac.c
EDAC/{i7core,sb,pnd2,skx}: Fix error event severity
2020-09-03 11:26:53 +02:00
i10nm_base.c
EDAC/skx: Use the mcmtr register to retrieve close_pg/bank_xor_enable
2020-06-17 16:40:33 +02:00
i3000_edac.c
EDAC: Fix indentation issues in several EDAC drivers
2018-11-10 16:56:16 +01:00
i3200_edac.c
EDAC: Correct DIMM capacity unit symbol
2018-09-22 18:18:57 +02:00
i5000_edac.c
EDAC, i5000: Remove set but not used local variables
2018-12-11 14:53:49 +01:00
i5100_edac.c
EDAC: Prefer 'unsigned int' to bare use of 'unsigned'
2019-09-03 19:21:19 +02:00
i5400_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
i7300_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 172
2019-05-30 11:26:39 -07:00
i82443bxgx_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
i82860_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
i82875p_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
i82975x_edac.c
EDAC, i82975x: Fix spelling mistake "reserverd" -> "reserved"
2018-11-20 17:46:01 +01:00
ie31200_edac.c
EDAC/ie31200: Fallback if host bridge device is already initialized
2020-09-03 11:26:48 +02:00
Kconfig
ARM updates for 5.4-rc1:
2019-09-22 09:39:09 -07:00
layerscape_edac.c
edac: rename edac_core.h to edac_mc.h
2016-12-15 08:54:51 -02:00
Makefile
ARM updates for 5.4-rc1:
2019-09-22 09:39:09 -07:00
mce_amd.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
mce_amd.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mpc85xx_edac.c
EDAC, mpc85xx: Add T2080 l2-cache support
2017-02-03 10:36:35 +01:00
mpc85xx_edac.h
EDAC, fsl-ddr: Separate FSL DDR driver from MPC85xx
2016-09-01 10:28:00 +02:00
mv64x60_edac.c
EDAC, mv64x60: Fix an error handling path
2018-01-09 20:14:23 +01:00
mv64x60_edac.h
…
octeon_edac-l2c.c
edac: rename edac_core.h to edac_mc.h
2016-12-15 08:54:51 -02:00
octeon_edac-lmc.c
EDAC, octeon: Fix an uninitialized variable warning
2017-11-27 11:57:26 +01:00
octeon_edac-pc.c
edac: rename edac_core.h to edac_mc.h
2016-12-15 08:54:51 -02:00
octeon_edac-pci.c
edac: rename edac_core.h to edac_mc.h
2016-12-15 08:54:51 -02:00
pasemi_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
pnd2_edac.c
EDAC/{i7core,sb,pnd2,skx}: Fix error event severity
2020-09-03 11:26:53 +02:00
pnd2_edac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
ppc4xx_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
ppc4xx_edac.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
qcom_edac.c
EDAC, qcom_edac: Remove irq_handled local variable
2018-11-06 12:03:16 +01:00
r82600_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
sb_edac.c
EDAC/{i7core,sb,pnd2,skx}: Fix error event severity
2020-09-03 11:26:53 +02:00
sifive_edac.c
EDAC/sifive: Fix return value check in ecc_register()
2020-02-24 08:36:51 +01:00
skx_base.c
EDAC/skx: Use the mcmtr register to retrieve close_pg/bank_xor_enable
2020-06-17 16:40:33 +02:00
skx_common.c
EDAC/{i7core,sb,pnd2,skx}: Fix error event severity
2020-09-03 11:26:53 +02:00
skx_common.h
EDAC/skx: Use the mcmtr register to retrieve close_pg/bank_xor_enable
2020-06-17 16:40:33 +02:00
synopsys_edac.c
EDAC/synopsys: Do not print an error with back-to-back snprintf() calls
2020-03-12 13:00:31 +01:00
thunderx_edac.c
EDAC, thunderx: Fix memory leak in thunderx_l2c_threaded_isr()
2018-10-13 13:58:06 +02:00
ti_edac.c
EDAC, ti: Add support for TI keystone and DRA7xx EDAC
2017-11-27 13:51:19 +01:00
wq.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
x38_edac.c
EDAC: Get rid of mci->mod_ver
2017-07-17 13:42:48 +02:00
xgene_edac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00