iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/md
History
Song Liu b91d4797b3 md/raid5: fix oops during stripe resizing 
commit b44c018cdf748b96b676ba09fdbc5b34fc443ada upstream.

KoWei reported crash during raid5 reshape:

[ 1032.252932] Oops: 0002 [#1] SMP PTI
[...]
[ 1032.252943] RIP: 0010:memcpy_erms+0x6/0x10
[...]
[ 1032.252947] RSP: 0018:ffffba1ac0c03b78 EFLAGS: 00010286
[ 1032.252949] RAX: 0000784ac0000000 RBX: ffff91bec3d09740 RCX: 0000000000001000
[ 1032.252951] RDX: 0000000000001000 RSI: ffff91be6781c000 RDI: 0000784ac0000000
[ 1032.252953] RBP: ffffba1ac0c03bd8 R08: 0000000000001000 R09: ffffba1ac0c03bf8
[ 1032.252954] R10: 0000000000000000 R11: 0000000000000000 R12: ffffba1ac0c03bf8
[ 1032.252955] R13: 0000000000001000 R14: 0000000000000000 R15: 0000000000000000
[ 1032.252958] FS:  0000000000000000(0000) GS:ffff91becf500000(0000) knlGS:0000000000000000
[ 1032.252959] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1032.252961] CR2: 0000784ac0000000 CR3: 000000031780a002 CR4: 00000000001606e0
[ 1032.252962] Call Trace:
[ 1032.252969]  ? async_memcpy+0x179/0x1000 [async_memcpy]
[ 1032.252977]  ? raid5_release_stripe+0x8e/0x110 [raid456]
[ 1032.252982]  handle_stripe_expansion+0x15a/0x1f0 [raid456]
[ 1032.252988]  handle_stripe+0x592/0x1270 [raid456]
[ 1032.252993]  handle_active_stripes.isra.0+0x3cb/0x5a0 [raid456]
[ 1032.252999]  raid5d+0x35c/0x550 [raid456]
[ 1032.253002]  ? schedule+0x42/0xb0
[ 1032.253006]  ? schedule_timeout+0x10e/0x160
[ 1032.253011]  md_thread+0x97/0x160
[ 1032.253015]  ? wait_woken+0x80/0x80
[ 1032.253019]  kthread+0x104/0x140
[ 1032.253022]  ? md_start_sync+0x60/0x60
[ 1032.253024]  ? kthread_park+0x90/0x90
[ 1032.253027]  ret_from_fork+0x35/0x40

This is because cache_size_mutex was unlocked too early in resize_stripes,
which races with grow_one_stripe() that grow_one_stripe() allocates a
stripe with wrong pool_size.

Fix this issue by unlocking cache_size_mutex after updating pool_size.

Cc: <stable@vger.kernel.org> # v4.4+
Reported-by: KoWei Sung <winders@amazon.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-05 11:43:22 +01:00
..
bcache
bcache: fix a lost wake-up problem caused by mca_cannibalize_lock
2020-10-01 13:17:18 +02:00
persistent-data
dm thin metadata: Fix use-after-free in dm_bm_set_read_only
2020-09-09 19:12:36 +02:00
dm-bio-prison-v1.c
dm: adjust structure members to improve alignment
2018-06-08 11:53:14 -04:00
dm-bio-prison-v1.h
…
dm-bio-prison-v2.c
dm: adjust structure members to improve alignment
2018-06-08 11:53:14 -04:00
dm-bio-prison-v2.h
…
dm-bio-record.h
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-25 08:25:48 +01:00
dm-bufio.c
dm bufio: introduce a global cache replacement
2019-09-13 17:00:21 -04:00
dm-builtin.c
…
dm-cache-background-tracker.c
…
dm-cache-background-tracker.h
…
dm-cache-block-types.h
…
dm-cache-metadata.c
dm cache metadata: Avoid returning cmd->bm wild pointer on error
2020-09-09 19:12:35 +02:00
dm-cache-metadata.h
…
dm-cache-policy-internal.h
…
dm-cache-policy-smq.c
dm: remove unnecessary unlikely() around WARN_ON_ONCE()
2018-10-16 14:34:59 -04:00
dm-cache-policy.c
…
dm-cache-policy.h
…
dm-cache-target.c
dm cache: fix a crash due to incorrect work item cancelling
2020-03-12 13:00:23 +01:00
dm-clone-metadata.c
dm clone: Fix handling of partial region discards
2020-04-17 10:50:24 +02:00
dm-clone-metadata.h
dm clone: replace spin_lock_irqsave with spin_lock_irq
2020-04-17 10:50:23 +02:00
dm-clone-target.c
dm clone: Add missing casts to prevent overflows and data corruption
2020-04-17 10:50:24 +02:00
dm-core.h
dm: disable DISCARD if the underlying storage no longer supports it
2019-04-04 15:33:59 -04:00
dm-crypt.c
dm crypt: Initialize crypto wait structures
2020-09-09 19:12:35 +02:00
dm-delay.c
dm delay: fix a crash when invalid device is specified
2019-04-26 11:29:32 -04:00
dm-dust.c
dm dust: use dust block size for badblocklist index
2019-08-21 11:27:17 -04:00
dm-era-target.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
dm-exception-store.c
…
dm-exception-store.h
- Improve DM snapshot target's scalability by using finer grained
2019-05-16 15:55:48 -07:00
dm-flakey.c
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
dm-init.c
docs: device-mapper: move it to the admin-guide
2019-07-15 11:03:01 -03:00
dm-integrity.c
dm integrity: fix error reporting in bitmap mode after creation
2020-09-09 19:12:35 +02:00
dm-io.c
dm: Use kzalloc for all structs with embedded biosets/mempools
2018-06-05 08:47:43 -06:00
dm-ioctl.c
dm: introduce DM_GET_TARGET_VERSION
2019-09-16 10:18:01 -04:00
dm-kcopyd.c
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
dm-linear.c
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
dm-log-userspace-base.c
dm: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
dm-log-userspace-transfer.c
…
dm-log-userspace-transfer.h
…
dm-log-writes.c
dm log writes: fix incorrect comment about the logged sequence example
2019-07-09 14:13:33 -04:00
dm-log.c
…
dm-mpath.c
dm mpath: fix racey management of PG initialization
2020-09-09 19:12:35 +02:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
…
dm-queue-length.c
…
dm-raid1.c
dm raid1: use struct_size() with kzalloc()
2019-08-26 11:05:32 -04:00
dm-raid.c
dm raid: fix updating of max_discard_sectors limit
2019-09-11 16:18:23 -04:00
dm-region-hash.c
- Error path bug fix for overflow tests (Dan)
2018-06-12 18:28:00 -07:00
dm-round-robin.c
…
dm-rq.c
dm rq: don't call blk_mq_queue_stopped() in dm_stop_queue()
2020-08-21 13:05:33 +02:00
dm-rq.h
dm: remove unused _rq_tio_cache and _rq_cache
2019-03-05 14:48:50 -05:00
dm-service-time.c
…
dm-snap-persistent.c
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
dm-snap-transient.c
…
dm-snap.c
dm snapshot: rework COW throttling to fix deadlock
2019-10-10 09:46:05 -04:00
dm-stats.c
dm stats: use struct_size() helper
2019-09-04 09:39:22 -04:00
dm-stats.h
…
dm-stripe.c
dax: Introduce a ->copy_to_iter dax operation
2018-05-22 23:18:31 -07:00
dm-switch.c
dm switch: use struct_size() in kzalloc()
2019-03-05 14:48:51 -05:00
dm-sysfs.c
dm: remove legacy request-based IO path
2018-10-11 11:36:09 -04:00
dm-table.c
dm table: do not allow request-based DM to stack on partitions
2020-10-01 13:17:14 +02:00
dm-target.c
dm mpath: fix missing call of path selector type->end_io
2019-04-25 15:38:52 -04:00
dm-thin-metadata.c
dm thin metadata: Fix use-after-free in dm_bm_set_read_only
2020-09-09 19:12:36 +02:00
dm-thin-metadata.h
dm thin metadata: Add support for a pre-commit callback
2019-12-21 11:05:01 +01:00
dm-thin.c
dm thin: don't allow changing data device during thin-pool reload
2020-02-24 08:36:49 +01:00
dm-uevent.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-uevent.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-unstripe.c
dm: Check for device sector overflow if CONFIG_LBDAF is not set
2018-12-18 09:02:26 -05:00
dm-verity-fec.c
dm verity fec: fix hash block number in verity_fec_decode
2020-05-06 08:15:10 +02:00
dm-verity-fec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dm-verity-target.c
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm-verity-verify-sig.c
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm-verity-verify-sig.h
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm-verity.h
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm-writecache.c
dm writecache: handle DAX to partitions on persistent memory correctly
2020-09-09 19:12:35 +02:00
dm-zero.c
…
dm-zoned-metadata.c
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-24 17:50:31 +02:00
dm-zoned-reclaim.c
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-24 17:50:31 +02:00
dm-zoned-target.c
dm zoned: assign max_io_len correctly
2020-07-09 09:37:57 +02:00
dm-zoned.h
dm zoned: reduce overhead of backing device checks
2019-12-17 19:56:12 +01:00
dm.c
dm: fix bio splitting and its bio completion order for regular IO
2020-10-01 13:18:25 +02:00
dm.h
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
Kconfig
dm: add clone target
2019-09-12 09:32:31 -04:00
Makefile
dm: add clone target
2019-09-12 09:32:31 -04:00
md-bitmap.c
md/bitmap: md_bitmap_get_counter returns wrong blocks
2020-11-05 11:43:20 +01:00
md-bitmap.h
md: Avoid namespace collision with bitmap API
2018-08-01 15:49:39 -07:00
md-cluster.c
md/bitmap: fix memory leak of temporary bitmap
2020-10-29 09:58:01 +01:00
md-cluster.h
md-cluster: introduce resync_info_get interface for sanity check
2018-10-18 09:36:35 -07:00
md-faulty.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 47
2019-05-24 17:27:13 +02:00
md-linear.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md-linear.h
…
md-multipath.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md-multipath.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
md.c
md: raid0/linear: fix dereference before null check on pointer mddev
2020-08-19 08:15:58 +02:00
md.h
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
raid0.c
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
raid0.h
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
raid1-10.c
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
raid1.c
md: raid1: check rdev before reference in raid1_sync_request func
2020-01-09 10:19:48 +01:00
raid1.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
raid5-cache.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
raid5-log.h
raid5: set write hint for PPL
2019-03-12 10:15:18 -07:00
raid5-ppl.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
raid5.c
md/raid5: fix oops during stripe resizing
2020-11-05 11:43:22 +01:00
raid5.h
raid5: use bio_end_sector in r5_next_bio
2019-09-13 13:14:43 -07:00
raid10.c
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
raid10.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00