iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Nikita Shubin 33afcf723a rtc: ep93xx: Fix NULL pointer dereference in ep93xx_rtc_read_time 
commit 00c33482bb6110bce8110daa351f9b3baf4df7dc upstream.

Mismatch in probe platform_set_drvdata set's and method's that call
dev_get_platdata will result in "Unable to handle kernel NULL pointer
dereference", let's use according method for getting driver data after
platform_set_drvdata.

8<--- cut here ---
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = (ptrval)
[00000000] *pgd=00000000
Internal error: Oops: 5 [#1] ARM
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Not tainted 5.9.10-00003-g723e101e0037-dirty #4
Hardware name: Technologic Systems TS-72xx SBC
PC is at ep93xx_rtc_read_time+0xc/0x2c
LR is at __rtc_read_time+0x4c/0x8c
[...]
[<c02b01c8>] (ep93xx_rtc_read_time) from [<c02ac38c>] (__rtc_read_time+0x4c/0x8c)
[<c02ac38c>] (__rtc_read_time) from [<c02ac3f8>] (rtc_read_time+0x2c/0x4c)
[<c02ac3f8>] (rtc_read_time) from [<c02acc54>] (__rtc_read_alarm+0x28/0x358)
[<c02acc54>] (__rtc_read_alarm) from [<c02abd80>] (__rtc_register_device+0x124/0x2ec)
[<c02abd80>] (__rtc_register_device) from [<c02b028c>] (ep93xx_rtc_probe+0xa4/0xac)
[<c02b028c>] (ep93xx_rtc_probe) from [<c026424c>] (platform_drv_probe+0x24/0x5c)
[<c026424c>] (platform_drv_probe) from [<c0262918>] (really_probe+0x218/0x374)
[<c0262918>] (really_probe) from [<c0262da0>] (device_driver_attach+0x44/0x60)
[<c0262da0>] (device_driver_attach) from [<c0262e70>] (__driver_attach+0xb4/0xc0)
[<c0262e70>] (__driver_attach) from [<c0260d44>] (bus_for_each_dev+0x68/0xac)
[<c0260d44>] (bus_for_each_dev) from [<c026223c>] (driver_attach+0x18/0x24)
[<c026223c>] (driver_attach) from [<c0261dd8>] (bus_add_driver+0x150/0x1b4)
[<c0261dd8>] (bus_add_driver) from [<c026342c>] (driver_register+0xb0/0xf4)
[<c026342c>] (driver_register) from [<c0264210>] (__platform_driver_register+0x30/0x48)
[<c0264210>] (__platform_driver_register) from [<c04cb9ac>] (ep93xx_rtc_driver_init+0x10/0x1c)
[<c04cb9ac>] (ep93xx_rtc_driver_init) from [<c000973c>] (do_one_initcall+0x7c/0x1c0)
[<c000973c>] (do_one_initcall) from [<c04b9ecc>] (kernel_init_freeable+0x168/0x1ac)
[<c04b9ecc>] (kernel_init_freeable) from [<c03b2228>] (kernel_init+0x8/0xf4)
[<c03b2228>] (kernel_init) from [<c00082c0>] (ret_from_fork+0x14/0x34)
Exception stack(0xc441dfb0 to 0xc441dff8)
dfa0:                                     00000000 00000000 00000000 00000000
dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
Code: e12fff1e e92d4010 e590303c e1a02001 (e5933000)
---[ end trace c914d6030eaa95c8 ]---

Fixes: b809d192eb98 ("rtc: ep93xx: stop setting platform_data")
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201201095507.10317-1-nikita.shubin@maquefel.me
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-30 11:51:47 +01:00
..
accessibility
…
acpi
ACPI: PNP: compare the string length in the matching_id()
2020-12-30 11:51:32 +01:00
amba
…
android
binder: add flag to clear buffer on txn complete
2020-12-30 11:51:35 +01:00
ata
ata: sata_nv: Fix retrieving of active qcs
2020-11-05 11:43:12 +01:00
atm
atm: nicstar: Unmap DMA on send error
2020-11-24 13:28:55 +01:00
auxdisplay
…
base
PM: runtime: Resume the device earlier in __device_release_driver()
2020-11-10 12:37:34 +01:00
bcma
…
block
xen/xenbus: Add 'will_handle' callback support in xenbus_watch_path()
2020-12-30 11:51:46 +01:00
bluetooth
Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
2020-12-30 11:51:20 +01:00
bus
bus: fsl-mc: fix error return code in fsl_mc_object_allocate()
2020-12-30 11:51:23 +01:00
cdrom
…
char
virtio: virtio_console: fix DMA memory allocation for rproc serial
2020-11-18 19:20:29 +01:00
clk
clk: tegra: Do not return 0 on failure
2020-12-30 11:51:46 +01:00
clocksource
clocksource/drivers/arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI
2020-12-30 11:51:19 +01:00
connector
…
counter
…
cpufreq
cpufreq: scpi: Add missing MODULE_ALIAS
2020-12-30 11:51:20 +01:00
cpuidle
cpuidle: Fixup IRQ state
2020-09-09 19:12:21 +02:00
crypto
crypto: atmel-i2c - select CONFIG_BITREVERSE
2020-12-30 11:51:24 +01:00
dax
device-dax/core: Fix memory leak when rmmod dax.ko
2020-12-30 11:51:46 +01:00
dca
…
devfreq
PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out
2020-10-01 13:17:14 +02:00
dio
…
dma
dmaengine: mv_xor_v2: Fix error return code in mv_xor_v2_probe()
2020-12-30 11:51:12 +01:00
dma-buf
dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
2020-12-30 11:51:46 +01:00
edac
EDAC/amd64: Fix PCI component registration
2020-12-30 11:51:36 +01:00
eisa
…
extcon
extcon: max77693: Fix modalias string
2020-12-30 11:51:24 +01:00
firewire
…
firmware
efi: EFI_EARLYCON should depend on EFI
2020-12-02 08:49:53 +01:00
fpga
fpga: dfl: fix bug in port reset handshake
2020-07-29 10:18:31 +02:00
fsi
…
gnss
…
gpio
gpio: eic-sprd: break loop when getting NULL device resource
2020-12-30 11:50:55 +01:00
gpu
drm/i915: Fix mismatch between misplaced vma check and vma insert
2020-12-30 11:51:41 +01:00
greybus
…
hid
HID: i2c-hid: add Vero K147 to descriptor override
2020-12-30 11:51:00 +01:00
hsi
HSI: omap_ssi: Don't jump to free ID in ssi_add_controller()
2020-12-30 11:51:13 +01:00
hv
Drivers: hv: vmbus: Allow cleanup of VMBUS_CONNECT_CPU if disconnected
2020-11-24 13:29:23 +01:00
hwmon
hwmon: (ina3221) Fix PM usage counter unbalance in ina3221_write_enable
2020-12-30 11:51:17 +01:00
hwspinlock
…
hwtracing
coresight: etb10: Fix possible NULL ptr dereference in etb_enable_perf()
2020-12-30 11:50:59 +01:00
i2c
Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"
2020-12-30 11:51:01 +01:00
i3c
i3c: master: Fix error return in cdns_i3c_master_probe()
2020-10-29 09:57:51 +01:00
ide
…
idle
…
iio
iio:adc:ti-ads124s08: Fix alignment and data leak issues.
2020-12-30 11:51:45 +01:00
infiniband
RDMA/cma: Don't overwrite sgid_attr after device is released
2020-12-30 11:51:26 +01:00
input
Input: cyapa_gen6 - fix out-of-bounds stack access
2020-12-30 11:51:32 +01:00
interconnect
interconnect: qcom: qcs404: Remove GPU and display RPM IDs
2020-12-16 10:56:56 +01:00
iommu
iommu/amd: Set DTE[IntTabLen] to represent 512 IRTEs
2020-12-11 13:23:31 +01:00
ipack
…
irqchip
irqchip/alpine-msi: Fix freeing of interrupts on allocation error path
2020-12-30 11:51:25 +01:00
isdn
…
leds
leds: bcm6328, bcm6358: use devres LED registering function
2020-11-05 11:43:24 +01:00
lightnvm
lightnvm: fix out-of-bounds write to array devices->info[]
2020-10-29 09:58:00 +01:00
macintosh
macintosh/via-macii: Access autopoll_devs when inside lock
2020-08-19 08:16:15 +02:00
mailbox
mailbox: avoid timer start from callback
2020-10-29 09:57:53 +01:00
mcb
…
md
md/cluster: fix deadlock when node is doing resync job
2020-12-30 11:51:45 +01:00
media
media: ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE
2020-12-30 11:51:31 +01:00
memory
memory: emif: Remove bogus debugfs error handling
2020-11-05 11:43:21 +01:00
memstick
memstick: r592: Fix error return in r592_probe()
2020-12-30 11:51:18 +01:00
message
scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()
2020-11-05 11:43:25 +01:00
mfd
mfd: sprd: Add wakeup capability for PMIC IRQ
2020-11-18 19:20:26 +01:00
misc
habanalabs: put devices before driver removal
2020-12-30 11:50:56 +01:00
mmc
mmc: pxamci: Fix error return code in pxamci_probe
2020-12-30 11:51:11 +01:00
mtd
mtd: rawnand: meson: fix meson_nfc_dma_buffer_release() arguments
2020-12-30 11:51:43 +01:00
mux
…
net
xen/xenbus: Add 'will_handle' callback support in xenbus_watch_path()
2020-12-30 11:51:46 +01:00
nfc
nfc: s3fwrn5: Release the nfc firmware
2020-12-30 11:51:26 +01:00
ntb
NTB: hw: amd: fix an issue about leak system resources
2020-10-29 09:58:00 +01:00
nubus
…
nvdimm
libnvdimm/namespace: Fix reaping of invalidated block-window-namespace labels
2020-12-30 11:51:47 +01:00
nvme
nvme: free sq/cq dbbuf pointers when dbbuf set fails
2020-12-02 08:49:48 +01:00
nvmem
nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem_cell()
2020-10-29 09:57:42 +01:00
of
of/address: Fix of_node memory leak in of_dma_is_coherent
2020-11-18 19:20:28 +01:00
opp
opp: Reduce the size of critical section in _opp_table_kref_release()
2020-11-18 19:20:21 +01:00
oprofile
…
parisc
parisc: mask out enable and reserved bits from sba imask
2020-08-19 08:16:26 +02:00
parport
…
pci
PCI: Fix pci_slot_release() NULL pointer dereference
2020-12-30 11:51:47 +01:00
pcmcia
…
perf
drivers/perf: thunderx2_pmu: Fix memory resource error handling
2020-10-29 09:57:30 +01:00
phy
phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure
2020-12-30 11:51:19 +01:00
pinctrl
pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler
2020-12-30 11:51:45 +01:00
platform
platform/x86: intel-vbtn: Allow switch events on Acer Switch Alpha 12
2020-12-30 11:51:47 +01:00
pnp
…
power
power: supply: bq24190_charger: fix reference leak
2020-12-30 11:51:14 +01:00
powercap
powercap: restrict energy meter to root access
2020-11-10 21:13:20 +01:00
pps
…
ps3
powerpc/ps3: use dma_mapping_error()
2020-12-30 11:51:26 +01:00
ptp
…
pwm
pwm: lp3943: Dynamically allocate PWM chip base
2020-12-30 11:51:28 +01:00
rapidio
rapidio: fix the missed put_device() for rio_mport_add_riodev
2020-10-29 09:57:53 +01:00
ras
…
regulator
regulator: axp20x: Fix DLDO2 voltage control register mask for AXP22x
2020-12-30 11:51:47 +01:00
remoteproc
remoteproc: qcom: Fix potential NULL dereference in adsp_init_mmio()
2020-12-30 11:51:24 +01:00
reset
…
rpmsg
rpmsg: glink: Use complete_all for open states
2020-11-05 11:43:20 +01:00
rtc
rtc: ep93xx: Fix NULL pointer dereference in ep93xx_rtc_read_time
2020-12-30 11:51:47 +01:00
s390
s390/dasd: fix list corruption of lcu list
2020-12-30 11:51:34 +01:00
sbus
…
scsi
scsi: lpfc: Re-fix use after free in lpfc_rq_buf_free()
2020-12-30 11:51:44 +01:00
sfi
…
sh
…
siox
…
slimbus
slimbus: qcom-ngd-ctrl: Avoid sending power requests without QMI
2020-12-30 11:51:13 +01:00
soc
soc: qcom: smp2p: Safely acquire spinlock without IRQs
2020-12-30 11:51:43 +01:00
soundwire
soundwire: bus: disable pm_runtime in sdw_slave_delete
2020-10-01 13:17:36 +02:00
spi
spi: atmel-quadspi: Fix AHB memory accesses
2020-12-30 11:51:43 +01:00
spmi
…
ssb
…
staging
staging: comedi: mf6x4: Fix AI end-of-conversion detection
2020-12-30 11:51:35 +01:00
target
scsi: target: iscsi: Fix cmd abort fabric stop race
2020-12-02 08:49:49 +01:00
tc
…
tee
optee: add writeback to valid memory type
2020-12-02 08:49:53 +01:00
thermal
thermal: rcar_thermal: Handle probe error gracefully
2020-10-01 13:17:44 +02:00
thunderbolt
thunderbolt: Fix use-after-free in remove_unplugged_switch()
2020-12-11 13:23:29 +01:00
tty
serial_core: Check for port state when tty is in error state
2020-12-30 11:51:00 +01:00
uio
uio: Fix use-after-free in uio_unregister_device()
2020-11-18 19:20:29 +01:00
usb
USB: serial: keyspan_pda: fix write unthrottling
2020-12-30 11:51:37 +01:00
vfio
vfio/pci/nvlink2: Do not attempt NPU2 setup on POWER8NVL NPU
2020-12-30 11:51:30 +01:00
vhost
vhost scsi: fix cmd completion race
2020-12-02 08:49:48 +01:00
video
video: fbdev: atmel_lcdfb: fix return error code in atmel_lcdfb_of_init()
2020-12-30 11:51:08 +01:00
virt
drivers/virt/fsl_hypervisor: Fix error handling path
2020-10-29 09:57:38 +01:00
virtio
virtio_ring: Fix two use after free bugs
2020-12-30 11:51:29 +01:00
visorbus
…
vlynq
…
vme
…
w1
w1: mxc_w1: Fix timeout resolution problem leading to bus error
2020-11-05 11:43:25 +01:00
watchdog
watchdog: coh901327: add COMMON_CLK dependency
2020-12-30 11:51:28 +01:00
xen
xenbus/xenbus_backend: Disallow pending watch messages
2020-12-30 11:51:47 +01:00
zorro
…
Kconfig
…
Makefile
…