iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/hid
History
Ping Cheng 003280bd88 HID: wacom: Fix memory leakage caused by kfifo_alloc 
commit 37309f47e2f5674f3e86cb765312ace42cfcedf5 upstream.

As reported by syzbot below, kfifo_alloc'd memory would not be freed
if a non-zero return value is triggered in wacom_probe. This patch
creates and uses devm_kfifo_alloc to allocate and free itself.

BUG: memory leak
unreferenced object 0xffff88810dc44a00 (size 512):
  comm "kworker/1:2", pid 3674, jiffies 4294943617 (age 14.100s)
  hex dump (first 32 bytes):
   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
   [<0000000023e1afac>] kmalloc_array include/linux/slab.h:592 [inline]
   [<0000000023e1afac>] __kfifo_alloc+0xad/0x100 lib/kfifo.c:43
   [<00000000c477f737>] wacom_probe+0x1a1/0x3b0 drivers/hid/wacom_sys.c:2727
   [<00000000b3109aca>] hid_device_probe+0x16b/0x210 drivers/hid/hid-core.c:2281
   [<00000000aff7c640>] really_probe+0x159/0x480 drivers/base/dd.c:554
   [<00000000778d0bc3>] driver_probe_device+0x84/0x100 drivers/base/dd.c:738
   [<000000005108dbb5>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:844
   [<00000000efb7c59e>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
   [<0000000024ab1590>] __device_attach+0x122/0x250 drivers/base/dd.c:912
   [<000000004c7ac048>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
   [<00000000b93050a3>] device_add+0x5ac/0xc30 drivers/base/core.c:2936
   [<00000000e5b46ea5>] hid_add_device+0x151/0x390 drivers/hid/hid-core.c:2437
   [<00000000c6add147>] usbhid_probe+0x412/0x560 drivers/hid/usbhid/hid-core.c:1407
   [<00000000c33acdb4>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
   [<00000000aff7c640>] really_probe+0x159/0x480 drivers/base/dd.c:554
   [<00000000778d0bc3>] driver_probe_device+0x84/0x100 drivers/base/dd.c:738
   [<000000005108dbb5>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:844

https://syzkaller.appspot.com/bug?extid=5b49c9695968d7250a26

Reported-by: syzbot+5b49c9695968d7250a26@syzkaller.appspotmail.com
Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-17 14:05:34 +01:00
..
i2c-hid
HID: i2c-hid: add Vero K147 to descriptor override
2020-12-30 11:51:00 +01:00
intel-ish-hid
HID: intel-ish-hid: avoid bogus uninitialized-variable warning
2020-06-24 17:50:23 +02:00
usbhid
HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage()
2020-09-03 11:27:10 +02:00
hid-a4tech.c
HID: input: fix a4tech horizontal wheel custom usage
2019-08-05 14:37:15 +02:00
hid-accutouch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-alps.c
HID: alps: support devices with report id 2
2020-07-29 10:18:36 +02:00
hid-apple.c
HID: apple: Disable Fn-key key-re-mapping on clone keyboards
2020-07-29 10:18:36 +02:00
hid-appleir.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
hid-asus.c
HID: asus: Ignore Asus vendor-page usage-code 0xff events
2020-02-01 09:34:41 +00:00
hid-aureal.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
hid-axff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-belkin.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-betopff.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-bigbenff.c
HID: hid-bigbenff: fix race condition for scheduled work during removal
2020-03-21 08:11:49 +01:00
hid-cherry.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-chicony.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-cmedia.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
hid-core.c
HID: core: Correctly handle ReportSize being zero
2020-09-05 11:22:49 +02:00
hid-corsair.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-cougar.c
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
2019-08-22 17:11:58 +02:00
hid-cp2112.c
HID: cp2112: prevent sleeping function called from invalid context
2019-08-19 14:13:00 +02:00
hid-creative-sb0540.c
HID: sb0540: add support for Creative SB0540 IR receivers
2019-09-03 16:52:04 +02:00
hid-cypress.c
HID: cypress: Support Varmilo Keyboards' media hotkeys
2020-12-02 08:49:47 +01:00
hid-debug.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
hid-dr.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-elan.c
HID: elan: Fix memleak in elan_input_configured
2020-09-17 13:47:48 +02:00
hid-elecom.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-elo.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 307
2019-06-05 17:37:04 +02:00
hid-emsff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-ezkey.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-gaff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-gembird.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-generic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-gfrm.c
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
2019-08-22 17:11:58 +02:00
hid-google-hammer.c
HID: google: add moonball USB id
2020-03-21 08:11:58 +01:00
hid-gt683r.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
hid-gyration.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-holtek-kbd.c
HID: holtek: test for sanity of intfdata
2019-08-05 14:18:42 +02:00
hid-holtek-mouse.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-holtekff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-hyperv.c
HID: hyperv: Use in-place iterator API in the channel callback
2019-10-01 14:49:41 -04:00
hid-icade.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-ids.h
HID: Add Logitech Dinovo Edge battery quirk
2020-12-02 08:49:48 +01:00
hid-input.c
HID: Add Logitech Dinovo Edge battery quirk
2020-12-02 08:49:48 +01:00
hid-ite.c
HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses
2020-12-02 08:49:47 +01:00
hid-jabra.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-kensington.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-keytouch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-kye.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-lcpower.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-led.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372
2019-06-05 17:37:10 +02:00
hid-lenovo.c
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
2019-08-22 17:11:58 +02:00
hid-lg2ff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-lg3ff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-lg4ff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-lg4ff.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hid-lg.c
HID: logitech: Fix general protection fault caused by Logitech driver
2019-08-22 09:53:08 +02:00
hid-lg.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hid-lgff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-logitech-dj.c
HID: logitech-dj: Fix an error in mse_bluetooth_descriptor
2020-11-24 13:29:21 +01:00
hid-logitech-hidpp.c
HID: logitech-hidpp: Add HIDPP_CONSUMER_VENDOR_KEYS quirk for the Dinovo Edge
2020-12-02 08:49:48 +01:00
hid-macally.c
HID: macally: Add support for Macally ikey keyboard
2019-04-03 17:14:13 +02:00
hid-magicmouse.c
HID: magicmouse: do not set up autorepeat
2020-07-22 09:33:08 +02:00
hid-maltron.c
Support for Maltron L90 keyboard media keys
2019-01-14 20:11:01 +01:00
hid-mf.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
hid-microsoft.c
HID: microsoft: Add rumble support for the 8bitdo SN30 Pro+ controller
2020-09-17 13:47:48 +02:00
hid-monterey.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-multitouch.c
HID: core: Sanitize event code and type when mapping input
2020-09-05 11:22:49 +02:00
hid-nti.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-ntrig.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-ortek.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-penmount.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-petalynx.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-picolcd_backlight.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-picolcd_cir.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-picolcd_core.c
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
2019-08-22 17:11:58 +02:00
hid-picolcd_debugfs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-picolcd_fb.c
video: fbdev: don't print error message on framebuffer_alloc() failure
2019-06-28 12:30:08 +02:00
hid-picolcd_lcd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-picolcd_leds.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-picolcd.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 265
2019-06-05 17:30:28 +02:00
hid-pl.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
hid-plantronics.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-primax.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
hid-prodikeys.c
HID: prodikeys: make array keys static const, makes object smaller
2019-10-01 16:21:04 +02:00
hid-quirks.c
HID: add HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE for Gamevice devices
2020-12-02 08:49:47 +01:00
hid-redragon.c
HID: redragon: fix num lock and caps lock LEDs
2018-06-25 15:23:40 +02:00
hid-retrode.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-rmi.c
HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device
2020-01-04 19:18:13 +01:00
hid-roccat-arvo.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-arvo.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-common.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-common.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-isku.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-isku.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-kone.c
HID: roccat: add bounds checking in kone_sysfs_write_settings()
2020-10-29 09:57:39 +01:00
hid-roccat-kone.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-koneplus.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-koneplus.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-konepure.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-kovaplus.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-kovaplus.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-lua.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-lua.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-pyra.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-pyra.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-ryos.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-savu.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat-savu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-roccat.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-saitek.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-samsung.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-sensor-custom.c
*: convert stream-like files -> stream_open, even if they use noop_llseek
2019-07-14 16:09:19 +03:00
hid-sensor-hub.c
HID: hid-sensor-hub: Fix issue with devices with no report ID
2020-12-02 08:49:47 +01:00
hid-sjoy.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
hid-sony.c
HID: sony: Fix for broken buttons on DS3 USB dongles
2020-06-07 13:18:47 +02:00
hid-speedlink.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-steam.c
HID: steam: fixes race in handling device list.
2020-07-29 10:18:36 +02:00
hid-steelseries.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-sunplus.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-tivo.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-tmff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-topseed.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-twinhan.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 178
2019-05-30 11:29:19 -07:00
hid-u2fzero.c
HID: u2fzero: fail probe if not using USB transport
2019-04-17 16:39:43 +02:00
hid-uclogic-core.c
HID: uclogic: Add ID for Trust Flex Design Tablet
2020-12-02 08:49:46 +01:00
hid-uclogic-params.c
HID: uclogic: Add ID for Trust Flex Design Tablet
2020-12-02 08:49:46 +01:00
hid-uclogic-params.h
HID: uclogic: Support Gray-coded rotary encoders
2019-02-21 12:00:54 +01:00
hid-uclogic-rdesc.c
HID: uclogic: Add support for Ugee G5
2019-02-21 12:00:54 +01:00
hid-uclogic-rdesc.h
HID: uclogic: Add support for Ugee G5
2019-02-21 12:00:54 +01:00
hid-udraw-ps3.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
hid-viewsonic.c
HID: viewsonic: Support PD1011 signature pad
2019-02-21 12:00:53 +01:00
hid-waltop.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-wiimote-core.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-wiimote-debug.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-wiimote-modules.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-wiimote.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-xinmo.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hid-zpff.c
HID: Fix assumption that devices have inputs
2019-10-03 15:36:40 -04:00
hid-zydacron.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hidraw.c
HID: hidraw, uhid: Always report EPOLLOUT
2020-01-17 19:48:15 +01:00
Kconfig
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2019-09-23 12:18:13 -07:00
Makefile
HID: sb0540: add support for Creative SB0540 IR receivers
2019-09-03 16:52:04 +02:00
uhid.c
HID: hidraw, uhid: Always report EPOLLOUT
2020-01-17 19:48:15 +01:00
wacom_sys.c
HID: wacom: Fix memory leakage caused by kfifo_alloc
2021-01-17 14:05:34 +01:00
wacom_wac.c
HID: wacom: Avoid entering wacom_wac_pen_report for pad / battery
2020-11-05 11:43:29 +01:00
wacom_wac.h
Merge branches 'for-5.2/fixes', 'for-5.3/doc', 'for-5.3/ish', 'for-5.3/logitech' and 'for-5.3/wacom' into for-linus
2019-07-10 01:39:57 +02:00
wacom.h
HID: wacom: generic: Treat serial number and related fields as unsigned
2019-11-06 21:37:29 +01:00