linux

iv/linux

History

Richard Fitzgerald 65e07272b6 soundwire: cadence: Don't overflow the command FIFOs

[ Upstream commit 7cbfee2e2e40d2be54196362a845a3ea0a3f877d ]

The command FIFOs in the Cadence IP can be configured during design
up to 32 entries, and the code in cadence_master.c was assuming the
full 32-entry FIFO. But all current Intel implementations use an 8-entry
FIFO.

Up to now the longest message used was 6 entries so this wasn't
causing any problem. But future Cirrus Logic codecs have downloadable
firmware or tuning blobs. It is more efficient for the codec driver to
issue long transfers that can take advantage of any queuing in the
Soundwire controller and avoid the overhead of repeatedly writing the
page registers.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fixes: 2f52a5177caa ("soundwire: cdns: Add cadence library")
Link: https://lore.kernel.org/r/20221202161812.4186897-2-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-03-10 09:33:29 +01:00

bus_type.c

soundwire: revisit driver bind/unbind and callbacks

2022-07-06 12:34:21 +05:30

bus.c

soundwire updates for 6.1-rc1

2022-10-07 16:13:55 -07:00

bus.h

soundwire: export sdw_update() and sdw_update_no_pm()

2021-06-21 13:00:42 +01:00

cadence_master.c

soundwire: cadence: Don't overflow the command FIFOs