iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Eric Dumazet b2e2f9c093 sch_netem: acquire qdisc lock in netem_change() 
[ Upstream commit 2174a08db80d1efeea382e25ac41c4e7511eb6d6 ]

syzbot managed to trigger a divide error [1] in netem.

It could happen if q->rate changes while netem_enqueue()
is running, since q->rate is read twice.

It turns out netem_change() always lacked proper synchronization.

[1]
divide error: 0000 [#1] SMP KASAN
CPU: 1 PID: 7867 Comm: syz-executor.1 Not tainted 6.1.30-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
RIP: 0010:div64_u64 include/linux/math64.h:69 [inline]
RIP: 0010:packet_time_ns net/sched/sch_netem.c:357 [inline]
RIP: 0010:netem_enqueue+0x2067/0x36d0 net/sched/sch_netem.c:576
Code: 89 e2 48 69 da 00 ca 9a 3b 42 80 3c 28 00 4c 8b a4 24 88 00 00 00 74 0d 4c 89 e7 e8 c3 4f 3b fd 48 8b 4c 24 18 48 89 d8 31 d2 <49> f7 34 24 49 01 c7 4c 8b 64 24 48 4d 01 f7 4c 89 e3 48 c1 eb 03
RSP: 0018:ffffc9000dccea60 EFLAGS: 00010246
RAX: 000001a442624200 RBX: 000001a442624200 RCX: ffff888108a4f000
RDX: 0000000000000000 RSI: 000000000000070d RDI: 000000000000070d
RBP: ffffc9000dcceb90 R08: ffffffff849c5e26 R09: fffffbfff10e1297
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff888108a4f358
R13: dffffc0000000000 R14: 0000001a8cd9a7ec R15: 0000000000000000
FS: 00007fa73fe18700(0000) GS:ffff8881f6b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fa73fdf7718 CR3: 000000011d36e000 CR4: 0000000000350ee0
Call Trace:
<TASK>
[<ffffffff84714385>] __dev_xmit_skb net/core/dev.c:3931 [inline]
[<ffffffff84714385>] __dev_queue_xmit+0xcf5/0x3370 net/core/dev.c:4290
[<ffffffff84d22df2>] dev_queue_xmit include/linux/netdevice.h:3030 [inline]
[<ffffffff84d22df2>] neigh_hh_output include/net/neighbour.h:531 [inline]
[<ffffffff84d22df2>] neigh_output include/net/neighbour.h:545 [inline]
[<ffffffff84d22df2>] ip_finish_output2+0xb92/0x10d0 net/ipv4/ip_output.c:235
[<ffffffff84d21e63>] __ip_finish_output+0xc3/0x2b0
[<ffffffff84d10a81>] ip_finish_output+0x31/0x2a0 net/ipv4/ip_output.c:323
[<ffffffff84d10f14>] NF_HOOK_COND include/linux/netfilter.h:298 [inline]
[<ffffffff84d10f14>] ip_output+0x224/0x2a0 net/ipv4/ip_output.c:437
[<ffffffff84d123b5>] dst_output include/net/dst.h:444 [inline]
[<ffffffff84d123b5>] ip_local_out net/ipv4/ip_output.c:127 [inline]
[<ffffffff84d123b5>] __ip_queue_xmit+0x1425/0x2000 net/ipv4/ip_output.c:542
[<ffffffff84d12fdc>] ip_queue_xmit+0x4c/0x70 net/ipv4/ip_output.c:556

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230620184425.1179809-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-06-28 11:12:34 +02:00
..
act_api.c
net/sched: act_api: add specific EXT_WARN_MSG for tc action
2023-06-21 16:01:02 +02:00
act_bpf.c
net: sched: act_bpf: simplify code logic in tcf_bpf_init()
2022-09-28 09:38:56 +01:00
act_connmark.c
netfilter: conntrack: Fix data-races around ct mark
2022-11-18 15:21:00 +01:00
act_csum.c
net: sched: act_csum: get rid of tcf_csum_walker and tcf_csum_search
2022-09-09 08:24:41 +01:00
act_ct.c
netfilter: conntrack: Fix data-races around ct mark
2022-11-18 15:21:00 +01:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-22 12:59:52 +01:00
act_gact.c
treewide: use prandom_u32_max() when possible, part 1
2022-10-11 17:42:55 -06:00
act_gate.c
net: sched: act_gate: get rid of tcf_gate_walker and tcf_gate_search
2022-09-09 08:24:42 +01:00
act_ife.c
net: sched: act_ife: get rid of tcf_ife_walker and tcf_ife_search
2022-09-09 08:24:42 +01:00
act_ipt.c
net: sched: act_ipt: get rid of tcf_ipt_walker/tcf_xt_walker and tcf_ipt_search/tcf_xt_search
2022-09-09 08:24:42 +01:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
net/sched: act_mirred: Add carrier check
2023-05-17 11:53:34 +02:00
act_mpls.c
net/sched: act_mpls: fix action bind logic
2023-03-11 13:55:28 +01:00
act_nat.c
net: sched: act_nat: get rid of tcf_nat_walker and tcf_nat_search
2022-09-09 08:24:42 +01:00
act_pedit.c
net/sched: act_pedit: Parse L3 Header for L4 offset
2023-06-21 16:00:58 +02:00
act_police.c
net: sched: act_police: fix sparse errors in tcf_police_dump()
2023-06-14 11:15:21 +02:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-03-11 13:55:28 +01:00
act_simple.c
net: sched: act_simple: get rid of tcf_simp_walker and tcf_simp_search
2022-09-09 08:24:42 +01:00
act_skbedit.c
net: sched: act_skbedit: get rid of tcf_skbedit_walker and tcf_skbedit_search
2022-09-09 08:24:42 +01:00
act_skbmod.c
net: sched: act_skbmod: get rid of tcf_skbmod_walker and tcf_skbmod_search
2022-09-09 08:24:42 +01:00
act_tunnel_key.c
net: sched: act_tunnel_key: get rid of tunnel_key_walker and tunnel_key_search
2022-09-09 08:24:42 +01:00
act_vlan.c
net: sched: act_vlan: get rid of tcf_vlan_walker and tcf_vlan_search
2022-09-09 08:24:43 +01:00
cls_api.c
net/sched: cls_api: Fix lockup on flushing explicitly created chain
2023-06-21 16:01:01 +02:00
cls_basic.c
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_bpf.c
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_cgroup.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_flow.c
net/sched: use tc_cls_stats_dump() in filter
2022-09-20 15:54:13 -07:00
cls_flower.c
net/sched: flower: fix possible OOB write in fl_set_geneve_opt()
2023-06-09 10:34:04 +02:00
cls_fw.c
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_matchall.c
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_route.c
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
net: sched: use tc_cls_bind_class() in filter
2022-10-02 16:07:17 +01:00
cls_u32.c
net/sched: cls_u32: Fix reference counter leak leading to overflow
2023-06-21 16:00:59 +02:00
em_canid.c
…
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
…
em_ipt.c
…
em_meta.c
net_sched: em_meta: add READ_ONCE() in var_sk_bound_if()
2022-05-16 10:31:06 +01:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
…
em_u32.c
…
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2022-12-31 13:32:55 +01:00
Kconfig
net/sched: Retire tcindex classifier
2023-03-11 13:55:16 +01:00
Makefile
net/sched: Retire tcindex classifier
2023-03-11 13:55:16 +01:00
sch_api.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-21 16:01:01 +02:00
sch_atm.c
net: sched: atm: dont intepret cls results when asked to drop
2023-01-12 12:02:24 +01:00
sch_blackhole.c
…
sch_cake.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_cbq.c
net: sched: cbq: dont intepret cls results when asked to drop
2023-01-12 12:02:24 +01:00
sch_cbs.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_choke.c
net: sched: choke: remove unused variables in struct choke_sched_data
2022-08-31 19:39:53 -07:00
sch_codel.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_drr.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_dsmark.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_etf.c
net: sched: etf: remove true check in etf_enable_offload()
2022-09-01 20:08:32 -07:00
sch_ets.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"
2022-10-19 13:47:09 +01:00
sch_fq_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_fq.c
net/sched: sch_fq: fix integer overflow of "credit"
2023-05-11 23:03:26 +09:00
sch_frag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2021-12-31 14:35:40 +00:00
sch_generic.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-21 16:01:01 +02:00
sch_gred.c
net: sched: gred: prevent races when adding offloads to stats
2023-02-01 08:34:25 +01:00
sch_hfsc.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_hhf.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_htb.c
net: sched: sch: Fix off by one in htb_activate_prios()
2023-02-22 12:59:56 +01:00
sch_ingress.c
net/sched: Reserve TC_H_INGRESS (TC_H_CLSACT) for ingress (clsact) Qdiscs
2023-06-09 10:34:03 +02:00
sch_mq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_mqprio.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_multiq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_netem.c
sch_netem: acquire qdisc lock in netem_change()
2023-06-28 11:12:34 +02:00
sch_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_plug.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_prio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_qfq.c
net: sched: sch_qfq: prevent slab-out-of-bounds in qfq_activate_agg
2023-04-26 14:28:32 +02:00
sch_red.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_sfb.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_sfq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_skbprio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_taprio.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00
sch_tbf.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_teql.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-14 11:15:21 +02:00