iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/proc
History
Dan Carpenter af7aa4fe94 proc/vmcore: fix signedness bug in read_from_oldmem() 
commit 641db40f3afe7998011bfabc726dba3e698f8196 upstream.

The bug is the error handling:

	if (tmp < nr_bytes) {

"tmp" can hold negative error codes but because "nr_bytes" is type size_t
the negative error codes are treated as very high positive values
(success).  Fix this by changing "nr_bytes" to type ssize_t.  The
"nr_bytes" variable is used to store values between 1 and PAGE_SIZE and
they can fit in ssize_t without any issue.

Link: https://lkml.kernel.org/r/b55f7eed-1c65-4adc-95d1-6c7c65a54a6e@moroto.mountain
Fixes: 5d8de293c224 ("vmcore: convert copy_oldmem_page() to take an iov_iter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-03 10:24:14 +02:00
..
array.c
ucounts: Split rlimit and ucount values and max values
2022-10-09 16:24:05 -07:00
base.c
- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in
2022-10-10 17:53:04 -07:00
bootconfig.c
proc: bootconfig: Add null pointer check
2022-04-02 08:40:09 -04:00
cmdline.c
…
consoles.c
…
cpuinfo.c
x86/aperfmperf: Replace aperfmperf_get_khz()
2022-04-27 20:22:19 +02:00
devices.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
fd.c
procfs: prevent unprivileged processes accessing fdinfo dir
2022-05-09 17:34:28 -07:00
fd.h
fs: make helpers idmap mount aware
2021-01-24 14:27:20 +01:00
generic.c
proc: fix dentry/inode overinstantiating under /proc/${pid}/net
2022-05-09 18:29:19 -07:00
inode.c
take care to handle NULL ->proc_lseek()
2022-08-14 15:16:18 -04:00
internal.h
- hfs and hfsplus kmap API modernization from Fabio Francesco
2022-10-12 11:00:22 -07:00
interrupts.c
…
Kconfig
proc: make config PROC_CHILDREN depend on PROC_FS
2022-10-03 14:21:43 -07:00
kcore.c
fs/proc/kcore.c: remove check of list iterator against head past the loop body
2022-04-29 14:37:59 -07:00
kmsg.c
printk changes for 6.1
2022-10-10 11:24:19 -07:00
loadavg.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
Makefile
…
meminfo.c
proc/meminfo: fix spacing in SecPageTables
2022-11-22 18:50:44 -08:00
namespaces.c
…
nommu.c
proc: delete unused <linux/uaccess.h> includes
2022-07-17 17:31:39 -07:00
page.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
proc_net.c
proc: add some (hopefully) insightful comments
2022-07-29 18:12:35 -07:00
proc_sysctl.c
sysctl: clarify register_sysctl_init() base directory order
2023-05-17 11:53:46 +02:00
proc_tty.c
proc: delete unused <linux/uaccess.h> includes
2022-07-17 17:31:39 -07:00
root.c
proc: add some (hopefully) insightful comments
2022-07-29 18:12:35 -07:00
self.c
Revert "proc: don't allow async path resolution of /proc/self components"
2021-02-23 20:32:11 -07:00
softirqs.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
stat.c
fs/proc/uptime.c: Fix idle time reporting in /proc/uptime
2021-10-05 15:51:35 +02:00
task_mmu.c
mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps
2023-02-09 11:28:20 +01:00
task_nommu.c
proc: remove VMA rbtree use from nommu
2022-09-26 19:46:16 -07:00
thread_self.c
Revert "proc: don't allow async path resolution of /proc/thread-self components"
2021-02-23 20:32:11 -07:00
uptime.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
util.c
…
version.c
proc: mark more files as permanent
2022-10-03 14:21:45 -07:00
vmcore.c
proc/vmcore: fix signedness bug in read_from_oldmem()
2023-08-03 10:24:14 +02:00