iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/mptcp
History
Xiang Yang b249c510b4 mptcp: fix the incorrect judgment for msk->cb_flags 
commit 17ebf8a4c38b5481c29623f5e003fdf7583947f9 upstream.

Coccicheck reports the error below:
net/mptcp/protocol.c:3330:15-28: ERROR: test of a variable/field address

Since the address of msk->cb_flags is used in __test_and_clear_bit, the
address should not be NULL. The judgment for if (unlikely(msk->cb_flags))
will always be true, we should check the real value of msk->cb_flags here.

Fixes: 65a569b03ca8 ("mptcp: optimize release_cb for the common case")
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Link: https://lore.kernel.org/r/20230803072438.1847500-1-xiangyang3@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-16 18:27:26 +02:00
..
bpf.c
bpf: Add bpf_skc_to_mptcp_sock_proto
2022-05-20 15:29:00 -07:00
crypto_test.c
mptcp: move crypto test to KUNIT
2020-06-26 16:21:39 -07:00
crypto.c
kunit: mptcp: adhere to KUNIT formatting standard
2021-04-16 17:10:40 -07:00
ctrl.c
mptcp: Add a per-namespace sysctl to set the default path manager type
2022-04-29 17:25:14 -07:00
diag.c
mptcp: allow dumping subflow context to userspace
2020-03-29 22:14:48 -07:00
Kconfig
kunit: mptcp: adhere to KUNIT formatting standard
2021-04-16 17:10:40 -07:00
Makefile
Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2022-05-23 16:07:14 -07:00
mib.c
mptcp: add more offered MIBs counter
2022-05-05 19:00:16 -07:00
mib.h
mptcp: add more offered MIBs counter
2022-05-05 19:00:16 -07:00
mptcp_diag.c
tcp: Access &tcp_hashinfo via net.
2022-09-20 10:21:49 -07:00
options.c
mptcp: use mptcp_schedule_work instead of open-coding it
2023-04-20 12:35:13 +02:00
pm_netlink.c
mptcp: ensure listener is unhashed before updating the sk status
2023-07-01 13:16:22 +02:00
pm_userspace.c
mptcp: update userspace pm infos
2023-06-14 11:15:27 +02:00
pm.c
mptcp: update userspace pm infos
2023-06-14 11:15:27 +02:00
protocol.c
mptcp: fix the incorrect judgment for msk->cb_flags
2023-08-16 18:27:26 +02:00
protocol.h
mptcp: fix disconnect vs accept race
2023-08-16 18:27:21 +02:00
sockopt.c
net: annotate data-races around sk->sk_mark
2023-08-11 12:08:14 +02:00
subflow.c
mptcp: fix disconnect vs accept race
2023-08-16 18:27:21 +02:00
syncookies.c
mptcp: don't return sockets in foreign netns
2021-09-24 10:51:36 +01:00
token_test.c
mptcp: don't return sockets in foreign netns
2021-09-24 10:51:36 +01:00
token.c
mptcp: full disconnect implementation
2022-01-07 11:27:06 +00:00