iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/clk
History
Marc Gonzalez b4825f5d21 clk: qcom: mmcc-msm8998: fix venus clock issue 
[ Upstream commit e20ae5ae9f0c843aded4f06f3d1cab7384789e92 ]

Right now, msm8998 video decoder (venus) is non-functional:

$ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
 (+) Video --vid=1 (*) (vp9 854x480 29.970fps)
     Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
[ffmpeg/video] vp9_v4l2m2m: output VIDIOC_REQBUFS failed: Connection timed out
[ffmpeg/video] vp9_v4l2m2m: no v4l2 output context's buffers
[ffmpeg/video] vp9_v4l2m2m: can't configure decoder
Could not open codec.
Software decoding fallback is disabled.
Exiting... (Quit)

Bryan O'Donoghue suggested the proper fix:
- Set required register offsets in venus GDSC structs.
- Set HW_CTRL flag.

$ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
 (+) Video --vid=1 (*) (vp9 854x480 29.970fps)
     Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
[ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl
[ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl
...
Using hardware decoding (v4l2m2m-copy).
VO: [null] 854x480 nv12
Exiting... (End of file)
real	0m3.315s
user	0m1.277s
sys	0m0.453s

NOTES:

GDSC = Globally Distributed Switch Controller

Use same code as mmcc-msm8996 with:
s/venus_gdsc/video_top_gdsc/
s/venus_core0_gdsc/video_subcore0_gdsc/
s/venus_core1_gdsc/video_subcore1_gdsc/

https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8996.h
https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8998.h

0x1024 = MMSS_VIDEO GDSCR (undocumented)
0x1028 = MMSS_VIDEO_CORE_CBCR
0x1030 = MMSS_VIDEO_AHB_CBCR
0x1034 = MMSS_VIDEO_AXI_CBCR
0x1038 = MMSS_VIDEO_MAXI_CBCR
0x1040 = MMSS_VIDEO_SUBCORE0 GDSCR (undocumented)
0x1044 = MMSS_VIDEO_SUBCORE1 GDSCR (undocumented)
0x1048 = MMSS_VIDEO_SUBCORE0_CBCR
0x104c = MMSS_VIDEO_SUBCORE1_CBCR

Fixes: d14b15b5931c2b ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver")
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://lore.kernel.org/r/ff4e2e34-a677-4c39-8c29-83655c5512ae@freebox.fr
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-12 11:03:29 +02:00
..
actions
clk: actions: remove redundant assignment after a mask operation
2022-04-22 19:01:20 -07:00
analogbits
…
at91
clk: at91: clk-sam9x60-pll: fix return value check
2023-05-11 23:03:32 +09:00
axis
clk: cleanup comments
2022-03-11 18:22:15 -08:00
axs10x
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
baikal-t1
clk: baikal-t1: Convert to platform device driver
2022-09-30 14:20:56 -07:00
bcm
clk: bcm: rpi: Fix off by one in raspberrypi_discover_clocks()
2023-07-19 16:21:30 +02:00
berlin
clk: berlin: Add of_node_put() for of_get_parent()
2022-08-19 14:50:24 -07:00
davinci
Merge branches 'clk-fixed-rate', 'clk-spreadtrum', 'clk-pxa' and 'clk-ti' into clk-next
2022-10-04 10:54:14 -07:00
hisilicon
clk: hisilicon: hi3559a: Fix an erroneous devm_kfree()
2024-03-26 18:20:50 -04:00
imgtec
…
imx
clk: imx: clk-imx8qxp: fix LVDS bypass, pixel and phy clocks
2024-02-05 20:12:57 +00:00
ingenic
clk: ingenic: jz4760: Update M/N/OD calculation algorithm
2023-02-14 19:11:52 +01:00
keystone
clk: keystone: pll: fix a couple NULL vs IS_ERR() checks
2023-11-20 11:51:56 +01:00
loongson1
clk: loongson1: Terminate clk_div_table with sentinel element
2022-03-11 18:13:24 -08:00
mediatek
clk: mediatek: mt8365-mm: fix DPI0 parent
2024-06-12 11:03:28 +02:00
meson
clk: meson: Add missing clocks to axg_clk_regmaps
2024-03-26 18:20:46 -04:00
microchip
clk: microchip: fix potential UAF in auxdev release callback
2023-05-11 23:03:40 +09:00
mmp
clk: mmp: pxa168: Fix memory leak in pxa168_clk_init()
2024-02-05 20:12:56 +00:00
mstar
…
mvebu
clk: mvebu: armada-37xx-tbg: Remove the unneeded result variable
2022-09-30 17:46:30 -07:00
mxs
…
nxp
clk: nxp: fix typo in comment
2022-10-03 12:34:32 -07:00
pistachio
clk: pistachio: Fix initconst confusion
2022-09-28 18:35:45 -07:00
pxa
clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr
2023-06-21 16:00:57 +02:00
qcom
clk: qcom: mmcc-msm8998: fix venus clock issue
2024-06-12 11:03:29 +02:00
ralink
clk: ralink: make system controller node a reset provider
2022-02-15 17:06:37 +01:00
renesas
clk: renesas: r9a07g043: Add clock and reset entry for PLIC
2024-06-12 11:03:29 +02:00
rockchip
clk: rockchip: rk3128: Fix HCLK_OTG gate register
2024-01-20 11:50:06 +01:00
samsung
clk: samsung: exynosautov9: fix wrong pll clock id value
2024-06-12 11:03:27 +02:00
sifive
clk: sifive: select by default if SOC_SIFIVE
2022-10-17 14:07:11 -07:00
socfpga
clk: socfpga: Fix undefined behavior bug in struct stratix10_clock_data
2023-11-28 17:07:10 +00:00
spear
clk: spear: Move prototype to accessible header
2022-10-10 10:37:58 +02:00
sprd
clk: sprd: Fix thm_parents incorrect configuration
2023-10-06 14:56:47 +02:00
st
clk: st: Fix memory leak in st_of_quadfs_setup()
2022-12-31 13:33:04 +01:00
starfive
clk: starfive: Add JH7100 audio clock driver
2022-03-10 18:17:33 -08:00
stm32
clk: stm32: rcc_reset: Fix missing spin_lock_init()
2022-06-09 15:34:08 -07:00
sunxi
clk: sunxi: Do not select the PRCM MFD
2022-07-04 21:59:30 +02:00
sunxi-ng
clk: sunxi-ng: h6: Reparent CPUX during PLL CPUX rate change
2024-05-17 11:56:02 +02:00
tegra
clk: tegra20: fix gcc-7 constant overflow warning
2024-03-06 14:45:05 +00:00
ti
clk: ti: fix double free in of_ti_divider_clk_setup()
2023-11-20 11:51:57 +01:00
uniphier
clk: uniphier: Fix fixed-rate initialization
2022-03-11 19:29:02 -08:00
ux500
clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()
2022-05-18 13:34:03 -07:00
versatile
clk: versatile: clk-icst: use after free on error path
2021-12-07 12:25:29 -08:00
visconti
clk: visconti: Fix undefined behavior bug in struct visconti_pll_provider
2023-11-28 17:07:16 +00:00
x86
clk: mxl: syscon_node_to_regmap() returns error pointers
2023-02-25 11:25:39 +01:00
xilinx
clk: clocking-wizard: Fix Oops in clk_wzrd_register_divider()
2023-07-19 16:21:30 +02:00
zynq
clk: zynq: Prevent null pointer dereference caused by kmalloc failure
2024-03-26 18:20:53 -04:00
zynqmp
drivers: clk: zynqmp: update divider round rate logic
2024-01-25 15:27:36 -08:00
.kunitconfig
clk: explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in .kunitconfig
2022-07-14 10:35:44 -06:00
clk_test.c
clk: tests: Add tests for notifiers
2022-10-10 20:37:50 -07:00
clk-apple-nco.c
clk: clk-apple-nco: Allow and fix module building
2022-03-15 09:56:12 -07:00
clk-asm9260.c
clk: asm9260: use parent index to link the reference clock
2022-09-29 17:55:26 -07:00
clk-aspeed.c
…
clk-aspeed.h
…
clk-ast2600.c
clk: ast2600: BCLK comes from EPLL
2022-10-03 14:12:15 -07:00
clk-axi-clkgen.c
…
clk-axm5516.c
…
clk-bd718x7.c
…
clk-bm1880.c
clk: bm1880: remove kfrees on static allocations
2022-01-06 17:46:56 -08:00
clk-bulk.c
…
clk-cdce706.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-cdce925.c
clk: cdce925: check return value of kasprintf()
2023-07-19 16:21:32 +02:00
clk-clps711x.c
clk: clps711x: Terminate clk_div_table with sentinel element
2022-03-11 18:13:24 -08:00
clk-composite.c
clk: Stop forwarding clk_rate_requests to the parent
2022-09-15 09:32:11 -07:00
clk-conf.c
clk: add missing of_node_put() in "assigned-clocks" property parsing
2023-05-11 23:03:33 +09:00
clk-cs2000-cp.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-devres.c
clk: Fix slab-out-of-bounds error in devm_clk_release()
2023-08-30 16:11:06 +02:00
clk-divider.c
clk: Introduce clk_hw_init_rate_request()
2022-09-15 09:31:40 -07:00
clk-en7523.c
clk: en7523: fix wrong pointer check in en7523_clk_probe()
2022-04-26 11:17:47 -07:00
clk-fixed-factor.c
clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()
2022-07-29 16:44:08 -07:00
clk-fixed-mmio.c
…
clk-fixed-rate.c
clk: fixed-rate: add devm_clk_hw_register_fixed_rate
2022-09-29 17:55:29 -07:00
clk-fractional-divider.c
clk: cleanup comments
2022-03-11 18:22:15 -08:00
clk-fractional-divider.h
…
clk-fsl-flexspi.c
…
clk-fsl-sai.c
…
clk-gate_test.c
clk: gate: Add some kunit test suites
2022-01-24 17:22:53 -08:00
clk-gate.c
clk: gate: Add devm_clk_hw_register_gate()
2021-12-08 11:19:20 +01:00
clk-gemini.c
clk: Gemini: fix struct name in kernel-doc
2021-12-02 17:27:48 -08:00
clk-gpio.c
…
clk-hi655x.c
…
clk-highbank.c
…
clk-hsdk-pll.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
clk-k210.c
…
clk-lan966x.c
clk: allow building lan966x as a module
2022-10-03 14:14:02 -07:00
clk-lmk04832.c
spi: make remove callback a void function
2022-02-09 13:00:45 +00:00
clk-lochnagar.c
dt-bindings: clock: Move lochnagar.h to dt-bindings/clock
2022-08-22 16:04:00 -07:00
clk-max9485.c
clk: max9485: use simple i2c probe function
2022-04-22 19:28:08 -07:00
clk-max77686.c
…
clk-milbeaut.c
…
clk-moxart.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)
2022-06-10 14:51:35 +02:00
clk-multiplier.c
…
clk-mux.c
clk: mux: remove redundant initialization of variable width
2022-04-25 15:49:20 -07:00
clk-nomadik.c
clk: nomadik: Add missing of_node_put()
2022-08-19 14:24:27 -07:00
clk-npcm7xx.c
clk: npcm7xx: Fix incorrect kfree
2023-11-20 11:51:57 +01:00
clk-nspire.c
…
clk-oxnas.c
clk: oxnas: Hold reference returned by of_get_parent()
2022-08-19 14:35:43 -07:00
clk-palmas.c
…
clk-plldig.c
…
clk-pwm.c
…
clk-qoriq.c
clk: qoriq: Hold reference returned by of_get_parent()
2022-08-19 14:41:47 -07:00
clk-renesas-pcie.c
clk: rs9: fix wrong default value for clock amplitude
2024-06-12 11:03:28 +02:00
clk-rk808.c
…
clk-s2mps11.c
…
clk-scmi.c
clk: scmi: Free scmi_clk allocated when the clocks with invalid info are skipped
2023-11-20 11:52:03 +01:00
clk-scpi.c
…
clk-si514.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si544.c
clk: si544: use i2c_match_id and simple i2c probe
2022-04-22 19:28:08 -07:00
clk-si570.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si5341.c
clk: si5341: fix an error code problem in si5341_output_clk_set_rate
2024-01-25 15:27:36 -08:00
clk-si5351.c
i2c: Make remove callback return void
2022-08-16 12:46:26 +02:00
clk-si5351.h
clk: si5351: Update datasheet references
2021-11-02 14:29:17 -07:00
clk-sparx5.c
…
clk-stm32f4.c
clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
2021-12-15 22:45:48 -08:00
clk-stm32h7.c
…
clk-stm32mp1.c
clk: stm32mp1: Add parent_data to ETHRX clock
2022-01-24 17:17:31 -08:00
clk-tps68470.c
platform/x86: int3472: Support multiple clock consumers
2022-09-24 19:12:32 +02:00
clk-twl6040.c
…
clk-versaclock5.c
clk: vc5: check memory returned by kasprintf()
2023-07-19 16:21:32 +02:00
clk-versaclock7.c
clk: vc7: Fix .driver_data content in i2c_device_id
2023-07-19 16:21:17 +02:00
clk-vt8500.c
…
clk-wm831x.c
…
clk-xgene.c
clk: clk-xgene: simplify if-if to if-else
2022-10-03 14:13:29 -07:00
clk.c
clk: Don't hold prepare_lock when calling kref_put()
2024-05-17 11:56:09 +02:00
clk.h
…
clkdev.c
clkdev: Simplify devm_clk_hw_register_clkdev() function
2022-09-30 14:50:11 -07:00
Kconfig
clk: fixed-mmio: make COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM
2023-09-13 09:42:23 +02:00
Makefile
clk: Renesas versaclock7 ccf device driver
2022-09-30 17:34:35 -07:00