iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/tools/perf
History
Namhyung Kim c418d7a675 perf lock contention: Add a missing NULL check 
[ Upstream commit f3408580bac8ce5cd76e7391e529c0a22e7c7eb2 ]

I got a report for a failure in BPF verifier on a recent kernel with
perf lock contention command.  It checks task->sighand->siglock without
checking if sighand is NULL or not.  Let's add one.

  ; if (&curr->sighand->siglock == (void *)lock)
  265: (79) r1 = *(u64 *)(r0 +2624)     ; frame1: R0_w=trusted_ptr_task_struct(off=0,imm=0)
                                        ;         R1_w=rcu_ptr_or_null_sighand_struct(off=0,imm=0)
  266: (b7) r2 = 0                      ; frame1: R2_w=0
  267: (0f) r1 += r2
  R1 pointer arithmetic on rcu_ptr_or_null_ prohibited, null-check it first
  processed 164 insns (limit 1000000) max_states_per_insn 1 total_states 15 peak_states 15 mark_read 5
  -- END PROG LOAD LOG --
  libbpf: prog 'contention_end': failed to load: -13
  libbpf: failed to load object 'lock_contention_bpf'
  libbpf: failed to load BPF skeleton 'lock_contention_bpf': -13
  Failed to load lock-contention BPF skeleton
  lock contention BPF setup failed
  lock contention did not detect any lock contention

Fixes: 1811e82767dcc ("perf lock contention: Track and show siglock with address")
Reviewed-by: Ian Rogers <irogers@google.com>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240409225542.1870999-1-namhyung@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-27 17:11:34 +02:00
..
arch
tools headers UAPI: Sync files changed by new fchmodat2 and map_shadow_stack syscalls with the kernel sources
2023-09-13 08:24:51 -03:00
bench
perf bench sched-seccomp-notify: Use the tools copy of seccomp.h UAPI
2023-09-13 08:49:00 -03:00
dlfilters
perf dlfilter: Add a test for object_code()
2023-09-30 00:09:06 -07:00
Documentation
perf kwork: Add the supported subcommands to the document
2023-11-20 11:59:25 +01:00
include/perf
perf dlfilter: Add al_cleanup()
2023-08-15 16:41:49 -03:00
jvmti
…
pmu-events
perf vendor events arm64 AmpereOne: Rename BPU_FLUSH_MEM_FAULT to GPC_FLUSH_MEM_FAULT
2024-01-25 15:35:51 -08:00
python
…
scripts
perf scripts python gecko: Launch the profiler UI on the default browser with the appropriate URL
2023-08-24 14:41:49 -03:00
tests
perf test record user-regs: Fix mask for vg register
2024-01-25 15:35:51 -08:00
trace
perf tools changes for v6.6:
2023-09-09 20:06:17 -07:00
ui
perf tui slang: Tidy casts
2023-08-25 10:24:55 -03:00
util
perf lock contention: Add a missing NULL check
2024-04-27 17:11:34 +02:00
.gitignore
…
Build
…
builtin-annotate.c
perf addr_location: Add init/exit/copy functions
2023-06-12 15:57:53 -03:00
builtin-bench.c
perf tools changes for v6.6:
2023-09-09 20:06:17 -07:00
builtin-buildid-cache.c
…
builtin-buildid-list.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-c2c.c
perf callchain: Use pthread keys for tls callchain_cursor
2023-06-12 15:57:54 -03:00
builtin-config.c
perf path: Make mkpath thread safe, remove 16384 bytes from .bss
2023-05-28 10:24:14 -03:00
builtin-daemon.c
perf tools: Add missing else to cmd_daemon subcommand condition
2023-06-27 12:09:44 -07:00
builtin-data.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-diff.c
perf diff: Replaces some ',' as separator with the more usual ';'
2023-07-20 11:43:45 -03:00
builtin-evlist.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-ftrace.c
perf tools fixes for v6.4: 2nd batch
2023-05-31 15:31:56 -03:00
builtin-help.c
perf path: Make mkpath thread safe, remove 16384 bytes from .bss
2023-05-28 10:24:14 -03:00
builtin-inject.c
perf inject: Lazily allocate guest_event event_buf
2023-06-12 18:18:14 -03:00
builtin-kallsyms.c
perf symbol: Remove now unused symbol_conf.sort_by_name
2023-06-23 21:48:49 -07:00
builtin-kmem.c
perf callchain: Use pthread keys for tls callchain_cursor
2023-06-12 15:57:54 -03:00
builtin-kvm.c
perf evsel: Introduce evsel__name_is() method to check if the evsel name is equal to a given string
2023-04-24 14:28:11 -03:00
builtin-kwork.c
perf kwork: Set ordered_events to true in 'struct perf_tool'
2023-11-20 11:59:25 +01:00
builtin-list.c
perf list: Fix JSON segfault by setting the used skip_duplicate_pmus callback
2023-12-13 18:45:34 +01:00
builtin-lock.c
tools/perf: Update call stack check in builtin-lock.c
2023-11-20 11:59:26 +01:00
builtin-mem.c
perf addr_location: Add init/exit/copy functions
2023-06-12 15:57:53 -03:00
builtin-probe.c
perf probe: Dynamically allocate params memory
2023-05-28 10:24:02 -03:00
builtin-record.c
perf record: Check conflict between '--timestamp-filename' option and pipe mode before recording
2024-03-26 18:19:43 -04:00
builtin-report.c
perf symbol: Remove now unused symbol_conf.sort_by_name
2023-06-23 21:48:49 -07:00
builtin-sched.c
perf sched: Avoid large stack allocations
2023-06-12 18:18:14 -03:00
builtin-script.c
perf script: Print "cgroup" field on the same line as "comm"
2023-08-08 11:21:11 -03:00
builtin-stat.c
perf stat: Exit perf stat if parse groups fails
2024-01-25 15:35:51 -08:00
builtin-timechart.c
perf addr_location: Add init/exit/copy functions
2023-06-12 15:57:53 -03:00
builtin-top.c
perf top: Use evsel's cpus to replace user_requested_cpus
2024-04-03 15:28:53 +02:00
builtin-trace.c
perf trace: Use heuristic when deciding if a syscall tracepoint "const char *" field is really a string
2023-08-18 16:33:28 -03:00
builtin-version.c
Revert "perf build: Make BUILD_BPF_SKEL default, rename to NO_BPF_SKEL"
2023-05-06 18:07:37 -03:00
builtin.h
perf usage: Move usage strings
2023-04-10 19:20:53 -03:00
check-headers.sh
tools headers UAPI: Copy seccomp.h to be able to build 'perf bench' in older systems
2023-09-13 08:48:48 -03:00
command-list.txt
…
CREDITS
…
design.txt
…
Makefile
…
Makefile.config
perf parse-events: Remove BPF event support
2023-08-15 16:41:48 -03:00
Makefile.perf
perf bpf: Clean up the generated/copied vmlinux.h
2024-03-26 18:19:45 -04:00
MANIFEST
…
perf-archive.sh
…
perf-completion.sh
…
perf-iostat.sh
…
perf-read-vdso.c
…
perf-sys.h
…
perf.c
perf parse-events: Remove BPF event support
2023-08-15 16:41:48 -03:00
perf.h
perf util: Move perf_guest/host declarations
2023-04-10 19:22:05 -03:00