linux

iv/linux

History

Jingbo Xu 6bb6bd3dd6 cachefiles: add missing lock protection when polling

[ Upstream commit cf5bb09e742a9cf6349127e868329a8f69b7a014 ]

Add missing lock protection in poll routine when iterating xarray,
otherwise:

Even with RCU read lock held, only the slot of the radix tree is
ensured to be pinned there, while the data structure (e.g. struct
cachefiles_req) stored in the slot has no such guarantee.  The poll
routine will iterate the radix tree and dereference cachefiles_req
accordingly.  Thus RCU read lock is not adequate in this case and
spinlock is needed here.

Fixes: b817e22b2e91 ("cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode")
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20240628062930.2467993-10-libaokun@huaweicloud.com
Acked-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-07-18 13:21:11 +02:00

cache.c

cachefiles: fix memory leak in cachefiles_add_cache()

2024-03-01 13:35:00 +01:00

daemon.c

cachefiles: add missing lock protection when polling

2024-07-18 13:21:11 +02:00

error_inject.c

fs/cachefiles: simplify one-level sysctl registration for cachefiles_sysctls

2023-04-13 11:49:35 -07:00

interface.c

cachefiles: extract ondemand info field from cachefiles_object