Niklas Cassel
062e256516
ata: libata-core: Fix double free on error ...
commit ab9e0c529eb7cafebdd31fe1644524e80a48b05d upstream.
If e.g. the ata_port_alloc() call in ata_host_alloc() fails, we will jump
to the err_out label, which will call devres_release_group().
devres_release_group() will trigger a call to ata_host_release().
ata_host_release() calls kfree(host), so executing the kfree(host) in
ata_host_alloc() will lead to a double free:
kernel BUG at mm/slub.c:553!
Oops: invalid opcode: 0000 [#1 ] PREEMPT SMP NOPTI
CPU: 11 PID: 599 Comm: (udev-worker) Not tainted 6.10.0-rc5 #47
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:kfree+0x2cf/0x2f0
Code: 5d 41 5e 41 5f 5d e9 80 d6 ff ff 4d 89 f1 41 b8 01 00 00 00 48 89 d9 48 89 da
RSP: 0018:ffffc90000f377f0 EFLAGS: 00010246
RAX: ffff888112b1f2c0 RBX: ffff888112b1f2c0 RCX: ffff888112b1f320
RDX: 000000000000400b RSI: ffffffffc02c9de5 RDI: ffff888112b1f2c0
RBP: ffffc90000f37830 R08: 0000000000000000 R09: 0000000000000000
R10: ffffc90000f37610 R11: 617461203a736b6e R12: ffffea00044ac780
R13: ffff888100046400 R14: ffffffffc02c9de5 R15: 0000000000000006
FS: 00007f2f1cabe980(0000) GS:ffff88813b380000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2f1c3acf75 CR3: 0000000111724000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
<TASK>
? __die_body.cold+0x19/0x27
? die+0x2e/0x50
? do_trap+0xca/0x110
? do_error_trap+0x6a/0x90
? kfree+0x2cf/0x2f0
? exc_invalid_op+0x50/0x70
? kfree+0x2cf/0x2f0
? asm_exc_invalid_op+0x1a/0x20
? ata_host_alloc+0xf5/0x120 [libata]
? ata_host_alloc+0xf5/0x120 [libata]
? kfree+0x2cf/0x2f0
ata_host_alloc+0xf5/0x120 [libata]
ata_host_alloc_pinfo+0x14/0xa0 [libata]
ahci_init_one+0x6c9/0xd20 [ahci]
Ensure that we will not call kfree(host) twice, by performing the kfree()
only if the devres_open_group() call failed.
Fixes: dafd6c496381 ("libata: ensure host is free'd on error exit paths")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240629124210.181537-9-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-07-05 09:34:04 +02:00
2023-10-10 14:42:22 +09:00
2023-03-24 19:19:19 -04:00
2023-05-15 06:49:39 +09:00
2024-03-01 13:35:07 +01:00
2023-05-15 06:49:39 +09:00
2023-05-15 06:49:39 +09:00
2023-08-02 17:37:05 +09:00
2023-05-15 06:49:39 +09:00
2023-08-02 17:37:05 +09:00
2023-08-02 17:37:05 +09:00
2023-08-02 17:37:06 +09:00
2023-07-03 12:56:23 -07:00
2023-08-02 17:37:06 +09:00
2023-08-02 17:37:06 +09:00
2023-05-15 06:49:39 +09:00
2023-08-02 17:37:05 +09:00
2023-08-02 17:37:06 +09:00
2023-08-02 17:37:07 +09:00
2024-07-05 09:34:04 +02:00
2024-03-01 13:34:49 +01:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-23 10:29:26 +09:00
2023-08-02 17:37:05 +09:00
2023-09-15 11:34:31 +09:00
2022-10-18 13:53:27 +09:00
2024-07-05 09:34:04 +02:00
2024-04-03 15:28:59 +02:00
2020-03-26 10:28:19 -06:00
2022-01-05 19:33:01 +09:00
2023-09-11 15:09:11 +09:00
2024-04-17 11:19:25 +02:00
2023-08-02 17:45:10 +09:00
2023-01-04 13:36:26 +09:00
2023-09-28 21:23:14 +09:00
2019-07-29 16:00:14 -06:00
2023-09-28 21:23:14 +09:00
2023-02-22 13:35:51 -08:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:53:09 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-24 08:09:59 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-25 22:09:43 +09:00
2023-08-28 19:14:41 +09:00
2023-08-25 08:21:03 +09:00
2023-08-24 08:09:59 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-17 07:45:32 +09:00
2023-12-03 07:33:03 +01:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:37:06 +09:00
2023-03-24 19:19:19 -04:00
2024-06-16 13:47:33 +02:00
2023-04-26 15:39:25 -07:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:55:49 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-07-28 08:52:42 +09:00
2023-07-26 08:32:21 +09:00
2023-05-15 06:49:39 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-05-15 06:49:39 +09:00
2023-08-02 17:55:52 +09:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:55:52 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:45:42 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:55:52 +09:00
2023-08-02 17:55:52 +09:00
2024-05-17 12:02:13 +02:00
2023-08-02 17:37:06 +09:00
2023-08-02 17:37:06 +09:00
2024-04-10 16:36:01 +02:00
2023-08-02 17:37:06 +09:00
2023-03-24 19:19:19 -04:00
2019-05-21 11:28:46 +02:00
2023-03-24 19:19:19 -04:00
2023-08-02 17:55:52 +09:00
2023-08-02 17:37:07 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-06-13 15:38:48 +09:00
2024-04-10 16:36:00 +02:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
062e256516