iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/s390/char
History
Heiko Carstens be0259796d s390/sclp: Fix sclp_init() cleanup on failure 
[ Upstream commit 6434b33faaa063df500af355ee6c3942e0f8d982 ]

If sclp_init() fails it only partially cleans up: if there are multiple
failing calls to sclp_init() sclp_state_change_event will be added several
times to sclp_reg_list, which results in the following warning:

------------[ cut here ]------------
list_add double add: new=000003ffe1598c10, prev=000003ffe1598bf0, next=000003ffe1598c10.
WARNING: CPU: 0 PID: 1 at lib/list_debug.c:35 __list_add_valid_or_report+0xde/0xf8
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.10.0-rc3
Krnl PSW : 0404c00180000000 000003ffe0d6076a (__list_add_valid_or_report+0xe2/0xf8)
           R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
...
Call Trace:
 [<000003ffe0d6076a>] __list_add_valid_or_report+0xe2/0xf8
([<000003ffe0d60766>] __list_add_valid_or_report+0xde/0xf8)
 [<000003ffe0a8d37e>] sclp_init+0x40e/0x450
 [<000003ffe00009f2>] do_one_initcall+0x42/0x1e0
 [<000003ffe15b77a6>] do_initcalls+0x126/0x150
 [<000003ffe15b7a0a>] kernel_init_freeable+0x1ba/0x1f8
 [<000003ffe0d6650e>] kernel_init+0x2e/0x180
 [<000003ffe000301c>] __ret_from_fork+0x3c/0x60
 [<000003ffe0d759ca>] ret_from_fork+0xa/0x30

Fix this by removing sclp_state_change_event from sclp_reg_list when
sclp_init() fails.

Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-07-25 09:53:34 +02:00
..
con3215.c
s390/3215: use new address translation helpers
2024-03-13 09:23:47 +01:00
con3270.c
tty: con3270: convert to u8 and size_t
2023-12-08 12:02:37 +01:00
ctrlchar.c
…
ctrlchar.h
…
defkeymap.c
…
defkeymap.map
…
diag_ftp.c
s390/ctlreg: rename ctl_reg.h to ctlreg.h
2023-09-19 13:26:56 +02:00
diag_ftp.h
…
fs3270.c
s390/raw3270: make class3270 constant
2024-03-13 09:23:50 +01:00
hmcdrv_cache.c
s390: move from strlcpy with unused retval to strscpy
2022-08-30 22:00:33 +02:00
hmcdrv_cache.h
…
hmcdrv_dev.c
driver core: class: remove module * from class_create()
2023-03-17 15:16:33 +01:00
hmcdrv_dev.h
…
hmcdrv_ftp.c
…
hmcdrv_ftp.h
…
hmcdrv_mod.c
…
Kconfig
s390/uvdevice: Add info IOCTL
2023-06-16 11:08:09 +02:00
keyboard.c
…
keyboard.h
…
Makefile
s390/tty3270: rename to con3270
2023-01-09 14:33:56 +01:00
monreader.c
s390/monreader: fix virtual vs physical address confusion
2023-08-30 11:03:26 +02:00
monwriter.c
s390: include linux/io.h instead of asm/io.h
2023-07-03 11:19:40 +02:00
raw3270.c
s390/3270: Fix buffer assignment
2024-04-26 16:22:38 +02:00
raw3270.h
s390/raw3270: make class3270 constant
2024-03-13 09:23:50 +01:00
sclp_ap.c
…
sclp_cmd.c
s390/mm: implement MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers
2024-02-21 16:00:02 -08:00
sclp_con.c
…
sclp_config.c
…
sclp_cpi_sys.c
…
sclp_cpi_sys.h
…
sclp_ctl.c
…
sclp_diag.h
…
sclp_early_core.c
s390/ctlreg: add struct ctlreg
2023-09-19 13:26:56 +02:00
sclp_early.c
s390/ctlreg: rename ctl_reg.h to ctlreg.h
2023-09-19 13:26:56 +02:00
sclp_ftp.c
s390/hmcdrv: use strscpy() instead of strlcpy()
2023-02-06 11:13:53 +01:00
sclp_ftp.h
…
sclp_ocf.c
…
sclp_pci.c
…
sclp_quiesce.c
…
sclp_rw.c
…
sclp_rw.h
…
sclp_sd.c
…
sclp_sdias.c
…
sclp_sdias.h
…
sclp_tty.c
tty: make tty_operations::write()'s count size_t
2023-08-11 21:12:46 +02:00
sclp_tty.h
…
sclp_vt220.c
tty: make tty_operations::write()'s count size_t
2023-08-11 21:12:46 +02:00
sclp.c
s390/sclp: Fix sclp_init() cleanup on failure
2024-07-25 09:53:34 +02:00
sclp.h
s390/sclp: replace zero-length array with flexible-array member
2023-04-13 17:36:29 +02:00
tape_34xx.c
s390/tape: fix comment typo
2022-07-28 18:05:23 +02:00
tape_3590.c
…
tape_3590.h
…
tape_char.c
…
tape_class.c
s390/tape: make tape_class constant
2024-03-13 09:23:49 +01:00
tape_class.h
…
tape_core.c
…
tape_proc.c
…
tape_std.c
…
tape_std.h
…
tape.h
s390/tape: fix virtual vs physical address confusion
2024-03-13 09:23:48 +01:00
uvdevice.c
s390/uvdevice: Report additional-data length for attestation
2023-11-23 12:15:55 +01:00
vmcp.c
s390/mm: make virt_to_pfn() a static inline
2023-08-16 15:13:03 +02:00
vmlogrdr.c
s390/vmlogrdr: make vmlogrdr_class constant
2024-03-13 09:23:49 +01:00
vmur.c
s390/vmur: make vmur_class constant
2024-03-13 09:23:49 +01:00
vmur.h
s390/vmur: generate uevent on unsolicited device end
2022-10-10 10:15:10 +02:00
zcore.c
s390/switch_to: use generic header file
2024-02-12 15:03:33 +01:00