kastet/latte-dock
1
0
Fork 0
mirror of https://github.com/KDE/latte-dock.git synced 2025-03-09 16:58:16 +03:00
Code Issues Projects Releases Wiki Activity

fix crash from wrong FrameSvgItem initialization

Browse Source 
--enable shadows by default on startup otherwise
the FrameSvgItem sets is imagepath to "" and that
can create a crash during loading/unloading a
layout
This commit is contained in:
Michail Vourlakos 2018-12-01 21:58:45 +02:00
parent 24c52b45f4
commit 5e47a2f483
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/dock/dockview.cpp
View File

@ -134,6 +134,9 @@ DockView::~DockView()
qDebug() << "dock view deleting...";
rootContext()->setContextProperty(QStringLiteral("dock"), nullptr);
rootContext()->setContextProperty(QStringLiteral("themeExtended"), nullptr);
rootContext()->setContextProperty(QStringLiteral("universalSettings"), nullptr);
rootContext()->setContextProperty(QStringLiteral("layoutManager"), nullptr);
//! this disconnect does not free up connections correctly when
//! dockView is deleted. A crash for this example is the following:

3
containment/package/contents/ui/PanelBox.qml
View File

@ -155,7 +155,8 @@ Item{
enabledBorders: dock && dock.effects ? dock.effects.enabledBorders : PlasmaCore.FrameSvg.NoBorder
property bool themeHasShadow: themeExtended ? themeExtended.hasShadow : false
//! set true by default in order to avoid crash on startup because imagePath is set to ""
readonly property bool themeHasShadow: themeExtended ? themeExtended.hasShadow : true
Behavior on opacity {
enabled: Latte.WindowSystem.compositingActive

8
containment/package/contents/ui/main.qml
View File

@ -346,10 +346,10 @@ DragDrop.DropArea {
property Item latteApplet
property Item parabolicManager: _parabolicManager
property QtObject dock
property QtObject themeExtended
property QtObject universalSettings
property QtObject universalLayoutManager
property QtObject dock: null
property QtObject themeExtended: null
property QtObject universalSettings: null
property QtObject universalLayoutManager: null
property QtObject dockManagedLayout: dock && dock.managedLayout ? dock.managedLayout : null
// TO BE DELETED, if not needed: property int counter:0;