kastet/latte-dock
1
0
Fork 0
mirror of https://github.com/KDE/latte-dock.git synced 2025-03-21 22:50:14 +03:00
Code Issues Projects Releases Wiki Activity

fix #183,#465, add workaround for grabItem issue

Browse Source 
--after Qt 5.8 the way the ungrabMouseItem works
has changed this introduced a bug:
http://bugreports.qt.io/browse/QTBUG-59044
plasma devs found a solution for this, that this
commit provides. The issue occurs when a user
right clicks (creates a context menu) and to
release it, he clicks in alternative area
outside the QuickWindow that created the previous
contextmenu
This commit is contained in:
Michail Vourlakos 2017-05-17 09:19:32 +03:00
parent 950cb8f073
commit 8fe5e7ed00
1 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/dockview.cpp
View File

@ -33,6 +33,7 @@
#include <QQuickItem>
#include <QMenu>
#include <QMetaEnum>
#include <QVersionNumber>
#include <KActionCollection>
#include <KAuthorized>
@ -1342,12 +1343,40 @@ void DockView::mousePressEvent(QMouseEvent *event)
desktopMenu->setAttribute(Qt::WA_DeleteOnClose);
m_contextMenu = desktopMenu;
if (this->mouseGrabberItem()) {
//! deprecated old code that can be removed if the following plasma approach doesnt
//! create any issues with context menu creation in Latte
/*if (this->mouseGrabberItem()) {
//workaround, this fixes for me most of the right click menu behavior
this->mouseGrabberItem()->ungrabMouse();
return;
}*/
//!plasma official code
//this is a workaround where Qt will fail to realise a mouse has been released
// this happens if a window which does not accept focus spawns a new window that takes focus and X grab
// whilst the mouse is depressed
// https://bugreports.qt.io/browse/QTBUG-59044
// this causes the next click to go missing
//by releasing manually we avoid that situation
auto ungrabMouseHack = [this]() {
if (this->mouseGrabberItem()) {
this->mouseGrabberItem()->ungrabMouse();
}
};
//pre 5.8.0 QQuickWindow code is "item->grabMouse(); sendEvent(item, mouseEvent)"
//post 5.8.0 QQuickWindow code is sendEvent(item, mouseEvent); item->grabMouse()
if (QVersionNumber::fromString(qVersion()) > QVersionNumber(5, 8, 0)) {
QTimer::singleShot(0, this, ungrabMouseHack);
} else {
ungrabMouseHack();
}
//end workaround
//!end of plasma official code(workaround)
//qDebug() << "5 ...";
if (applet) {