keremet/mkimage-profiles
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

firmware: a trivial tracing fixup

Browse Source 
The issue with these "; @:" thinglets is that mkimage-profiles
relies on target tracing (see commit 788cad8 some four years ago);
and this tracing approach relies on non-empty recipes which do call
shell (which gets (ab)used) unlike empty ones which oviously don't.

So this _will_ be traced properly:

    a: b
	@echo "hello world"

and this will too:

    a: b; @:

but this will result in a broken graph with REPORT=1:

    a: b
This commit is contained in:
Michael Shigorin 2016-01-29 16:18:41 +03:00
parent 32e77dc97b
commit f197b9714c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features.in/firmware/config.mk
View File

@ -6,7 +6,7 @@ use/firmware:
@$(call add_feature)
@$(call add,SYSTEM_PACKAGES,firmware-linux)
use/firmware/full: use/firmware/server use/firmware/laptop
use/firmware/full: use/firmware/server use/firmware/laptop; @:
use/firmware/cpu: use/firmware
@$(call add,THE_PACKAGES,microcode-data-intel microcode_ctl)