keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
00bd491fe2
rpm-ostree/tests/vmcheck/test-initramfs.sh

134 lines
4.7 KiB
Bash
Raw Normal View History

Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
#!/bin/bash
#
# Copyright (C) 2017 Red Hat, Inc.
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
tests/vmcheck: turn on strict bash mode Closes: #1032 Approved by: cgwalters
2017-10-01 16:34:23 +03:00
set -euo pipefail
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
. ${commondir}/libtest.sh
. ${commondir}/libvm.sh
set -x
# SUMMARY: Tests for the `initramfs` functionality
base=$(vm_get_booted_csum)
vm_rpmostree initramfs > initramfs.txt
assert_file_has_content initramfs.txt "Initramfs regeneration.*disabled"
echo "ok initramfs status"
if vm_rpmostree initramfs --disable 2>err.txt; then
assert_not_reached "Unexpectedly succeeded at disabling"
fi
assert_file_has_content err.txt "already.*disabled"
if vm_rpmostree initramfs --reboot 2>err.txt; then
assert_not_reached "reboot worked?"
fi
initramfs: Return error when --arg specified without --enable This change gives an error when --arg is specified on its own. Previously, if adding --arg without --enable, no changes occur and only the initramfs regeneration status is printed. Since --arg only takes effect when used with --enable, this should also give an error (or let the user know in some way). Closes: #1548 Approved by: jlebon
2018-09-12 21:13:29 +03:00
assert_file_has_content err.txt "reboot.*used with.*enable.*disable"
if vm_rpmostree initramfs --arg=foo 2>err.txt; then
assert_not_reached "arg worked?"
fi
assert_file_has_content err.txt "arg.*used with.*enable"
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
echo "ok initramfs state"
Copy used command-line and set as transaction title In the app, rebuild the exact command-line that the client used and pass that to the daemon to be used as the transaction title. Especially in transactions like `UpdateDeployment()`, we can avoid reverse-engineering what the original command used was. This will be used by the upcoming history feature to record the command-line used in the journal. Closes: #1824 Approved by: rfairley
2019-05-01 17:07:31 +03:00
vm_status_watch_start
initramfs: Print regeneration status for pending deployment Previously, after enabling initramfs regeneration, the initramfs command would indicate that initramfs regeneratin is disabled, suggesting that the initramfs had not actually been enabled. This happened because the initramfs regeneration status for the current deployment was printed; initramfs regeneration is only enabled for a pending deployment. This change prints the regeneration for the pending deployment, rather than the current, when no options are given to the initramfs command. Fixes: #1526 Closes: #1548 Approved by: jlebon
2018-09-10 18:15:22 +03:00
vm_rpmostree initramfs --enable > initramfs.txt
Copy used command-line and set as transaction title In the app, rebuild the exact command-line that the client used and pass that to the daemon to be used as the transaction title. Especially in transactions like `UpdateDeployment()`, we can avoid reverse-engineering what the original command used was. This will be used by the upcoming history feature to record the command-line used in the journal. Closes: #1824 Approved by: rfairley
2019-05-01 17:07:31 +03:00
vm_status_watch_check "Transaction: initramfs --enable"
initramfs: Print regeneration status for pending deployment Previously, after enabling initramfs regeneration, the initramfs command would indicate that initramfs regeneratin is disabled, suggesting that the initramfs had not actually been enabled. This happened because the initramfs regeneration status for the current deployment was printed; initramfs regeneration is only enabled for a pending deployment. This change prints the regeneration for the pending deployment, rather than the current, when no options are given to the initramfs command. Fixes: #1526 Closes: #1548 Approved by: jlebon
2018-09-10 18:15:22 +03:00
assert_file_has_content initramfs.txt "Initramfs regeneration.*enabled"
vm_rpmostree initramfs > initramfs.txt
assert_file_has_content initramfs.txt "Initramfs regeneration.*enabled"
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
Add `pending-base-commit` to status One thing that's very confusing about OSTree is there are two layers - deployments and the refs/commits. If one does an `rpm-ostree upgrade`, but then e.g. `ostree admin undeploy 0`, you still have the new revision in the repo. We don't do a good job of displaying this state, or helping people clean it up. Down the line, I also want to better support something like `rpm-ostree pull` to cache updates explicitly *without* deploying. This commit just adds a bit of information to the status display. We might want to have better formatting, but I think this an OK start. Closes: #595 Approved by: jlebon
2017-01-27 07:31:53 +03:00
'.deployments[1].booted' \
'.deployments[0]["regenerate-initramfs"]' \
'.deployments[1]["regenerate-initramfs"]|not'
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
vm_reboot
assert_not_streq $base $(vm_get_booted_csum)
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
'.deployments[0].booted' \
'.deployments[0]["regenerate-initramfs"]' \
'.deployments[0]["initramfs-args"]|length == 0' \
'.deployments[1]["regenerate-initramfs"]|not' \
'.deployments[1]["initramfs-args"]|not'
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
if vm_rpmostree initramfs --enable 2>err.txt; then
assert_not_reached "Unexpectedly succeeded at enabling"
fi
assert_file_has_content err.txt "already.*enabled"
echo "ok initramfs enabled"
initramfs: Print regeneration status for pending deployment Previously, after enabling initramfs regeneration, the initramfs command would indicate that initramfs regeneratin is disabled, suggesting that the initramfs had not actually been enabled. This happened because the initramfs regeneration status for the current deployment was printed; initramfs regeneration is only enabled for a pending deployment. This change prints the regeneration for the pending deployment, rather than the current, when no options are given to the initramfs command. Fixes: #1526 Closes: #1548 Approved by: jlebon
2018-09-10 18:15:22 +03:00
vm_rpmostree initramfs --disable > initramfs.txt
assert_file_has_content initramfs.txt "Initramfs regeneration.*disabled"
vm_rpmostree initramfs > initramfs.txt
assert_file_has_content initramfs.txt "Initramfs regeneration.*disabled"
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
vm_reboot
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
'.deployments[0].booted' \
'.deployments[0]["regenerate-initramfs"]|not' \
'.deployments[1]["regenerate-initramfs"]'
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
echo "ok initramfs disabled"
vm_reboot_cmd rpm-ostree initramfs --enable --reboot
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
'.deployments[0].booted' \
'.deployments[0]["regenerate-initramfs"]' \
'.deployments[1]["regenerate-initramfs"]|not'
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
vm_reboot_cmd rpm-ostree initramfs --disable --reboot
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
'.deployments[0].booted' \
'.deployments[0]["regenerate-initramfs"]|not' \
'.deployments[1]["regenerate-initramfs"]'
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
echo "ok initramfs enable disable reboot"
assert_streq $base $(vm_get_booted_csum)
test-initramfs.sh: fix for centos Fetch the osname rather than hardcoding it. Closes: #636 Approved by: cgwalters
2017-02-18 01:36:49 +03:00
osname=$(vm_get_booted_deployment_info osname)
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
for file in first second; do
vm_cmd touch /etc/rpmostree-initramfs-testing-$file
vm_rpmostree initramfs --enable --arg="-I" --arg="/etc/rpmostree-initramfs-testing-$file"
initramfs: Return error when --arg specified without --enable This change gives an error when --arg is specified on its own. Previously, if adding --arg without --enable, no changes occur and only the initramfs regeneration status is printed. Since --arg only takes effect when used with --enable, this should also give an error (or let the user know in some way). Closes: #1548 Approved by: jlebon
2018-09-12 21:13:29 +03:00
vm_rpmostree initramfs > initramfs.txt
assert_file_has_content initramfs.txt "Initramfs.*args.*-I.*/etc/rpmostree-initramfs-testing-$file"
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
vm_reboot
check: use jq for asserting json elements Closes: #609 Approved by: cgwalters
2017-02-08 01:49:20 +03:00
vm_assert_status_jq \
Add `pending-base-commit` to status One thing that's very confusing about OSTree is there are two layers - deployments and the refs/commits. If one does an `rpm-ostree upgrade`, but then e.g. `ostree admin undeploy 0`, you still have the new revision in the repo. We don't do a good job of displaying this state, or helping people clean it up. Down the line, I also want to better support something like `rpm-ostree pull` to cache updates explicitly *without* deploying. This commit just adds a bit of information to the status display. We might want to have better formatting, but I think this an OK start. Closes: #595 Approved by: jlebon
2017-01-27 07:31:53 +03:00
'.deployments[0].booted' \
'.deployments[0]["regenerate-initramfs"]' \
'.deployments[0]["initramfs-args"]|index("-I") == 0' \
'.deployments[0]["initramfs-args"]|index("/etc/rpmostree-initramfs-testing-'${file}'") == 1' \
'.deployments[0]["initramfs-args"]|length == 2'
tests: Update for ostree BLS file naming change We should probably add a libtest.sh API for so for this, but this is the quick hack. Fallout from https://github.com/ostreedev/ostree/pull/1654 Closes: #1433 Approved by: jlebon
2018-06-28 20:44:33 +03:00
initramfs=$(vm_cmd grep ^initrd /boot/loader/entries/ostree-2-$osname.conf | sed -e 's,initrd ,/boot/,')
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
test -n "${initramfs}"
vm_cmd lsinitrd $initramfs > lsinitrd.txt
assert_file_has_content lsinitrd.txt /etc/rpmostree-initramfs-testing-${file}
done
tests: Make two more tests compatible with deployment staging Unlike the kernel args one, these two were simple. Closes: #1458 Approved by: jlebon
2018-07-13 19:22:05 +03:00
echo "ok initramfs args enable"
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
vm_rpmostree initramfs --disable
tests: Make two more tests compatible with deployment staging Unlike the kernel args one, these two were simple. Closes: #1458 Approved by: jlebon
2018-07-13 19:22:05 +03:00
vm_reboot
tests: Update for ostree BLS file naming change We should probably add a libtest.sh API for so for this, but this is the quick hack. Fallout from https://github.com/ostreedev/ostree/pull/1654 Closes: #1433 Approved by: jlebon
2018-06-28 20:44:33 +03:00
initramfs=$(vm_cmd grep ^initrd /boot/loader/entries/ostree-2-$osname.conf | sed -e 's,initrd ,/boot/,')
Support "system/regenerate-initramfs=true" flag in origin Currently we push for a model where the initramfs is generated (in non-hostonly mode), and merely replicated. However, to support a few unfortunate corner cases like dm-multipath which wants to inject a config file into the initramfs, we need to support regenerating it client side too. Down the line, we'll need this to support overriding the kernel too. This changes things in the core to add the concept of an "empty" `RpmOstreeContext`. I initially tried skipping it, but that was too much duplication. We still want all of the core ostree-related logic that lives in that code too. The treespec bits barfed if the spec didn't have a `tree/packages` key. It was simplest to change that to allow it - and because that was the only case where we errored out in parsing, I dropped the error handling. There was another place in the upgrader that now needed to be fixed to handle transitioning from just regenerating initramfs to not. Closes: #574 Approved by: jlebon
2017-01-04 20:29:01 +03:00
test -n "${initramfs}"
vm_cmd lsinitrd $initramfs > lsinitrd.txt
assert_not_file_has_content lsinitrd.txt /etc/rpmostree-initramfs-testing
tests: Make two more tests compatible with deployment staging Unlike the kernel args one, these two were simple. Closes: #1458 Approved by: jlebon
2018-07-13 19:22:05 +03:00
echo "ok initramfs disable"
Reference in New Issue Copy Permalink