rpm-ostree/ci/build-check.sh

#!/usr/bin/bash
# Install build dependencies, run unit tests and installed tests.

set -xeuo pipefail

dn=$(dirname $0)
. ${dn}/libbuild.sh
${dn}/build.sh
# NB: avoid make function because our RPM building doesn't
# support parallel runs right now
/usr/bin/make check
make install

# And now a clang build to find unused variables, but only run on Fedora because
# the CentOS version is ancient anyway and doesn't support all the flags that
# might get passed to it.
id=$(. /etc/os-release && echo $ID)
if [ "$id" == fedora ]; then
    git clean -dfx
    export CC=clang
    export CFLAGS='-Werror=unused-variable -Werror=maybe-uninitialized'
    build_default
    # don't actually run the tests, just compile them
    /usr/bin/make check TESTS=
fi
ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`#!/usr/bin/bash`
			`# Install build dependencies, run unit tests and installed tests.`

			`set -xeuo pipefail`

			`dn=$(dirname $0)`
			`. ${dn}/libbuild.sh`
			`${dn}/build.sh`
libbuild.sh: pass arguments to make Otherwise, e.g. `make check` && `make install` won't actually do anything. Closes: #765 Approved by: cgwalters 2017-05-05 22:56:53 +03:00			`# NB: avoid make function because our RPM building doesn't`
			`# support parallel runs right now`
			`/usr/bin/make check`
ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`make install`

ci: don't run clang on CentOS The CentOS tester is currently failing because clang is being passed an argument it doesn't know about: clang: error: unknown argument: '-fstack-protector-strong' We get our version of clang from EPEL, which currently has 3.4.2. The Fedora clang does have support for the flag (4.0.1). Anyway, the point of this check is just to find unused/uninitialized vars and other gotchas. In that sense, we're more interested in what the latest version of clang has to say. Closes: #992 Approved by: cgwalters 2017-09-14 21:43:30 +03:00			`# And now a clang build to find unused variables, but only run on Fedora because`
			`# the CentOS version is ancient anyway and doesn't support all the flags that`
			`# might get passed to it.`
			`id=$(. /etc/os-release && echo $ID)`
			`if [ "$id" == fedora ]; then`
			`git clean -dfx`
			`export CC=clang`
			`export CFLAGS='-Werror=unused-variable -Werror=maybe-uninitialized'`
			`build_default`
			`# don't actually run the tests, just compile them`
			`/usr/bin/make check TESTS=`
			`fi`