keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7c1b6df951
rpm-ostree/Makefile-rpm-ostree.am

145 lines
5.3 KiB
Plaintext
Raw Normal View History

Initial import from pkgsys-ostree
2013-12-22 04:41:30 +04:00
# Copyright (C) 2013 Colin Walters <walters@verbum.org>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
Unify rpm-ostree into one binary And start making an internal library.
2014-01-29 23:37:44 +04:00
bin_PROGRAMS += rpm-ostree
Initial import from pkgsys-ostree
2013-12-22 04:41:30 +04:00
main: Convert to C++ Also here, catch C++ exceptions and convert to GError.
2020-12-08 20:15:13 +03:00
rpm_ostree_SOURCES = src/app/main.cxx \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtins.h \
src/app/rpmostree-db-builtins.h \
src/app/rpmostree-compose-builtins.h \
Port rpmostree-builtin-upgrade to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-upgrade.cxx \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtin-rollback.c \
app: Add "deploy" command Command-line interface for new D-Bus "Deploy" methods.
2015-10-21 16:50:26 +03:00
src/app/rpmostree-builtin-deploy.c \
daemon: Implement "reload" There are two main issues right now; first, we don't pick up manual changes to `.origin` files, which occurs when one needs to sed it to remove `unconfigured` for example. Second, we need to reload changes to the remotes. Closes: #598 Approved by: jlebon
2016-08-06 16:07:56 +03:00
src/app/rpmostree-builtin-reload.c \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtin-rebase.c \
Add `cancel` verb and DBus API Right now the fact that one can only cancel via `Ctrl-C` of an existing client process is rather frustrating if for example one's ssh connection to a machine drops. Now, upon reconnecting, one can easily `rpm-ostree cancel` a hung update or whatever rather than doing the more forcible `systemctl stop rpm-ostreed` (which is safe of course, unless livefs is involved). Closes: #1019 Approved by: jlebon
2017-12-06 01:14:18 +03:00
src/app/rpmostree-builtin-cancel.c \
Add support for wrapping binaries (rpm, dracut, grubby) We need to be friendlier to people who are transitioning from "traditional" yum managed systems. This patchset starts to lay out the groundwork for supporting "intercepting" binaries that are in the tree. For backwards compatibility, this feature is disabled by default, to enable it, one can add `cliwrap: true` to the manifest. To start with for example, we wrap `/usr/bin/rpm` and cause it to drop privileges. This way it can't corrupt anything; we're not just relying on the read-only bind mount. For example nothing will accidentally get written to `/var/lib/rpm`. Now a tricky thing with this one is we *do* want it to write if we're in an unlocked state. There are various other examples of binaries we want to intercept, among them: - `grubby` -> `rpm-ostree kargs` - `dracut` -> `rpm-ostree initramfs` - `yum` -> well...we'll talk about that later
2019-02-23 21:46:59 +03:00
src/app/rpmostree-builtin-cliwrap.c \
Add a cleanup command and DBus API We sometimes talk about using `ostree admin undeploy`, but that doesn't know about the pkgcache, and hence space there leaks until the next rpm-ostree operation. Just for this, we need to expose a cleanup command (and API). But we also need to support cleaning: - repomd - downloads (repo/tmp) So let's start implementing that. Closes: #614 Approved by: jlebon
2017-02-09 01:38:49 +03:00
src/app/rpmostree-builtin-cleanup.c \
start-daemon: make hidden I debated just putting this in the supported list, but decided against it in the end. This really should be something that happens transparently, and if it doesn't then something else is probably wrong. Closes: #617 Approved by: cgwalters
2017-02-10 20:33:08 +03:00
src/app/rpmostree-builtin-initramfs.c \
Add new `ex initramfs-etc` command This command allows users to cheaply inject configuration files in the initramfs stage without having to regenerate the whole initramfs (or even a new OSTree commit). This will be useful for configuring services involved in bringing up the root block device. ``` $ echo 'hello world' > /etc/foobar $ rpm-ostree ex initramfs-etc --track /etc/foobar Staging deployment... done Run "systemctl reboot" to start a reboot $ rpm-ostree status State: idle Deployments: ostree://fedora:fedora/x86_64/coreos/testing-devel Version: 32.20200716.dev.1 (2020-07-16T02:47:29Z) Commit: 9a817d75bef81b955179be6e602d1e6ae350645b6323231a62ba2ee6e5b9644b GPGSignature: (unsigned) InitramfsEtc: /etc/foobar ● ostree://fedora:fedora/x86_64/coreos/testing-devel Version: 32.20200716.dev.1 (2020-07-16T02:47:29Z) Commit: 9a817d75bef81b955179be6e602d1e6ae350645b6323231a62ba2ee6e5b9644b GPGSignature: (unsigned) $ reboot (boot into rd.break) sh-5.0# cat /etc/foobar hello world ``` See the libostree side of this at: https://github.com/ostreedev/ostree/pull/2155 Lots more discussions in: https://github.com/coreos/fedora-coreos-tracker/issues/94 Closes: #1930
2020-07-25 00:35:01 +03:00
src/app/rpmostree-builtin-initramfs-etc.c \
Port rpmostree-builtin-livefs to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-livefs.cxx \
Port rpmostree-builtin-usroverlay to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-usroverlay.cxx \
Port rpmostree-builtin-override to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-override.cxx \
Port rpmostree-builtin-refresh-md to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-refresh-md.cxx \
Port rpmostree-builtin-reset to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-builtin-reset.cxx \
Port rpmostree-pkg-builtins to C++ Prep for using https://cxx.rs/
2020-12-21 19:08:51 +03:00
src/app/rpmostree-pkg-builtins.cxx \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtin-status.c \
app: Rename internals → ex The goal is to consolidate our "experimental" functionality under one subcommand. This makes it easier to determine when things "graduate" to permanent-stability status under the main command line. Closes: https://github.com/projectatomic/rpm-ostree/issues/682 Closes: #683 Approved by: jlebon
2017-03-16 04:05:14 +03:00
src/app/rpmostree-builtin-ex.c \
tests: Add hidden `testutils` subcommand This is a hack to allow using `inject-pkglist` without having to build the tree first. Higher-level, I think we can split this back out again if we have a `-tests` subpackage where we ship the vmcheck testsuite.
2019-12-13 20:19:56 +03:00
src/app/rpmostree-builtin-testutils.c \
shlib: Make basearch APIs call `/usr/bin/rpm-ostree shlib-backend` This is a potential path to fix https://github.com/coreos/rpm-ostree/issues/2391 Basically our shared library and executable duplicate too much code (particularly Rust). Since most of the shlib APIs aren't performance sensitive, let's have them fork off the binary via a hidden CLI entrypoint and parse the output.
2020-12-16 00:45:10 +03:00
src/app/rpmostree-builtin-shlib-backend.c \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtin-db.c \
start-daemon: make hidden I debated just putting this in the supported list, but decided against it in the end. This really should be something that happens transparently, and if it doesn't then something else is probably wrong. Closes: #617 Approved by: cgwalters
2017-02-10 20:33:08 +03:00
src/app/rpmostree-builtin-start-daemon.c \
Add new D-Bus APIs for deployment finalization Teach `UpdateDeployment` to make use of libostree's staging lock and then add a `FinalizeDeployment` API to perform the final unlock & reboot. I also added a hidden CLI to make testing this easier, but also because it's likely the FCOS-agent-yet-to-be-named will just end up using the CLI to keep it simple. Closes: #1748 Closes: #1814 Approved by: lucab
2019-04-19 00:27:09 +03:00
src/app/rpmostree-builtin-finalize-deployment.c \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-db-builtin-diff.c \
src/app/rpmostree-db-builtin-list.c \
src/app/rpmostree-db-builtin-version.c \
app: Port dbus-helpers to C++ Prep for using https://cxx.rs/
2020-12-06 22:38:13 +03:00
src/app/rpmostree-dbus-helpers.cxx \
daemon: Make parts of cli use the daemon
2015-06-13 03:19:16 +03:00
src/app/rpmostree-dbus-helpers.h \
app: add experimental support for pkg removals This is one more step towards making rpm-ostree more powerful in its quest to be the ultimate *hybrid* image/package system. Package layering allows us to add packages on top of the base package set received from the content provider. However, we're not able to remove or replace packages in the base set itself. This patch introduces a new `override` command, which is for now nested under the experimental `ex` command. The `override` command will allow users to modify the base package set itself. The first implemented subcommands are `remove` and `reset`. A stub has been provided for the more useful `replace` subcommand, though much of the needed logic for that operation are implemented in this patch as part of the `remove` subcommand. Part of: https://github.com/projectatomic/rpm-ostree/issues/485 Closes: #797 Approved by: cgwalters
2017-06-05 19:37:56 +03:00
src/app/rpmostree-override-builtins.h \
src/app/rpmostree-override-builtins.c \
Port rpmostree-libbuiltin to C++ Prep for using https://cxx.rs/
2020-12-19 21:14:18 +03:00
src/app/rpmostree-libbuiltin.cxx \
Move diff printing code into client This is a step forward to deduplicating; the client tooling now calls into the public API for diffs, rather than using the older internal function. Note: this patch also links the client against the public library.
2015-04-19 16:36:53 +03:00
src/app/rpmostree-libbuiltin.h \
app: spawn polkit authentication agent Spawn pkttyagent when trying to call a method that may require authentication to give users a chance to provide auth right from the terminal. Since we're now relying on polkit for authorizing most of the OS interface methods, let's drop the root check on those. Closes: #894 Approved by: cgwalters
2017-07-25 19:59:56 +03:00
src/app/rpmostree-polkit-agent.c \
src/app/rpmostree-polkit-agent.h \
app/daemon: add groundwork for rpm-ostree kargs command This is initial groundwork for https://github.com/projectatomic/rpm-ostree/issues/594. This commit sets up most of the required front end logic( arg parsing, transaction handling), and will be used in the following commits. There is nothing really fancy in this commit, as most of the code shares the similar style between other dbus related commands. Closes: #1013 Approved by: cgwalters
2017-09-25 19:05:24 +03:00
src/app/rpmostree-builtin-kargs.c \
Convert some code to compile in C++ mode This is part of investigating using https://cxx.rs/ In order to make this really work, we need to convert some of our C code to C++ so we can include cxx.rs-generated code. This starts by converting just two files as a starting point. I did the minimal porting; I didn't try to actually rewrite them to resemble modern C++, just "C in C++ mode".
2020-11-22 22:55:06 +03:00
src/app/rpmostree-compose-builtin-tree.cxx \
Port rpmostree-composeutil to C++ Prep for using https://cxx.rs
2020-12-19 00:42:28 +03:00
src/app/rpmostree-composeutil.cxx \
compose: Split off composeutil.[ch] Prep for adding a new toplevel rojig command. It's also just cleaner to avoid cluttering up the main compose logic with distractions like the `_legacy_prep_dev()` bits. Closes: #1564 Approved by: jlebon
2018-09-19 16:48:04 +03:00
src/app/rpmostree-composeutil.h \
build: Split up src into `app/` and `libpriv/` We currently have an internal-only library, but the sources for it are in the same dir as the app. For future work on a public shared library, we'll need a clearer source structure. Start by just renaming the app files into `src/app/`, and the internal private library into `src/libpriv/`, with the appropriate `Makefile.am` changes. Closes: https://github.com/projectatomic/rpm-ostree/pull/123
2015-04-07 03:18:50 +03:00
src/app/rpmostree-builtin-compose.c \
buildsys: Compile daemon code directly with binary A long time ago we de-duplicated the daemon and binary into a single executable, but left the daemon code building as an internal static library. Let's take the next step and compile the sources directly as part of the executable build. For example, we can then de-duplicate the `CFLAGS/CXXFLAGS`. And in the future this will help us turn on LTO.
2020-12-17 01:17:49 +03:00
$(librpmostreed_sources) \
buildsys: Unify build of binary and internal shared library This completes the task of unifying the build of all of our C/C++ into a single unit, which avoids code duplication and will allow us to more easily use LTO in the future.
2020-12-17 01:04:40 +03:00
$(librpmostreepriv_sources) \
Unify rpm-ostree into one binary And start making an internal library.
2014-01-29 23:37:44 +04:00
$(NULL)
Add --disable-compose-tooling build option Some downstreams want the ability to separate the compose tooling from the client, for e.g. support reasons. This approach supports generating a tarball without the source for the compose command, and requires specifying a config option to disable it.
2014-09-17 05:45:30 +04:00
Add --enable-rojig, disable by default We're seeing some CI failures that I think are a bug in rojig. In the bigger picture...we never actually started using this, and I think longer term shipping os updates via containers probably makes more sense. I put a *lot* of effort into this code and it's pretty cool so it's hard to just delete it. And *maybe* someone out there is using it (but I doubt it). So rather than just deleting it entirely let's make it a build-time option. I verified that it builds at least.
2020-10-22 20:33:45 +03:00
if BUILDOPT_ROJIG
rpm_ostree_SOURCES += \
More C++ porting, round 6 Port rojig-build and rpm-util to C++. Prep for using https://cxx.rs/
2020-12-19 18:29:13 +03:00
src/app/rpmostree-ex-builtin-commit2rojig.cxx \
Port rojig2commit to C++ Prep for using https://cxx.rs/
2020-12-19 18:48:44 +03:00
src/app/rpmostree-ex-builtin-rojig2commit.cxx \
Port compose-builtin-rojig to C++ Prep for using https://cxx.rs/
2020-12-19 19:03:32 +03:00
src/app/rpmostree-compose-builtin-rojig.cxx \
Add --enable-rojig, disable by default We're seeing some CI failures that I think are a bug in rojig. In the bigger picture...we never actually started using this, and I think longer term shipping os updates via containers probably makes more sense. I put a *lot* of effort into this code and it's pretty cool so it's hard to just delete it. And *maybe* someone out there is using it (but I doubt it). So rather than just deleting it entirely let's make it a build-time option. I verified that it builds at least.
2020-10-22 20:33:45 +03:00
$(NULL)
endif
buildsys: Unify build of binary and internal shared library This completes the task of unifying the build of all of our C/C++ into a single unit, which avoids code duplication and will allow us to more easily use LTO in the future.
2020-12-17 01:04:40 +03:00
nodist_rpm_ostree_SOURCES = $(dbus_built_sources) $(nodist_librpmostreepriv_sources)
buildsys: Compile daemon code directly with binary A long time ago we de-duplicated the daemon and binary into a single executable, but left the daemon code building as an internal static library. Let's take the next step and compile the sources directly as part of the executable build. For example, we can then de-duplicate the `CFLAGS/CXXFLAGS`. And in the future this will help us turn on LTO.
2020-12-17 01:17:49 +03:00
Convert some code to compile in C++ mode This is part of investigating using https://cxx.rs/ In order to make this really work, we need to convert some of our C code to C++ so we can include cxx.rs-generated code. This starts by converting just two files as a starting point. I did the minimal porting; I didn't try to actually rewrite them to resemble modern C++, just "C in C++ mode".
2020-11-22 22:55:06 +03:00
rpmostree_common_cflags = -I$(srcdir)/src/app -I$(srcdir)/src/daemon \
Merge daemon binary into main binary The actual problem I am trying to fix with this is fallout from the introduction of `/usr/libexec/rpm-ostreed`, which required a SELinux policy change. Specifically for CentOS, the base policy is rev'd slowly. My hope was that by merging the daemon code back into `/usr/bin/rpm-ostree` which is labeled `install_exec_t`, starting via systemd would do the right thing. It turns out that doesn't happen. Now later, I'm picking this patch back up because I want to do multprocessing in the daemon (and in the core), and it makes sense to share code between them, because multiprocessing will need to go through a re-exec path. Another benefit is we avoid duplicated text (libglnx, internal helpers) between the two binaries. Closes: #292 Approved by: jlebon
2016-05-27 21:46:46 +03:00
-I$(srcdir)/src/lib -I$(srcdir)/src/libpriv -I$(libglnx_srcpath) \
buildsys: Compile daemon code directly with binary A long time ago we de-duplicated the daemon and binary into a single executable, but left the daemon code building as an internal static library. Let's take the next step and compile the sources directly as part of the executable build. For example, we can then de-duplicate the `CFLAGS/CXXFLAGS`. And in the future this will help us turn on LTO.
2020-12-17 01:17:49 +03:00
-fvisibility=hidden \
-DG_LOG_DOMAIN=\"rpm-ostreed\" \
-DLIBDIR=\"$(libdir)\" -DPKGLIBDIR=\"$(pkglibdir)\" \
$(PKGDEP_RPMOSTREE_CFLAGS)
Convert some code to compile in C++ mode This is part of investigating using https://cxx.rs/ In order to make this really work, we need to convert some of our C code to C++ so we can include cxx.rs-generated code. This starts by converting just two files as a starting point. I did the minimal porting; I didn't try to actually rewrite them to resemble modern C++, just "C in C++ mode".
2020-11-22 22:55:06 +03:00
rpm_ostree_CFLAGS = $(AM_CFLAGS) $(rpmostree_common_cflags)
rpm_ostree_CXXFLAGS = $(AM_CXXFLAGS) $(rpmostree_common_cflags)
buildsys: Unify build of binary and internal shared library This completes the task of unifying the build of all of our C/C++ into a single unit, which avoids code duplication and will allow us to more easily use LTO in the future.
2020-12-17 01:04:40 +03:00
rpm_ostree_LDADD = $(PKGDEP_RPMOSTREE_LIBS) $(CAP_LIBS) libglnx.la librpmostree-1.la
buildsys: Compile daemon code directly with binary A long time ago we de-duplicated the daemon and binary into a single executable, but left the daemon code building as an internal static library. Let's take the next step and compile the sources directly as part of the executable build. For example, we can then de-duplicate the `CFLAGS/CXXFLAGS`. And in the future this will help us turn on LTO.
2020-12-17 01:17:49 +03:00
EXTRA_rpm_ostree_DEPENDENCIES = libdnf.so.2
Split out postprocess+commit to separate script As this logic is of most interest to potential other consumers; it's not entangled with yum for example.
2014-01-16 16:26:54 +04:00
Initial import from pkgsys-ostree
2013-12-22 04:41:30 +04:00
privdatadir=$(pkglibdir)
tmpfiles.d: rename and re-order According to tmpfiles.d(5), files should follow the convention <package>.conf or <package>-<part>.conf. So we rename tmpfiles-ostree-integration.conf to rpm-ostree-0-integration.conf. The 0 index is so that the autovar conf created by postprocess is sourced *after* this one, so that `integration.conf` has higher precedence if there are duplicate entries. Closes: #325 Approved by: cgwalters
2016-06-15 23:30:11 +03:00
privdata_DATA = src/app/rpm-ostree-0-integration.conf
Add infrastructure for alternative name (currently nts) See https://github.com/projectatomic/rpm-ostree/issues/405 This patch adds an (off by default) `--enable-new-name` build option which currently defaults to `nts`. This is purely additive, and the intention is that we'll support the rpm-ostree name in perpetuity most likely. At the moment, we add a new name for: - /usr/bin/$name - The systemd unit file But we notably *don't* attempt to add a new name to the DBus API, as it'd be a lot more invasive of a patch, and less payoff (it's mostly just programs/scripts that interact with the DBus). Closes: #497 Approved by: jlebon
2016-10-19 21:24:40 +03:00
build-sys: Propagate Automake verbose mode to Rust/cargo This is analogous to commit c62058e54860165899581fa11de2d7a956bca7d5 which propagated `V=1` into `cmake`. Except if the build *isn't* verbose (for local development), let's not force `--verbose` on for Rust. Closes: #1583 Approved by: jlebon
2018-09-26 17:23:48 +03:00
# Propagate automake verbose mode
cargo_build = $(cargo) build $(if $(subst 0,,$(V)),--verbose,)
Default to sqlite rpmdb backend on f34 There won't be any support for writing to the bdb backend in f34, so e.g. pkglayering won't work (and obviously even composes wouldn't work once the buildroot moves to f34). Instead of requiring the whole world to add an `rpmdb` key in their manifests, let's just add a compile flag for it, and tweak the spec file to use this flag on f34.
2020-12-22 01:27:52 +03:00
if BUILDOPT_ENABLE_SQLITE_RPMDB_DEFAULT
cargo_build += --features sqlite-rpmdb-default
endif
Move bindgen into tooling/, add dependabot Prep for adding cxxbridge-cmd which we need to vendor too.
2020-12-04 02:38:30 +03:00
tooling_src = bindgen/Cargo.toml bindgen/src/main.rs
tooling-build:
cd $(top_srcdir)/tooling && $(cargo_build) --release --all-targets
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
if !HAVE_PREBUILT_CBINDGEN
if !HAVE_EXTERNAL_CBINDGEN
Move bindgen into tooling/, add dependabot Prep for adding cxxbridge-cmd which we need to vendor too.
2020-12-04 02:38:30 +03:00
rpmostree-bindgen: tooling-build
ln -sf tooling/target/release/rpmostree-bindgen $(abs_top_builddir)/rpmostree-bindgen
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
endif
endif
Move bindgen into tooling/, add dependabot Prep for adding cxxbridge-cmd which we need to vendor too.
2020-12-04 02:38:30 +03:00
GITIGNOREFILES += tooling/target/ rpmostree-bindgen
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
build-sys: Make Rust library naming/entrypoint more generic Prep for adding more functionality beyond treefile bits. Closes: #1444 Approved by: jlebon
2018-07-04 21:50:40 +03:00
librpmostree_rust_path = @abs_top_builddir@/target/@RUST_TARGET_SUBDIR@/librpmostree_rust.a
build-sys: Just error out if building with multiple uids The `--frozen` stuff ends up being annoying when switching branches. What we're really trying to protect against here is the `sudo make install` problem, so let's test for that more directly by verifying the uids. (The previous code was also totally broken as it used `$` where `$$` should have been in multiple places) Closes: #1601 Approved by: cgwalters
2018-10-12 20:40:56 +03:00
# If the target directory exists, and isn't owned by our uid, then
# we exit with a fatal error, since someone probably did `make && sudo make install`,
# and in this case cargo will download into ~/.root which we don't want.
Move the main Rust infra (i.e. Cargo.toml) to the toplevel I think we should have done this as soon as it was clear that Rust was sticking and not just an optional thing. Reasons to make this change now: - More clear that Rust is going to be the majority of code in the future - `cargo build` and `cargo test` in a fresh git clone Just Work - Paves the way for using `cargo` to build C/C++ instead of Automake
2020-12-08 21:29:05 +03:00
LIBRPMOSTREE_RUST_SRCS = $(shell find rust/src/ -name '*.rs') Cargo.toml Cargo.lock cbindgen.toml
build-sys: Make Rust library naming/entrypoint more generic Prep for adding more functionality beyond treefile bits. Closes: #1444 Approved by: jlebon
2018-07-04 21:50:40 +03:00
$(librpmostree_rust_path): Makefile $(LIBRPMOSTREE_RUST_SRCS)
Move the main Rust infra (i.e. Cargo.toml) to the toplevel I think we should have done this as soon as it was clear that Rust was sticking and not just an optional thing. Reasons to make this change now: - More clear that Rust is going to be the majority of code in the future - `cargo build` and `cargo test` in a fresh git clone Just Work - Paves the way for using `cargo` to build C/C++ instead of Automake
2020-12-08 21:29:05 +03:00
$(cargo_build) $(CARGO_RELEASE_ARGS)
EXTRA_DIST += $(LIBRPMOSTREE_RUST_SRCS)
Add support for YAML treefiles Let's modernize and start supporting YAML treefiles. I'll dare make the sweeping generalization that most people would prefer reading and writing YAML over JSON. This takes bits from coreos-assembler[1] that know how to serialize a YAML file and spit it back out as a JSON and makes it into a shared lib that we can link against. We could use this eventually for JSON inputs as well to force a validation check before composing. If we go this route, we could then turn on `--enable-rust` in FAHC for now and drop the duplicate code in coreos-assembler. [1] https://github.com/cgwalters/coreos-assembler Closes: #1377 Approved by: cgwalters
2018-05-31 23:31:22 +03:00
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
# Generate bindings from Rust to C
Fix and improve support for rpmostree-rust.h being pre-generated First, we now need the `vendor/` directory at the toplevel because that's where `Cargo.toml` is. Now this triggers another bug introduced in the build system with how we're handling the `rpmostree-rust.h` header. We ended up vendoring a pre-generated one in the tarball mainly because RHEL doesn't include cbindgen. Now probably in the future I'd like to fix that. But let's clean this up - the tarball generation process copies the file into `rpmostree-rust-prebuilt.h`, and build machinery detects that and entirely skips looking for or trying to build our internal cbindgen.
2020-12-11 18:09:57 +03:00
if BUILDOPT_PREBUILT_BINDINGS
rpmostree-rust.h:
ln -sfr rpmostree-rust-prebuilt.h $@
else
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
if !HAVE_PREBUILT_CBINDGEN
if HAVE_EXTERNAL_CBINDGEN
build-sys: With external cbindgen, drop Rust lib dependency Perhaps an unexpected side benefit of slow compilation processes is that one has an opportunity to reflect and ponder. I realized during exactly such a moment that since we moved `cbindgen` out of our library build, there's no need to wait for the library to be built before we can start building the C code. This is a notable local quality-of-life development improvement. Closes: #1665 Approved by: jlebon
2018-11-05 21:04:45 +03:00
rpmostree-rust.h:
Makefile-rpm-ostree: fix path to cbindgen.toml Minor regression from #2365.
2020-12-22 00:55:21 +03:00
$(AM_V_GEN) cbindgen -c cbindgen.toml -o $@ $(top_srcdir)
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
else
build-sys: With external cbindgen, drop Rust lib dependency Perhaps an unexpected side benefit of slow compilation processes is that one has an opportunity to reflect and ponder. I realized during exactly such a moment that since we moved `cbindgen` out of our library build, there's no need to wait for the library to be built before we can start building the C code. This is a notable local quality-of-life development improvement. Closes: #1665 Approved by: jlebon
2018-11-05 21:04:45 +03:00
rpmostree-rust.h: rpmostree-bindgen
Move the main Rust infra (i.e. Cargo.toml) to the toplevel I think we should have done this as soon as it was clear that Rust was sticking and not just an optional thing. Reasons to make this change now: - More clear that Rust is going to be the majority of code in the future - `cargo build` and `cargo test` in a fresh git clone Just Work - Paves the way for using `cargo` to build C/C++ instead of Automake
2020-12-08 21:29:05 +03:00
$(AM_V_GEN) ./rpmostree-bindgen $(top_srcdir)
Split cbindgen to separate build, support external version The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: https://github.com/projectatomic/rpm-ostree/issues/1557 Closes: #1573 Approved by: jlebon
2018-09-22 01:02:18 +03:00
endif
endif
Fix and improve support for rpmostree-rust.h being pre-generated First, we now need the `vendor/` directory at the toplevel because that's where `Cargo.toml` is. Now this triggers another bug introduced in the build system with how we're handling the `rpmostree-rust.h` header. We ended up vendoring a pre-generated one in the tarball mainly because RHEL doesn't include cbindgen. Now probably in the future I'd like to fix that. But let's clean this up - the tarball generation process copies the file into `rpmostree-rust-prebuilt.h`, and build machinery detects that and entirely skips looking for or trying to build our internal cbindgen.
2020-12-11 18:09:57 +03:00
endif
BUILT_SOURCES += rpmostree-rust.h
Use cbindgen If we're going to scale out our oxidation, let's follow the path of Firefox (and other projects) further and use cbindgen: https://github.com/eqrion/cbindgen It's actually nice that `cbindgen` is packaged today in Fedora, but I doubt it is elsewhere; we may end up needing to push that forward, or just vendor it via a `build.rs` script and Cargo. I chose to rename things to `ROR`/`ror_` since it's shorter. I am tempted a bit to rename our internal functions to just `ro_` to or so. Closes: #1516 Approved by: jlebon
2018-08-24 17:42:31 +03:00
rpm_ostree_CFLAGS += $(PKGDEP_RPMOSTREE_RS_CFLAGS)
Convert some code to compile in C++ mode This is part of investigating using https://cxx.rs/ In order to make this really work, we need to convert some of our C code to C++ so we can include cxx.rs-generated code. This starts by converting just two files as a starting point. I did the minimal porting; I didn't try to actually rewrite them to resemble modern C++, just "C in C++ mode".
2020-11-22 22:55:06 +03:00
rpm_ostree_LDADD += $(librpmostree_rust_path) $(PKGDEP_RPMOSTREE_RS_LIBS) -lstdc++
build-sys: Add a `rust-test` target I often am editing just the Rust code, and want the fast iteration feedback of a `cargo test` - don't want to pay the cost of full optimization (particularly LTO) for the release build, and I *just* want to run the Rust tests. Basically if you're editing our Rust code a lot, this target is your friend. Closes: #1585 Approved by: jlebon
2018-09-26 17:43:18 +03:00
# Wraps `cargo test`. This is always a debug non-release build;
# the main thing here is we still drop the `target` dir in our build
# directory, since we nominally support srcdir != builddir.
rust-test:
cd $(top_srcdir)/rust && CARGO_TARGET_DIR=@abs_top_builddir@/target cargo test
.PHONY: rust-test
Reference in New Issue Copy Permalink