keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
a4487578a7
rpm-ostree/tests/check/test-utils.cxx

188 lines
10 KiB
C++
Raw Normal View History

tests: Add unit tests for varsubst Trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1381357 I don't see the problem yet, but let's exercise the code a bit. Closes: #755 Approved by: jlebon
2017-04-27 20:40:34 +03:00
#include "config.h"
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <glib-unix.h>
#include "libglnx.h"
libpriv: Directly parse NEVRAs, don't use branches When I initially added support for local RPM layering (#657), I was operating under the assumption that there is no reliable way to parse a NEVRA back to its constituent elements. So we worked around this by doing lookups in the pkgcache and comparing against branches converted back to their NEVRAs, which was pretty hacky. Later on, I learned that you *can* reliably parse a NEVRA back to its elements because RPM forbids all fields from having a colon `:` and all fields other than the package name to have a dash `-`. In fact, there is a helper from `libdnf` to do exactly this. This patch swaps out the old way of decomposing NEVRAs and converting NEVRAs to their cache branch notation with a simpler more direct approach using the helper function from `libdnf`. Closes: #1395 Approved by: cgwalters
2018-06-08 22:48:05 +03:00
#include "rpmostree-rpm-util.h"
tests: merge cache_branch_to_nevra into test-utils I didn't realize at the time I wrote the cache_branch_to_nevra test that the already existing test-utils.c would be the perfect place to add this test. Merge the two together now. Closes: #847 Approved by: cgwalters
2017-06-23 04:47:59 +03:00
#include "rpmostree-core.h"
libpriv: Rename "unpacker" to "importer", split off "unpacker-core" In the jigdo path we don't actually want to import the OIRPM literally into ostree. I considered adding jigdo logic into `rpmostree-unpacker.c` but it'd be a mess as the functionality is quite logically separate from importing. So split off an `unpacker-core.c` file which has the bare libarchive+RPM helpers, and rename `RpmOstreeUnpacker` to `RpmOstreeImporter`. Closes: #1110 Approved by: jlebon
2017-11-18 00:57:05 +03:00
#include "rpmostree-importer.h"
tests: transition to build_rpm Nuke all the previous goop that was used to create RPMs at `make check` time and transition all the tests to use the new `build_rpm` function. It definitely feels cleaner to use. It's also really nice to have the spec live in the same file as the test that uses it. Closes: #854 Approved by: cgwalters
2017-06-29 17:11:25 +03:00
#include "libtest.h"
tests: Add unit tests for varsubst Trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1381357 I don't see the problem yet, but let's exercise the code a bit. Closes: #755 Approved by: jlebon
2017-04-27 20:40:34 +03:00
tests: merge cache_branch_to_nevra into test-utils I didn't realize at the time I wrote the cache_branch_to_nevra test that the already existing test-utils.c would be the perfect place to add this test. Merge the two together now. Closes: #847 Approved by: cgwalters
2017-06-23 04:47:59 +03:00
static void
test_one_cache_branch_to_nevra (const char *cache_branch,
const char *expected_nevra)
{
g_autofree char *actual_nevra =
rpmostree_cache_branch_to_nevra (cache_branch);
g_print ("comparing %s to %s\n", expected_nevra, actual_nevra);
g_assert (g_str_equal (expected_nevra, actual_nevra));
libpriv: Directly parse NEVRAs, don't use branches When I initially added support for local RPM layering (#657), I was operating under the assumption that there is no reliable way to parse a NEVRA back to its constituent elements. So we worked around this by doing lookups in the pkgcache and comparing against branches converted back to their NEVRAs, which was pretty hacky. Later on, I learned that you *can* reliably parse a NEVRA back to its elements because RPM forbids all fields from having a colon `:` and all fields other than the package name to have a dash `-`. In fact, there is a helper from `libdnf` to do exactly this. This patch swaps out the old way of decomposing NEVRAs and converting NEVRAs to their cache branch notation with a simpler more direct approach using the helper function from `libdnf`. Closes: #1395 Approved by: cgwalters
2018-06-08 22:48:05 +03:00
g_autofree char *actual_branch = NULL;
g_assert (rpmostree_nevra_to_cache_branch (expected_nevra, &actual_branch, NULL));
g_assert (g_str_equal (cache_branch, actual_branch));
tests: merge cache_branch_to_nevra into test-utils I didn't realize at the time I wrote the cache_branch_to_nevra test that the already existing test-utils.c would be the perfect place to add this test. Merge the two together now. Closes: #847 Approved by: cgwalters
2017-06-23 04:47:59 +03:00
}
static void
test_cache_branch_to_nevra (void)
{
/* pkgs imported from doing install foo git vim-enhanced and outputs of
* install and ostree refs massaged with sort and paste and column --table */
test_one_cache_branch_to_nevra ("rpmostree/pkg/foo/1.0-1.x86__64", "foo-1.0-1.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/git/1.8.3.1-6.el7__2.1.x86__64", "git-1.8.3.1-6.el7_2.1.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/gpm-libs/1.20.7-5.el7.x86__64", "gpm-libs-1.20.7-5.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/libgnome-keyring/3.8.0-3.el7.x86__64", "libgnome-keyring-3.8.0-3.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl/4_3A5.16.3-291.el7.x86__64", "perl-4:5.16.3-291.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Carp/1.26-244.el7.noarch", "perl-Carp-1.26-244.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-constant/1.27-2.el7.noarch", "perl-constant-1.27-2.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Encode/2.51-7.el7.x86__64", "perl-Encode-2.51-7.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Error/1_3A0.17020-2.el7.noarch", "perl-Error-1:0.17020-2.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Exporter/5.68-3.el7.noarch", "perl-Exporter-5.68-3.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-File-Path/2.09-2.el7.noarch", "perl-File-Path-2.09-2.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-File-Temp/0.23.01-3.el7.noarch", "perl-File-Temp-0.23.01-3.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Filter/1.49-3.el7.x86__64", "perl-Filter-1.49-3.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Getopt-Long/2.40-2.el7.noarch", "perl-Getopt-Long-2.40-2.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Git/1.8.3.1-6.el7__2.1.noarch", "perl-Git-1.8.3.1-6.el7_2.1.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-HTTP-Tiny/0.033-3.el7.noarch", "perl-HTTP-Tiny-0.033-3.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-libs/4_3A5.16.3-291.el7.x86__64", "perl-libs-4:5.16.3-291.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-macros/4_3A5.16.3-291.el7.x86__64", "perl-macros-4:5.16.3-291.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-parent/1_3A0.225-244.el7.noarch", "perl-parent-1:0.225-244.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-PathTools/3.40-5.el7.x86__64", "perl-PathTools-3.40-5.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Pod-Escapes/1_3A1.04-291.el7.noarch", "perl-Pod-Escapes-1:1.04-291.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-podlators/2.5.1-3.el7.noarch", "perl-podlators-2.5.1-3.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Pod-Perldoc/3.20-4.el7.noarch", "perl-Pod-Perldoc-3.20-4.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Pod-Simple/1_3A3.28-4.el7.noarch", "perl-Pod-Simple-1:3.28-4.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Pod-Usage/1.63-3.el7.noarch", "perl-Pod-Usage-1.63-3.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Scalar-List-Utils/1.27-248.el7.x86__64", "perl-Scalar-List-Utils-1.27-248.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Socket/2.010-4.el7.x86__64", "perl-Socket-2.010-4.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Storable/2.45-3.el7.x86__64", "perl-Storable-2.45-3.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-TermReadKey/2.30-20.el7.x86__64", "perl-TermReadKey-2.30-20.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Text-ParseWords/3.29-4.el7.noarch", "perl-Text-ParseWords-3.29-4.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-threads/1.87-4.el7.x86__64", "perl-threads-1.87-4.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-threads-shared/1.43-6.el7.x86__64", "perl-threads-shared-1.43-6.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Time-HiRes/4_3A1.9725-3.el7.x86__64", "perl-Time-HiRes-4:1.9725-3.el7.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/perl-Time-Local/1.2300-2.el7.noarch", "perl-Time-Local-1.2300-2.el7.noarch");
test_one_cache_branch_to_nevra ("rpmostree/pkg/vim-common/2_3A7.4.160-1.el7__3.1.x86__64", "vim-common-2:7.4.160-1.el7_3.1.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/vim-enhanced/2_3A7.4.160-1.el7__3.1.x86__64", "vim-enhanced-2:7.4.160-1.el7_3.1.x86_64");
test_one_cache_branch_to_nevra ("rpmostree/pkg/vim-filesystem/2_3A7.4.160-1.el7__3.1.x86__64", "vim-filesystem-2:7.4.160-1.el7_3.1.x86_64");
}
libpriv/rpm-util: insert pkglist metadata sorted To make the new pkglist metadata even more usable, let's insert it sorted. This ensures that we can bsearch the GVariant on the client-side. Enhance the bsearch utility function we have to deal with duplicate key names. Although this is not the case today in rpm-ostree-managed streams I know, some packages are allowed to have multiple versions installed, so let's make sure we handle that deterministically by always returning the first (earliest) version of the package. Closes: #1158 Approved by: cgwalters
2017-12-15 19:45:33 +03:00
static void
test_bsearch_str(void)
{
g_auto(GVariantBuilder) builder;
g_variant_builder_init (&builder, G_VARIANT_TYPE ("a(st)"));
g_variant_builder_add (&builder, "(st)", "armadillo", 0);
g_variant_builder_add (&builder, "(st)", "bunny", 1);
g_variant_builder_add (&builder, "(st)", "bunny", 2);
g_variant_builder_add (&builder, "(st)", "chipmunk", 3);
g_variant_builder_add (&builder, "(st)", "chipmunk", 4);
g_variant_builder_add (&builder, "(st)", "chipmunk", 5);
g_variant_builder_add (&builder, "(st)", "dung beetle", 6);
g_variant_builder_add (&builder, "(st)", "earwig", 7);
g_variant_builder_add (&builder, "(st)", "earwig", 8);
g_autoptr(GVariant) cool_animals = g_variant_ref_sink (g_variant_builder_end (&builder));
int idx;
g_assert (rpmostree_variant_bsearch_str (cool_animals, "armadillo", &idx));
g_assert_cmpint (idx, ==, 0);
g_assert (rpmostree_variant_bsearch_str (cool_animals, "bunny", &idx));
g_assert_cmpint (idx, ==, 1);
g_assert (rpmostree_variant_bsearch_str (cool_animals, "chipmunk", &idx));
g_assert_cmpint (idx, ==, 3);
g_assert (rpmostree_variant_bsearch_str (cool_animals, "dung beetle", &idx));
g_assert_cmpint (idx, ==, 6);
g_assert (rpmostree_variant_bsearch_str (cool_animals, "earwig", &idx));
g_assert_cmpint (idx, ==, 7);
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "aaaa", &idx));
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "armz", &idx));
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "bunz", &idx));
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "chiz", &idx));
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "dunz", &idx));
g_assert (!rpmostree_variant_bsearch_str (cool_animals, "earz", &idx));
}
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
static void
test_variant_to_nevra(void)
{
check/test-utils.c: assert no error first Minor tweak; use g_assert_no_error() before using g_assert(ret) so that we actually get a printout of the error the test fails. Closes: #854 Approved by: cgwalters
2017-06-29 16:52:06 +03:00
gboolean ret = FALSE;
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
GError *error = NULL;
tree-wide: Port to ostree_repo_{open,create}_at() A lot of code gets nicer. Closes: #922 Approved by: jlebon
2017-08-17 16:37:33 +03:00
g_autoptr(OstreeRepo) repo =
ostree_repo_create_at (AT_FDCWD, "repo", OSTREE_REPO_MODE_BARE_USER,
NULL, NULL, &error);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_assert_no_error (error);
tree-wide: Port to ostree_repo_{open,create}_at() A lot of code gets nicer. Closes: #922 Approved by: jlebon
2017-08-17 16:37:33 +03:00
g_assert (repo);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
const char *nevra = "foo-1.0-1.x86_64";
const char *name = "foo";
guint64 epoch = 0;
const char *version = "1.0";
const char *release = "1";
const char *arch = "x86_64";
tests: transition to build_rpm Nuke all the previous goop that was used to create RPMs at `make check` time and transition all the tests to use the new `build_rpm` function. It definitely feels cleaner to use. It's also really nice to have the spec live in the same file as the test that uses it. Closes: #854 Approved by: cgwalters
2017-06-29 17:11:25 +03:00
ret = rot_test_run_libtest ("build_rpm foo", &error);
g_assert_no_error (error);
g_assert (ret);
Change unpacking to use a single ostree txn Right now each ostree txn incurs a `syncfs()`; see https://github.com/ostreedev/ostree/issues/1184 And before this patch, we were doing a txn per package import. We can really do better in libostree - we'll fix that, but in the short term let's use a bigger txn for every package. However, the obvious change here of simply hoisting up the txn is that on failure for imports, we'd discard all downloaded packages. We fix that by changing the auto txn API to have a `commit_on_failure` boolean, and use it in cases where we're doing imports. This is prep work for jigdo, where we'll be using the import path all the time. My bigger plan is to do multithreaded imports. Closes: #1116 Approved by: jlebon
2017-11-28 21:55:50 +03:00
{ g_auto(RpmOstreeRepoAutoTransaction) txn = { 0, };
/* Note use of commit-on-failure */
rpmostree_repo_auto_transaction_start (&txn, repo, TRUE, NULL, &error);
g_assert_no_error (error);
g_autoptr(RpmOstreeImporter) importer = NULL;
g_autofree char *foo_rpm = g_strdup_printf ("yumrepo/packages/%s/%s.rpm", arch, nevra);
importer: Rework API Now that the importer *only* imports into OSTree repos, let's clean up the API so that the `OstreeRepo` and `OstreeSePolicy` are passed as constructor args. Also rework things so there's only one constructor API that steals the fd. This is prep for adding another async import API. Closes: #1124 Approved by: jlebon
2017-12-01 22:49:20 +03:00
glnx_autofd int foo_fd = -1;
glnx_openat_rdonly (AT_FDCWD, foo_rpm, TRUE, &foo_fd, &error);
g_assert_no_error (error);
Make `make check` work again Our CI isn't running the C unit tests because it goes via RPM, and while we could potentially add `%check` there...I don't quite want to do that right now since it also runs the Rust tests which means we rebuild all the Rust code again in debug mode etc. Change the C unit tests to compile in C++ mode, which is enough for local testing. Longer term I think the C unit tests will go away in favor of Rust tests.
2021-01-20 19:40:30 +03:00
importer = rpmostree_importer_new_take_fd (&foo_fd, repo, NULL, (RpmOstreeImporterFlags)0, NULL, &error);
Change unpacking to use a single ostree txn Right now each ostree txn incurs a `syncfs()`; see https://github.com/ostreedev/ostree/issues/1184 And before this patch, we were doing a txn per package import. We can really do better in libostree - we'll fix that, but in the short term let's use a bigger txn for every package. However, the obvious change here of simply hoisting up the txn is that on failure for imports, we'd discard all downloaded packages. We fix that by changing the auto txn API to have a `commit_on_failure` boolean, and use it in cases where we're doing imports. This is prep work for jigdo, where we'll be using the import path all the time. My bigger plan is to do multithreaded imports. Closes: #1116 Approved by: jlebon
2017-11-28 21:55:50 +03:00
g_assert_no_error (error);
g_assert (importer);
importer: Rework API Now that the importer *only* imports into OSTree repos, let's clean up the API so that the `OstreeRepo` and `OstreeSePolicy` are passed as constructor args. Also rework things so there's only one constructor API that steals the fd. This is prep for adding another async import API. Closes: #1124 Approved by: jlebon
2017-12-01 22:49:20 +03:00
ret = rpmostree_importer_run (importer, NULL, NULL, &error);
Change unpacking to use a single ostree txn Right now each ostree txn incurs a `syncfs()`; see https://github.com/ostreedev/ostree/issues/1184 And before this patch, we were doing a txn per package import. We can really do better in libostree - we'll fix that, but in the short term let's use a bigger txn for every package. However, the obvious change here of simply hoisting up the txn is that on failure for imports, we'd discard all downloaded packages. We fix that by changing the auto txn API to have a `commit_on_failure` boolean, and use it in cases where we're doing imports. This is prep work for jigdo, where we'll be using the import path all the time. My bigger plan is to do multithreaded imports. Closes: #1116 Approved by: jlebon
2017-11-28 21:55:50 +03:00
g_assert_no_error (error);
g_assert (ret);
ostree_repo_commit_transaction (repo, NULL, NULL, &error);
g_assert_no_error (error);
txn.initialized = FALSE;
}
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_autoptr(GVariant) header = NULL;
check/test-utils.c: assert no error first Minor tweak; use g_assert_no_error() before using g_assert(ret) so that we actually get a printout of the error the test fails. Closes: #854 Approved by: cgwalters
2017-06-29 16:52:06 +03:00
ret = rpmostree_pkgcache_find_pkg_header (repo, nevra, NULL, &header, NULL, &error);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_assert_no_error (error);
check/test-utils.c: assert no error first Minor tweak; use g_assert_no_error() before using g_assert(ret) so that we actually get a printout of the error the test fails. Closes: #854 Approved by: cgwalters
2017-06-29 16:52:06 +03:00
g_assert (ret);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_autofree char *tname;
guint64 tepoch;
g_autofree char *tversion;
g_autofree char *trelease;
g_autofree char *tarch;
libpriv: Directly parse NEVRAs, don't use branches When I initially added support for local RPM layering (#657), I was operating under the assumption that there is no reliable way to parse a NEVRA back to its constituent elements. So we worked around this by doing lookups in the pkgcache and comparing against branches converted back to their NEVRAs, which was pretty hacky. Later on, I learned that you *can* reliably parse a NEVRA back to its elements because RPM forbids all fields from having a colon `:` and all fields other than the package name to have a dash `-`. In fact, there is a helper from `libdnf` to do exactly this. This patch swaps out the old way of decomposing NEVRAs and converting NEVRAs to their cache branch notation with a simpler more direct approach using the helper function from `libdnf`. Closes: #1395 Approved by: cgwalters
2018-06-08 22:48:05 +03:00
ret = rpmostree_decompose_nevra (nevra, &tname, &tepoch, &tversion,
&trelease, &tarch, &error);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_assert_no_error (error);
check/test-utils.c: assert no error first Minor tweak; use g_assert_no_error() before using g_assert(ret) so that we actually get a printout of the error the test fails. Closes: #854 Approved by: cgwalters
2017-06-29 16:52:06 +03:00
g_assert (ret);
unpacker: encode NEVRA info in commit metadata It seems silly that to find out more detailed information about the NEVRA of a cached pkg, we have to resort to write out the header to disk, then reading it back in with librpm in order to tease out the info we want. Let's just encode that information directly in the commit metadata and provide a helper to fetch it. Closes: #847 Approved by: cgwalters
2017-06-23 04:53:38 +03:00
g_assert_cmpstr (tname, ==, name);
g_assert_cmpuint (tepoch, ==, epoch);
g_assert_cmpstr (tversion, ==, version);
g_assert_cmpstr (trelease, ==, release);
g_assert_cmpstr (tarch, ==, arch);
}
tests: Add unit tests for varsubst Trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1381357 I don't see the problem yet, but let's exercise the code a bit. Closes: #755 Approved by: jlebon
2017-04-27 20:40:34 +03:00
int
main (int argc,
char *argv[])
{
g_test_init (&argc, &argv, NULL);
tests: merge cache_branch_to_nevra into test-utils I didn't realize at the time I wrote the cache_branch_to_nevra test that the already existing test-utils.c would be the perfect place to add this test. Merge the two together now. Closes: #847 Approved by: cgwalters
2017-06-23 04:47:59 +03:00
g_test_add_func ("/utils/cachebranch_to_nevra", test_cache_branch_to_nevra);
libpriv/rpm-util: insert pkglist metadata sorted To make the new pkglist metadata even more usable, let's insert it sorted. This ensures that we can bsearch the GVariant on the client-side. Enhance the bsearch utility function we have to deal with duplicate key names. Although this is not the case today in rpm-ostree-managed streams I know, some packages are allowed to have multiple versions installed, so let's make sure we handle that deterministically by always returning the first (earliest) version of the package. Closes: #1158 Approved by: cgwalters
2017-12-15 19:45:33 +03:00
g_test_add_func ("/utils/bsearch_str", test_bsearch_str);
libpriv: Rename "unpacker" to "importer", split off "unpacker-core" In the jigdo path we don't actually want to import the OIRPM literally into ostree. I considered adding jigdo logic into `rpmostree-unpacker.c` but it'd be a mess as the functionality is quite logically separate from importing. So split off an `unpacker-core.c` file which has the bare libarchive+RPM helpers, and rename `RpmOstreeUnpacker` to `RpmOstreeImporter`. Closes: #1110 Approved by: jlebon
2017-11-18 00:57:05 +03:00
g_test_add_func ("/importer/variant_to_nevra", test_variant_to_nevra);
tests: Add unit tests for varsubst Trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1381357 I don't see the problem yet, but let's exercise the code a bit. Closes: #755 Approved by: jlebon
2017-04-27 20:40:34 +03:00
return g_test_run ();
}
Reference in New Issue Copy Permalink