rpm-ostree/ci/build-check.sh

#!/usr/bin/bash
# Install build dependencies, run unit tests and installed tests.

set -xeuo pipefail

dn=$(dirname $0)
. ${dn}/libbuild.sh
${dn}/build.sh
# NB: avoid make function because our RPM building doesn't
# support parallel runs right now
/usr/bin/make check
make install

# And now a clang build with -Werror turned on. We can't do this with gcc (in
# build.sh) because it doesn't support -Wno-error=macro-redefined, (and neither
# does clang on CentOS). Anyway, all we want is at least one clang run.
if test -x /usr/bin/clang; then
  # Except unused-command-line-argument:
  #   error: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened    -cc1' [-Werror,-Wunused-command-line-argument]
  # Except for macro-redefined:
  #   /usr/include/python2.7/pyconfig-64.h:1199:9: error: '_POSIX_C_SOURCE' macro redefined
  export CFLAGS="-Wall -Werror -Wno-error=macro-redefined -Wno-error=unused-command-line-argument ${CFLAGS:-}"
  export CC=clang
  git clean -dfx && git submodule foreach git clean -dfx
  build
fi
ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`#!/usr/bin/bash`
			`# Install build dependencies, run unit tests and installed tests.`

			`set -xeuo pipefail`

			`dn=$(dirname $0)`
			`. ${dn}/libbuild.sh`
			`${dn}/build.sh`
libbuild.sh: pass arguments to make Otherwise, e.g. `make check` && `make install` won't actually do anything. Closes: #765 Approved by: cgwalters 2017-05-05 22:56:53 +03:00			`# NB: avoid make function because our RPM building doesn't`
			`# support parallel runs right now`
			`/usr/bin/make check`
ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`make install`
ci: run clang build with -Werror Start running `clang` with `-Werror` like ostree. We can only run this on Fedora right now because the CentOS `clang` doesn't support `-Wno-error=macro-redefined`, though that's fine. Closes: #1036 Approved by: cgwalters 2017-10-04 22:48:26 +03:00
			`# And now a clang build with -Werror turned on. We can't do this with gcc (in`
			`# build.sh) because it doesn't support -Wno-error=macro-redefined, (and neither`
			`# does clang on CentOS). Anyway, all we want is at least one clang run.`
			`if test -x /usr/bin/clang; then`
			`# Except unused-command-line-argument:`
			`# error: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened -cc1' [-Werror,-Wunused-command-line-argument]`
			`# Except for macro-redefined:`
			`# /usr/include/python2.7/pyconfig-64.h:1199:9: error: '_POSIX_C_SOURCE' macro redefined`
			`export CFLAGS="-Wall -Werror -Wno-error=macro-redefined -Wno-error=unused-command-line-argument ${CFLAGS:-}"`
			`export CC=clang`
			`git clean -dfx && git submodule foreach git clean -dfx`
			`build`
			`fi`