rpm-ostree/ci/build-check.sh

#!/usr/bin/bash
# Install build dependencies, run unit tests and installed tests.

# This script is what Prow runs.

set -xeuo pipefail

dn=$(dirname $0)
. ${dn}/libbuild.sh
# Hard fail on compiler warnings in CI.  We control our compiler
# version as part of the coreos-assembler buildroot and expect
# that to be clean.
CONFIGOPTS="--enable-werror" ${dn}/build.sh
make check
ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`#!/usr/bin/bash`
			`# Install build dependencies, run unit tests and installed tests.`

ci: Add `~/.cargo/bin` to PATH in Prow path as well This matches what we do in CoreOS CI. 2020-12-23 20:31:34 +03:00			`# This script is what Prow runs.`

ci: Delete dockerfile, move to common scripts, consolidate gcc/clang The Dockerfile is problematic since we can't update it atomically. I also really dislike reliance on the Hub. Further, I think rather than caching our build deps as built containers, we should be caching RPMs in CI. And we should be using rpm-ostree at some point to assemble filesystem trees faster. Also, consolidate the clang to be serial with gcc, since while we lose a tiny bit of parallelism, it's not really worth its own context right now. Closes: #759 Approved by: jlebon 2017-04-28 19:29:25 +03:00			`set -xeuo pipefail`

			`dn=$(dirname $0)`
			`. ${dn}/libbuild.sh`
build-sys: Add --enable-werror, rework compiler flags So...at some point we somehow lost `-Wall` in our default compiler flags which means we were missing some potentially important warnings. And we used to have `-Werror` on in CI which combined with the above was strongly opinionated about not landing warnings in git master. Our default stance here remains the same; we have an opinionated set of `-Werror=` that applies in all configurations. However that set moves into Automake - I don't think we need to do compiler version detection anymore, we can assume a modern compiler. We also add back in `-Wall` by default now. Further in CI, add `-Werror`. The implementation here is in our buildsystem rather than `export CXXFLAGS=-Werror` because unfortunately we have to fix things in libdnf too, and I don't want to block entirely on that. 2021-02-08 21:22:34 +03:00			`# Hard fail on compiler warnings in CI. We control our compiler`
			`# version as part of the coreos-assembler buildroot and expect`
			`# that to be clean.`
			`CONFIGOPTS="--enable-werror" ${dn}/build.sh`
ci: Re-enable `make check` This seems to work for me; we want to run the C unit tests. 2021-01-27 22:06:39 +03:00			`make check`