From 09b2ca0482103111ad51fc3df4d3e4eb59cbfa4d Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Fri, 1 Jun 2018 13:58:16 -0400 Subject: [PATCH] tests/vmcheck: Fix override remove test We were trying to test that doing `override remove` on a layered package errored out. But the test was bogus since `foo` is a base package here. Let's just use a brand new package that will actually be layered. Closes: #1382 Approved by: jlebon --- tests/vmcheck/test-override-remove.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/vmcheck/test-override-remove.sh b/tests/vmcheck/test-override-remove.sh index d066ac91..f7ce46b0 100755 --- a/tests/vmcheck/test-override-remove.sh +++ b/tests/vmcheck/test-override-remove.sh @@ -185,12 +185,13 @@ if vm_rpmostree override remove non-existent-package; then fi echo "ok override remove non-existent-package fails" -vm_rpmostree install foo -if vm_rpmostree override remove foo; then +vm_build_rpm baz +vm_rpmostree install baz +if vm_rpmostree override remove baz; then assert_not_reached "override remove layered pkg foo succeeded?" fi vm_rpmostree cleanup -p -echo "ok override remove layered pkg foo fails" +echo "ok override remove layered pkg baz fails" # the next two error checks expect an upgraded layer with foo builtin vm_cmd ostree commit -b vmcheck --tree=ref=vmcheck_tmp/with_foo_and_bar