keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

postprocess: Ensure dirs are 0755 regardless of umask

Browse Source 
`umask` is one of those really evil Unix things...it's pretty
crazy actually there's still no threadsafe way to "`mkdir` ignoring umask".

This surfaced in someone using coreos-assembler with a working
directory of mode `0750` and having that surface in the target
rootfs.

Ref: https://github.com/coreos/fedora-coreos-tracker/issues/272

Closes: #1902
Approved by: jlebon
This commit is contained in:
Colin Walters 2019-09-11 13:04:42 +00:00 committed by Atomic Bot
parent 680cc10077
commit 13377d4bab
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libpriv/rpmostree-postprocess.c
View File

@ -174,10 +174,18 @@ init_rootfs (int dfd,
{ "sysroot/ostree", "ostree" },
};
/* Ensure the rootfs has the right mode, we don't want to be affected
* by umask.
**/
if (fchmod (dfd, 0755) == -1)
return glnx_throw_errno_prefix (error, "fchmod(rootfs)");
for (guint i = 0; i < G_N_ELEMENTS (toplevel_dirs); i++)
{
if (!glnx_ensure_dir (dfd, toplevel_dirs[i], 0755, error))
return FALSE;
if (fchmodat (dfd, toplevel_dirs[i], 0755, 0) == -1)
return glnx_throw_errno_prefix (error, "fchmodat");
}
for (guint i = 0; i < G_N_ELEMENTS (symlinks); i++)