From 38c2ab3397cc2b3c014665ee4c1231f3860aec7e Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Fri, 2 Nov 2018 13:26:23 -0400 Subject: [PATCH] app/compose: Minor comment tweak This is slight bikeshed, though this comment took me a second to parse because it says "not do it" right before we do it. Let's just move it up to right outside where the condition is actually tested. Closes: #1658 Approved by: cgwalters --- src/app/rpmostree-compose-builtin-tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/app/rpmostree-compose-builtin-tree.c b/src/app/rpmostree-compose-builtin-tree.c index 43309b96..1b0768fa 100644 --- a/src/app/rpmostree-compose-builtin-tree.c +++ b/src/app/rpmostree-compose-builtin-tree.c @@ -604,13 +604,12 @@ impl_install_tree (RpmOstreeTreeComposeContext *self, g_printerr ("NOTICE: Proceeding anyways.\n"); } + /* This fchdir() call is...old, dates back to when rpm-ostree wrapped + * running yum as a subprocess. It shouldn't be necessary any more, + * but let's be conservative and not do it in unified core mode. + */ if (!opt_unified_core) { - /* This call is...old, dates back to when rpm-ostree wrapped - * running yum as a subprocess. It shouldn't be necessary - * any more, but let's be conservative and not do it in - * unified core mode. - */ if (fchdir (self->workdir_dfd) != 0) return glnx_throw_errno_prefix (error, "fchdir"); }