keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

util: Initialize sack pointer to NULL

Browse Source 
Otherwise we'll be freeing uninitialized memory on error (this happened in CI
somehow).

Closes: #1246
Approved by: jlebon
This commit is contained in:
Colin Walters 2018-02-13 16:51:14 -05:00 committed by Atomic Bot
parent 99aa6f89d2
commit 40b010a7ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libpriv/rpmostree-rpm-util.c
View File

@ -828,7 +828,7 @@ rpmostree_get_refsack_for_root (int dfd,
const char *path, const char *path,
GError **error) GError **error)
{ {
g_autoptr(DnfSack) sack; /* NB: refsack adds a ref to it */ g_autoptr(DnfSack) sack = NULL; /* NB: refsack adds a ref to it */
if (!get_sack_for_root (dfd, path, &sack, error)) if (!get_sack_for_root (dfd, path, &sack, error))
return NULL; return NULL;
return rpmostree_refsack_new (sack, NULL); return rpmostree_refsack_new (sack, NULL);