keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

deploy: Don't leak file descriptor passed for local rebases

Browse Source 
Came up in https://github.com/coreos/rpm-ostree/issues/2210
This commit is contained in:
Colin Walters 2020-08-28 13:29:29 +00:00 committed by OpenShift Merge Robot
parent 122718c4af
commit 5ff769f849
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/daemon/rpmostreed-transaction-types.c
View File

@ -634,6 +634,7 @@ deploy_transaction_finalize (GObject *object)
g_clear_pointer (&self->override_replace_local_pkgs, g_object_unref);
g_free (self->override_remove_pkgs);
g_free (self->override_reset_pkgs);
glnx_close_fd (&self->local_repo_remote_dfd);
G_OBJECT_CLASS (deploy_transaction_parent_class)->finalize (object);
}
@ -981,6 +982,7 @@ deploy_transaction_execute (RpmostreedTransaction *transaction,
/* as far as the rest of the code is concerned, we're rebasing to :SHA256 now */
g_clear_pointer (&self->refspec, g_free);
self->refspec = g_strdup_printf (":%s", rev);
glnx_close_fd (&self->local_repo_remote_dfd);
}
g_autofree gchar *new_refspec = NULL;