keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

app: Wrap Version in --version in quotes

Browse Source 
Wrap the `Version` key in the YAML-compatible output of
`rpm-ostree --version` with quotes so that it's parsed as a string. The
issues with the previous approach in a nutshell:

```
In [5]: yaml.load("asdf: 2018.10")
Out[5]: {'asdf': 2018.1}
```

It's treating the version number as a floating-point. Now, this is
technically a backwards incompatible change, but given that the previous
approach is inherently broken for our needs, I don't see a way around
breaking it now.

See also: 759b099861

Closes: #1654
Approved by: cgwalters
This commit is contained in:
Jonathan Lebon 2018-11-01 17:26:40 -04:00 committed by Atomic Bot
parent ff962491a3
commit 79d4e52d99
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/main.c
View File

@ -225,7 +225,7 @@ rpmostree_option_context_parse (GOptionContext *context,
*/
g_auto(GStrv) features = g_strsplit (RPM_OSTREE_FEATURES, " ", -1);
g_print ("%s:\n", PACKAGE_NAME);
g_print (" Version: %s\n", PACKAGE_VERSION);
g_print (" Version: '%s'\n", PACKAGE_VERSION);
if (strlen (RPM_OSTREE_GITREV) > 0)
g_print (" Git: %s\n", RPM_OSTREE_GITREV);
g_print (" Features:\n");