keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tree-wide: Fix clang -Wgnu-designator/-Wunused-variable

Browse Source 
clang warns about this:
https://clang.llvm.org/docs/DiagnosticsReference.html#wgnu-designator
Also fix unused variables and hard error on them.
This commit is contained in:
Colin Walters 2021-02-05 19:51:41 +00:00 committed by OpenShift Merge Robot
parent b942bd8cf7
commit dba43e201e
6 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/app/libmain.cxx
View File

@ -500,7 +500,6 @@ rpmostree_main_inner (const rust::Slice<const rust::Str> args)
g_autofree char *prgname = g_strdup_printf ("%s %s", g_get_prgname (), command_name);
g_set_prgname (prgname);
gboolean funcres = FALSE;
RpmOstreeCommandInvocation invocation =
{ .command = command,
.command_line = command_line,

2
src/app/rpmostree-compose-builtin-tree.cxx
View File

@ -1527,7 +1527,7 @@ rpmostree_compose_builtin_extensions (int argc,
RpmOstreePackage *pkg = (RpmOstreePackage*)packages->pdata[i];
const char *name = rpm_ostree_package_get_name (pkg);
const char *evr = rpm_ostree_package_get_evr (pkg);
packages_mapping->push_back(rpmostreecxx::StringMapping {k: name, v: evr});
packages_mapping->push_back(rpmostreecxx::StringMapping{name, evr});
}
auto extensions = rpmostreecxx::extensions_load (extensions_path, basearch, *packages_mapping);

1
src/daemon/rpmostreed-utils.cxx
View File

@ -514,7 +514,6 @@ rpmostreed_repo_lookup_cached_version (OstreeRepo *repo,
{
VersionVisitorClosure closure = { version, NULL };
g_autofree char *checksum = NULL;
gboolean ret = FALSE;
g_assert (OSTREE_IS_REPO (repo));
g_assert (refspec != NULL);

3
src/libpriv/rpmostree-core.cxx
View File

@ -627,7 +627,7 @@ std::unique_ptr<rust::Vec<rpmostreecxx::StringMapping>>
rpmostree_dnfcontext_get_varsubsts (DnfContext *context)
{
auto r = std::make_unique<rust::Vec<rpmostreecxx::StringMapping>>();
r->push_back(rpmostreecxx::StringMapping {k: "basearch", v: dnf_context_get_base_arch (context) });
r->push_back(rpmostreecxx::StringMapping{"basearch", dnf_context_get_base_arch (context) });
return r;
}
@ -3708,7 +3708,6 @@ apply_rpmfi_overrides (RpmOstreeContext *self,
if (getuid () != 0)
return TRUE; /* 🔚 Early return */
int i;
g_auto(rpmfi) fi = NULL;
gboolean emitted_nonusr_warning = FALSE;
g_autofree char *path = get_package_relpath (pkg);

1
src/libpriv/rpmostree-importer.cxx
View File

@ -140,7 +140,6 @@ rpmostree_importer_read_metainfo (int fd,
gboolean ret = FALSE;
g_auto(rpmts) ts = NULL;
FD_t rpmfd;
int r;
g_auto(Header) ret_header = NULL;
g_auto(rpmfi) ret_fi = NULL;
gsize ret_cpio_offset;

1
src/libpriv/rpmostree-kernel.cxx
View File

@ -506,7 +506,6 @@ rpmostree_run_dracut (int rootfs_dfd,
GCancellable *cancellable,
GError **error)
{
gboolean ret = FALSE;
auto destdir = rpmostreecxx::cliwrap_destdir();
/* Shell wrapper around dracut to write to the O_TMPFILE fd;
* at some point in the future we should add --fd X instead of -f