From e208383526ffbaf9f51db08ad2a9cb577d93ad6c Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Thu, 13 Sep 2018 16:59:28 +0000
Subject: [PATCH] tests: Add rojig spec into base config

This is prep for fully dropping the separate spec file, which
is now just used by `commit2rojig`.

A compose test can now specify it wants YAML instead of JSON.

Closes: #1561
Approved by: jlebon
---
 tests/compose-tests/libcomposetest.sh     | 12 ++++++++++++
 tests/compose-tests/test-compose2jigdo.sh | 10 +---------
 tests/composedata/fedora-base.json        |  5 +++++
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/tests/compose-tests/libcomposetest.sh b/tests/compose-tests/libcomposetest.sh
index edb29376..54cf7db4 100644
--- a/tests/compose-tests/libcomposetest.sh
+++ b/tests/compose-tests/libcomposetest.sh
@@ -29,6 +29,7 @@ pyappendjsonmember() {
 prepare_compose_test() {
     name=$1
     shift
+    filetype=${1:-json}
     ostree --repo=${repo} init --mode=archive
     echo 'fsync=false' >> ${repo}/config
     ostree --repo=${repobuild} init --mode=bare-user
@@ -48,6 +49,17 @@ EOF
     pysetjsonmember "repos" '["fedora-local"]' ${treefile}
     # FIXME extract from json
     export treeref=fedora/stable/x86_64/${name}
+    if [ "${filetype}" = "yaml" ]; then
+        python <<EOF
+import json, yaml, sys
+ifn="${treefile}"
+ofn=ifn.replace('.json', '.yaml')
+jd=json.load(open(ifn))
+with open(ofn, "w") as f:
+  f.write(yaml.dump(jd))
+EOF
+        export treefile=composedata/fedora-${name}.yaml
+    fi
 }
 
 compose_base_argv="--repo ${repobuild}"
diff --git a/tests/compose-tests/test-compose2jigdo.sh b/tests/compose-tests/test-compose2jigdo.sh
index f182ba25..d604280e 100755
--- a/tests/compose-tests/test-compose2jigdo.sh
+++ b/tests/compose-tests/test-compose2jigdo.sh
@@ -7,15 +7,7 @@ dn=$(cd $(dirname $0) && pwd)
 . ${dn}/libcomposetest.sh
 . ${dn}/../common/libtest.sh
 
-prepare_compose_test "compose2jigdo"
-pysetjsonmember "rojig" '{ "name": "fedora-atomic-host", "license": "MIT", "summary": "Fedora Atomic Host"}'
-python <<EOF
-import json, yaml
-jd=json.load(open("$treefile"))
-with open("$treefile.yaml", "w") as f:
-  f.write(yaml.dump(jd))
-EOF
-export treefile=$treefile.yaml
+prepare_compose_test "compose2jigdo" "yaml"
 
 mkdir cache
 mkdir jigdo-output
diff --git a/tests/composedata/fedora-base.json b/tests/composedata/fedora-base.json
index e5dc691c..36a3c729 100644
--- a/tests/composedata/fedora-base.json
+++ b/tests/composedata/fedora-base.json
@@ -1,5 +1,10 @@
 {
     "ref": "fedora/stable/${basearch}",
+    "rojig": {
+        "name": "fedora-atomic-host",
+        "license": "MIT",
+        "summary": "Fedora Atomic Host"
+    },
     "releasever": "28",
 
     "repos": ["fedora", "updates"],