keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

db: Add some error prefixing around rpmdb loading

Browse Source 
In https://github.com/cockpit-project/cockpit/pull/9090#issuecomment-386564044
we're seeing:
`Txn DownloadUpdateRpmDiff ... failed: open(O_TMPFILE): No such file or directory`

Looking at the error paths in the rpmdb diff code, there's not really
any error prefixing.  Let's add some so this is easier to debug.

Closes: #1356
Approved by: jlebon
This commit is contained in:
Colin Walters 2018-05-04 08:57:37 -04:00 committed by Atomic Bot
parent 5037c85330
commit f39eeee671
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/rpmostree-package.c
View File

@ -249,6 +249,7 @@ _rpm_ostree_package_list_for_commit (OstreeRepo *repo,
GCancellable *cancellable, GCancellable *cancellable,
GError **error) GError **error)
{ {
GLNX_AUTO_PREFIX_ERROR ("Loading package list", error);
g_autofree char *checksum = NULL; g_autofree char *checksum = NULL;
if (!ostree_repo_resolve_rev (repo, rev, FALSE, &checksum, error)) if (!ostree_repo_resolve_rev (repo, rev, FALSE, &checksum, error))
return FALSE; return FALSE;

2
src/libpriv/rpmostree-rpm-util.c
View File

@ -771,6 +771,7 @@ checkout_only_rpmdb (OstreeRepo *repo,
GCancellable *cancellable, GCancellable *cancellable,
GError **error) GError **error)
{ {
GLNX_AUTO_PREFIX_ERROR ("rpmdb checkout", error);
g_autofree char *commit = NULL; g_autofree char *commit = NULL;
if (!ostree_repo_resolve_rev (repo, ref, FALSE, &commit, error)) if (!ostree_repo_resolve_rev (repo, ref, FALSE, &commit, error))
return FALSE; return FALSE;
@ -804,6 +805,7 @@ get_sack_for_root (int dfd,
DnfSack **out_sack, DnfSack **out_sack,
GError **error) GError **error)
{ {
GLNX_AUTO_PREFIX_ERROR ("Loading sack", error);
g_return_val_if_fail (out_sack != NULL, FALSE); g_return_val_if_fail (out_sack != NULL, FALSE);
g_autofree char *fullpath = glnx_fdrel_abspath (dfd, path); g_autofree char *fullpath = glnx_fdrel_abspath (dfd, path);