rpm-ostree

keremet/rpm-ostree

Fork 0

Commit Graph

Author	SHA1	Message	Date
Colin Walters	e34f17fc3e	core: Don't rm-rf directories when doing overrides It's very normal for base packages to own directories with dependent packages installing files there. Doing an rm-rf for directories was just wrong. Concretely this fixes an `override replace ./systemd-*.rpm`. librpm is also pretty conservative here (for good reason) and just ignores `ENOTEMPTY`, so let's match that. I opted to split things up so we remove not-directories in a first pass, then remove all directories we can in the second. This should maximize our chances of removing what we can in a scenario where e.g. two co-dependent packages install files to a directory one of them owns. Closes: https://github.com/projectatomic/rpm-ostree/issues/1340 Closes: #1341 Approved by: jlebon	2018-04-20 16:07:44 +00:00

Author

SHA1

Message

Date

Colin Walters

e34f17fc3e

core: Don't rm-rf directories when doing overrides

It's very normal for base packages to own directories with
dependent packages installing files there.  Doing an rm-rf
for directories was just wrong.  Concretely this fixes
an `override replace ./systemd-*.rpm`.

librpm is also pretty conservative here (for good reason)
and just ignores `ENOTEMPTY`, so let's match that.

I opted to split things up so we remove not-directories
in a first pass, then remove all directories we can in the
second.  This should maximize our chances of removing what we can
in a scenario where e.g. two co-dependent packages install files
to a directory one of them owns.

Closes: https://github.com/projectatomic/rpm-ostree/issues/1340

Closes: #1341
Approved by: jlebon

2018-04-20 16:07:44 +00:00

1 Commits