2 Commits

Author	SHA1	Message	Date
Jonathan Lebon	6c933bbf3c	lib/package: fix package diffs for multilib ... Our complicated heuristics for handling multiple packages of the same name comes back to bite us. In the multilib case, we can have packages of the same NEVR, but different arch, sitting in the same tree. Previously, even if the arch was different, we would still mark it as an upgrade or downgrade. But that complicates things in the case of multiple packages of the same name in the same tree. We greatly simplify things here by making the diff algorithm dumber. We now only consider a package as "modified" (i.e. upgraded/downgraded) if it has the same NA (but different EVR). This makes handling multilib cases natural and seems worth it overall vs trying to handle the odd e.g. noarch <--> archful pkg transitions that could happen. Closes: #1230 Approved by: cgwalters	2018-02-06 21:30:48 +00:00
Jonathan Lebon	37273705dd	app/db-diff: make use of new db API ... This is the first step towards unifying how we introspect packages from a specific commit. We currently do this in three ways: libdnf, librpm, and now `rpmostree.rpmdb.pkglist`. I'd like to get to a point where we only have `rpmostree.rpmdb.pkglist` and libdnf, the latter only when more complex queries are required. This patch teaches the `db diff` command to make use of the new db diff API so that it can work even on metadata-only commits. This is relevant for use cases mentioned in #558. I didn't get rid of the `rpmhdrs_diff` functions right now because of the `--changelogs` option: libdnf currently does not expose this, so we fall back to the previous API in that case. OTOH, I wonder how much it's actually used in the wild; maybe we could just nix it? Closes: #1162 Approved by: cgwalters	2017-12-30 11:32:38 +00:00