rpm-ostree

keremet/rpm-ostree

Fork 0

Commit Graph

Author	SHA1	Message	Date
Jonathan Lebon	f098d22e03	tests/vmcheck: Create correct base commits from layered Our trick of using layered commits as base commit updates doesn't jive well with the new opportunistic reuse of the base rpmdb. The issue is that a layered commit includes the rpmdb of its base commit at the `/usr/lib/sysimage` location. So to convert it into a proper base commit means that the layered rpmdb should move there. Closes: #1502 Approved by: cgwalters	2018-09-17 20:07:45 +00:00
Jonathan Lebon	86f2b67d2b	vmcheck: Store temporary files in /var/tmp instead Since `/tmp` might be on tmpfs, so we'd lose it on reboot. But we have tests that need it to persist across reboots. Closes: #1531 Approved by: miabbott	2018-09-07 14:20:01 +00:00
Colin Walters	e34f17fc3e	core: Don't rm-rf directories when doing overrides It's very normal for base packages to own directories with dependent packages installing files there. Doing an rm-rf for directories was just wrong. Concretely this fixes an `override replace ./systemd-*.rpm`. librpm is also pretty conservative here (for good reason) and just ignores `ENOTEMPTY`, so let's match that. I opted to split things up so we remove not-directories in a first pass, then remove all directories we can in the second. This should maximize our chances of removing what we can in a scenario where e.g. two co-dependent packages install files to a directory one of them owns. Closes: https://github.com/projectatomic/rpm-ostree/issues/1340 Closes: #1341 Approved by: jlebon	2018-04-20 16:07:44 +00:00

Author

SHA1

Message

Date

Jonathan Lebon

f098d22e03

tests/vmcheck: Create correct base commits from layered

Our trick of using layered commits as base commit updates doesn't jive
well with the new opportunistic reuse of the base rpmdb. The issue is
that a layered commit includes the rpmdb of *its* base commit at the
`/usr/lib/sysimage` location. So to convert it into a proper base commit
means that the layered rpmdb should move there.

Closes: #1502
Approved by: cgwalters

2018-09-17 20:07:45 +00:00

Jonathan Lebon

86f2b67d2b

vmcheck: Store temporary files in /var/tmp instead

Since `/tmp` might be on tmpfs, so we'd lose it on reboot. But we have
tests that need it to persist across reboots.

Closes: #1531
Approved by: miabbott

2018-09-07 14:20:01 +00:00

Colin Walters

e34f17fc3e

core: Don't rm-rf directories when doing overrides

It's very normal for base packages to own directories with
dependent packages installing files there.  Doing an rm-rf
for directories was just wrong.  Concretely this fixes
an `override replace ./systemd-*.rpm`.

librpm is also pretty conservative here (for good reason)
and just ignores `ENOTEMPTY`, so let's match that.

I opted to split things up so we remove not-directories
in a first pass, then remove all directories we can in the
second.  This should maximize our chances of removing what we can
in a scenario where e.g. two co-dependent packages install files
to a directory one of them owns.

Closes: https://github.com/projectatomic/rpm-ostree/issues/1340

Closes: #1341
Approved by: jlebon

2018-04-20 16:07:44 +00:00

3 Commits