rpm-ostree

keremet/rpm-ostree

Fork 0

Commit Graph

Author	SHA1	Message	Date
Jonathan Lebon	02b25c616d	libpriv/kargs: Strengthen and simplify new kargs APIs Note this patch only touches the new APIs that aren't part of libostree. Now that we can use `g_ptr_array_find_with_equal_func`, we can drop our custom `_ostree_ptr_array_find`. Also strengthen our handling of values everywhere to handle the `NULL` case and properly support `KEYWORD` args. I ended up getting rid of `_ostree_kernel_arg_query_status` in the process since it made that assumption a lot and overall added more complexity than necessary. Closes: #1796 Approved by: cgwalters	2019-03-23 18:48:05 +00:00
Jonathan Lebon	96130810a5	tests/test-kargs: Check for no error first When we expect a test to not fail, let's `g_assert_no_error` first so that if it fails, we get an exact printout of what error we encountered when we expected none. Closes: #1796 Approved by: cgwalters	2019-03-23 18:48:05 +00:00
Ruixin Bao	5ca9c731d7	tests/check: Add unit tests for kargs options Added unit tests for rpm-ostree ex kargs --delete, --append and --replace. Also exposed two getter functions for kargs table and array so people can retrieve information from kargs. Also includes a minor fix for a bug caught by the unit test. Closes: #1013 Approved by: cgwalters	2017-11-06 18:49:36 +00:00

Author

SHA1

Message

Date

Jonathan Lebon

02b25c616d

libpriv/kargs: Strengthen and simplify new kargs APIs

Note this patch only touches the *new* APIs that aren't part of
libostree.

Now that we can use `g_ptr_array_find_with_equal_func`, we can drop our
custom `_ostree_ptr_array_find`.

Also strengthen our handling of values everywhere to handle the `NULL`
case and properly support `KEYWORD` args. I ended up getting rid of
`_ostree_kernel_arg_query_status` in the process since it made that
assumption a lot and overall added more complexity than necessary.

Closes: #1796
Approved by: cgwalters

2019-03-23 18:48:05 +00:00

Jonathan Lebon

96130810a5

tests/test-kargs: Check for no error first

When we expect a test to not fail, let's `g_assert_no_error` first so
that if it fails, we get an exact printout of what error we encountered
when we expected none.

Closes: #1796
Approved by: cgwalters

2019-03-23 18:48:05 +00:00

Ruixin Bao

5ca9c731d7

tests/check: Add unit tests for kargs options

Added unit tests for rpm-ostree ex kargs --delete,
--append and --replace.

Also exposed two getter functions for kargs table
and array so people can retrieve information from
kargs.

Also includes a minor fix for a bug caught by the unit
test.

Closes: #1013
Approved by: cgwalters

2017-11-06 18:49:36 +00:00

3 Commits