rpm-ostree

keremet/rpm-ostree

Fork 0

Commit Graph

Author	SHA1	Message	Date
Colin Walters	1c8c755e81	tests: Split test-basic into misc-{1,2} Our test suite originated when package layering was still being developed, but now that that's mature, the logic where layering tests are distinct makes less sense. The `basic` test had grown to really be a collection of many miscellaneous things. Let's make that more explicit. Further, let's avoid having each test suite grow too large; when a single test fails we don't have an easy way to rerun just that test, so a crude way to have faster local iteration is to split into groups. My plan is to reintroduce a `basic` test that covers the basics of all functionality - update, deploy, layering, etc. The advanced/corner cases of layering like the `rm -rf /` test would still live in a `test-layering.sh` or so. Closes: #1336 Approved by: jlebon	2018-04-16 17:53:20 +00:00
Jonathan Lebon	4291500368	daemon: Also generate CachedUpdate in DownloadUpdateRpmDiff Moving to caching the GVariant to disk rather than during RPMOSTreeOS reloads broke the legacy `DownloadUpdateRpmDiff` path because it relied on the implied recalculations that occur on reloads to update `CachedUpdate`. This patch series was initially going to be about just migrating all the legacy APIs to make use of the new metadata, which would have fixed this properly. But we first need some real coverage in that aread, which is very poor right now. I'd like to investigate integrating the Cockpit tests (at least the ostree-specific parts) into our CI to remedy this. Anyways, for now at least, let's fix Cockpit. Closes: #1300 Closes: #1303 Approved by: cgwalters	2018-03-17 20:17:32 +00:00
Jonathan Lebon	45a3b53558	daemon/api: fix legacy D-Bus API and add coverage Fix logic to make sure we check if the refspec is of type `ostree://` even when it's explicitly specified. Also fix `Deploy` in the case where we didn't just `Download` the RPM diff by adding a new @checksum parameter to the higher-level API. Finally, add a basic test for the `GetCachedRpmDiff` APIs so we have at least some* coverage. This is also good prep for making sure we don't break anything when we convert those APIs to use the more efficient pkglist metadata. The tests completely ignore the `DownloadRpmDiff` paths for now though. Closes: #1250 Closes: #1253 Approved by: cgwalters	2018-02-15 15:03:05 +00:00

Author

SHA1

Message

Date

Colin Walters

1c8c755e81

tests: Split test-basic into misc-{1,2}

Our test suite originated when package layering was still being
developed, but now that that's mature, the logic where layering
tests are distinct makes less sense.

The `basic` test had grown to really be a collection of many
miscellaneous things.  Let's make that more explicit.  Further,
let's avoid having each test suite grow too large; when a single
test fails we don't have an easy way to rerun just that test,
so a crude way to have faster local iteration is to split into groups.

My plan is to reintroduce a `basic` test that covers the basics
of all functionality - update, deploy, layering, etc.  The advanced/corner
cases of layering like the `rm -rf /` test would still live in a
`test-layering.sh` or so.

Closes: #1336
Approved by: jlebon

2018-04-16 17:53:20 +00:00

Jonathan Lebon

4291500368

daemon: Also generate CachedUpdate in DownloadUpdateRpmDiff

Moving to caching the GVariant to disk rather than during RPMOSTreeOS
reloads broke the legacy `DownloadUpdateRpmDiff` path because it relied
on the implied recalculations that occur on reloads to update
`CachedUpdate`.

This patch series was initially going to be about just migrating all the
legacy APIs to make use of the new metadata, which would have fixed this
properly. But we first need some real coverage in that aread, which is
very poor right now. I'd like to investigate integrating the Cockpit
tests (at least the ostree-specific parts) into our CI to remedy this.

Anyways, for now at least, let's fix Cockpit.

Closes: #1300

Closes: #1303
Approved by: cgwalters

2018-03-17 20:17:32 +00:00

Jonathan Lebon

45a3b53558

daemon/api: fix legacy D-Bus API and add coverage

Fix logic to make sure we check if the refspec is of type `ostree://`
even when it's explicitly specified. Also fix `Deploy` in the case where
we didn't just `Download` the RPM diff by adding a new @checksum
parameter to the higher-level API.

Finally, add a basic test for the `GetCached*RpmDiff` APIs so we have at
least *some* coverage. This is also good prep for making sure we don't
break anything when we convert those APIs to use the more efficient
pkglist metadata. The tests completely ignore the `DownloadRpmDiff`
paths for now though.

Closes: #1250

Closes: #1253
Approved by: cgwalters

2018-02-15 15:03:05 +00:00

3 Commits