2 Commits

Author	SHA1	Message	Date
Colin Walters	732e0f232a	daemon: Fix crash on upgrade with remote:checksum ... The refspec code really needs to be cleaned up and oxidized (and unit tested more). The original intention is that if you're pinned to a commit, we say "No upgrade available" but we were crashing if one (understandably) rebased to the combination of `remote:checksum` instead of just `checksum`. But, we can't change the classifier to call this `CHECKSUM` and output an error, because that just conflicts with us accepting the syntax `rpm-ostree rebase :<checksum>`. I'm actually coming around to the idea that this `remote:checksum` syntax means "no upgrade available" is correct, whereas pinning to just `checksum` is more of an error when you try to upgrade. Closes: https://github.com/coreos/rpm-ostree/issues/2603	2021-03-01 16:57:51 +01:00
Colin Walters	27bd7b97bb	Handle "pinned commits" specifically ... There are a few scenarios today where one might deliver content to a machine via an external transport. For example, take the scenario of a single server updated via USB drive. While we can provide a refspec...what should the remote be? (This gets into ostree collections). There's nothing really that can happen when typing `rpm-ostree upgrade` unless the USB stick is plugged in. That type of scenario should be emphasized by pinning the commit - the machine is updated via an external script. Another case: we're experimenting embedding OSTree commits inside OCI containers. Here again since rpm-ostree can't understand how to pull content from containers, it's saner to drop the refspec bits, and pin to a commit. Further enhancements will follow to make the admin experience more obvious. Closes: #1396 Approved by: jlebon	2018-06-11 20:37:58 +00:00